Page MenuHomePhabricator

[clangd] Control the delay between index hot reloading in remote-server-index
AbandonedPublic

Authored by kbobyrev on Nov 1 2020, 11:47 PM.

Details

Reviewers
kadircet
Summary

This helps reduce the time needed for remote-server-index shutdown.

Diff Detail

Event Timeline

kbobyrev created this revision.Nov 1 2020, 11:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 1 2020, 11:47 PM
kbobyrev requested review of this revision.Nov 1 2020, 11:47 PM
kadircet added inline comments.Nov 2 2020, 12:08 AM
clang-tools-extra/clangd/index/remote/server/Server.cpp
78

this was 30 before. not that it matters.

79

i think this might be useful in general, as servers will have different pull frequency for newer index. so maybe make it non-hidden.

clang-tools-extra/clangd/test/remote-index/pipeline_helper.py
35

let's set it to 1. clangd tests already takes about 3-4 seconds to run on (our) workstations. it feels like this might end up increasing the test latency.

kadircet accepted this revision.Nov 2 2020, 12:08 AM
This revision is now accepted and ready to land.Nov 2 2020, 12:08 AM
kbobyrev abandoned this revision.Nov 2 2020, 12:35 AM

As discussed in PM, it probably doesn't make sense right now.