This is an archive of the discontinued LLVM Phabricator instance.

Differential D90509

[NFC][AMDGPU] Minor cleanup to AMDGPU memory model table
ClosedPublic

Authored by t-tye on Oct 30 2020, 3:38 PM.

Details

Reviewers
kzhuravl
scott.linder
Commits
rGfccf4f6addc8: [NFC][AMDGPU] Minor cleanup to AMDGPU memory model table

Diff Detail

Unit TestsFailed

TimeTest
400 mslinux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp

Event Timeline

t-tye created this revision.Oct 30 2020, 3:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 30 2020, 3:38 PM
Herald added subscribers: llvm-commits, kerbowa, tpr and 4 others. · View Herald Transcript
t-tye requested review of this revision.Oct 30 2020, 3:38 PM
Herald added a subscriber: wdng. · View Herald TranscriptOct 30 2020, 3:38 PM
scott.linder accepted this revision.Oct 30 2020, 3:41 PM
This revision is now accepted and ready to land.Oct 30 2020, 3:41 PM
This revision was landed with ongoing or failed builds.Oct 30 2020, 3:50 PM
Closed by commit rGfccf4f6addc8: [NFC][AMDGPU] Minor cleanup to AMDGPU memory model table (authored by t-tye). · Explain Why
This revision was automatically updated to reflect the committed changes.
t-tye added a commit: rGfccf4f6addc8: [NFC][AMDGPU] Minor cleanup to AMDGPU memory model table.
Harbormaster completed remote builds in B77105: Diff 302030.Oct 30 2020, 4:31 PM

Revision Contents

PathSize
llvm/
docs/
24 lines

Diff 302030

llvm/docs/AMDGPUUsage.rst

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 5,313 Lines • ▼ Show 20 Lines atomicrmw release - workgroup - local 1. waitcnt vmcnt(0) & vscnt(0)
1. ds_atomic 2. ds_atomic 1. ds_atomic 2. ds_atomic
atomicrmw release - workgroup - generic 1. s_waitcnt lgkmcnt(0) 1. s_waitcnt lgkmcnt(0) & atomicrmw release - workgroup - generic 1. s_waitcnt lgkmcnt(0) 1. s_waitcnt lgkmcnt(0) &
vmcnt(0) & vscnt(0) vmcnt(0) & vscnt(0)
- If CU wavefront execution - If CU wavefront execution
mode, omit vmcnt(0) and mode, omit vmcnt(0) and
vscnt(0). vscnt(0).
- If OpenCL, omit. - If OpenCL, omit - If OpenCL, omit. - If OpenCL, omit
waitcnt lgkmcnt(0). lgkmcnt(0).
- Must happen after - Must happen after
any preceding any preceding
local/generic local/generic
load/store/load load/store/load
atomic/store atomic/store
atomic/atomicrmw. atomic/atomicrmw.
- Could be split into - Could be split into
separate s_waitcnt separate s_waitcnt
▲ Show 20 Lines • Show All 246 Lines • ▼ Show 20 Lines atomicrmw acq_rel - singlethread - global 1. buffer/global/ds/flat_atomic 1. buffer/global/ds/flat_atomic
- generic - generic
atomicrmw acq_rel - workgroup - global 1. s_waitcnt lgkmcnt(0) 1. s_waitcnt lgkmcnt(0) & atomicrmw acq_rel - workgroup - global 1. s_waitcnt lgkmcnt(0) 1. s_waitcnt lgkmcnt(0) &
vmcnt(0) & vscnt(0) vmcnt(0) & vscnt(0)
- If CU wavefront execution - If CU wavefront execution
mode, omit vmcnt(0) and mode, omit vmcnt(0) and
vscnt(0). vscnt(0).
- If OpenCL, omit. - If OpenCL, omit - If OpenCL, omit. - If OpenCL, omit
s_waitcnt lgkmcnt(0). lgkmcnt(0).
- Must happen after - Must happen after - Must happen after - Must happen after
any preceding any preceding any preceding any preceding
local/generic local/generic local/generic local/generic
load/store/load load/store/load load/store/load load/store/load
atomic/store atomic/store atomic/store atomic/store
atomic/atomicrmw. atomic/atomicrmw. atomic/atomicrmw. atomic/atomicrmw.
- Could be split into - Could be split into
separate s_waitcnt separate s_waitcnt
vmcnt(0), s_waitcnt vmcnt(0), s_waitcnt
vscnt(0) and s_waitcnt vscnt(0), and s_waitcnt
lgkmcnt(0) to allow lgkmcnt(0) to allow
them to be them to be
independently moved independently moved
according to the according to the
following rules. following rules.
- s_waitcnt vmcnt(0) - s_waitcnt vmcnt(0)
must happen after must happen after
any preceding any preceding
Show All 24 Lines atomicrmw acq_rel - workgroup - global 1. s_waitcnt lgkmcnt(0) 1. s_waitcnt lgkmcnt(0) &
performing the performing the performing the performing the
atomicrmw that is atomicrmw that is atomicrmw that is atomicrmw that is
being released. being released. being released. being released.
2. buffer/global_atomic 2. buffer/global_atomic 2. buffer/global_atomic 2. buffer/global_atomic
3. s_waitcnt vm/vscnt(0) 3. s_waitcnt vm/vscnt(0)
- If CU wavefront execution - If CU wavefront execution
mode, omit vm/vscnt(0). mode, omit.
- Use vmcnt(0) if atomic with - Use vmcnt(0) if atomic with
return and vscnt(0) if return and vscnt(0) if
atomic with no-return. atomic with no-return.
waitcnt lgkmcnt(0).
- Must happen before - Must happen before
the following the following
buffer_gl0_inv. buffer_gl0_inv.
- Ensures any - Ensures any
following global following global
data read is no data read is no
older than the older than the
atomicrmw value atomicrmw value
▲ Show 20 Lines • Show All 72 Lines • ▼ Show 20 Lines atomicrmw acq_rel - workgroup - local 1. waitcnt vmcnt(0) & vscnt(0)
stale data. stale data.
atomicrmw acq_rel - workgroup - generic 1. s_waitcnt lgkmcnt(0) 1. s_waitcnt lgkmcnt(0) & atomicrmw acq_rel - workgroup - generic 1. s_waitcnt lgkmcnt(0) 1. s_waitcnt lgkmcnt(0) &
vmcnt(0) & vscnt(0) vmcnt(0) & vscnt(0)
- If CU wavefront execution - If CU wavefront execution
mode, omit vmcnt(0) and mode, omit vmcnt(0) and
vscnt(0). vscnt(0).
- If OpenCL, omit. - If OpenCL, omit - If OpenCL, omit. - If OpenCL, omit lgkmcnt(0).
waitcnt lgkmcnt(0).
- Must happen after - Must happen after
any preceding any preceding
local/generic local/generic
load/store/load load/store/load
atomic/store atomic/store
atomic/atomicrmw. atomic/atomicrmw.
- Could be split into - Could be split into
separate s_waitcnt separate s_waitcnt
Show All 32 Lines atomicrmw acq_rel - workgroup - generic 1. s_waitcnt lgkmcnt(0) 1. s_waitcnt lgkmcnt(0) &
to local have have to local have have
completed before completed before completed before completed before
performing the performing the performing the performing the
atomicrmw that is atomicrmw that is atomicrmw that is atomicrmw that is
being released. being released. being released. being released.
2. flat_atomic 2. flat_atomic 2. flat_atomic 2. flat_atomic
3. s_waitcnt lgkmcnt(0) 3. s_waitcnt lgkmcnt(0) & 3. s_waitcnt lgkmcnt(0) 3. s_waitcnt lgkmcnt(0) &
vm/vscnt(0) vmcnt(0) & vscnt(0)
- If CU wavefront execution - If CU wavefront execution
mode, omit vm/vscnt(0). mode, omit vmcnt(0) and
- If OpenCL, omit. - If OpenCL, omit vscnt(0).
waitcnt lgkmcnt(0). - If OpenCL, omit. - If OpenCL, omit lgkmcnt(0).
- Must happen before - Must happen before - Must happen before - Must happen before
any following the following any following the following
global/generic buffer_gl0_inv. global/generic buffer_gl0_inv.
load/load load/load
atomic/store/store atomic/store/store
atomic/atomicrmw. atomic/atomicrmw.
- Ensures any - Ensures any - Ensures any - Ensures any
following global following global following global following global
▲ Show 20 Lines • Show All 88 Lines • ▼ Show 20 Lines
atomicrmw acq_rel - agent - generic 1. s_waitcnt lgkmcnt(0) & 1. s_waitcnt lgkmcnt(0) & atomicrmw acq_rel - agent - generic 1. s_waitcnt lgkmcnt(0) & 1. s_waitcnt lgkmcnt(0) &
- system vmcnt(0) vmcnt(0) & vscnt(0) - system vmcnt(0) vmcnt(0) & vscnt(0)
- If OpenCL, omit - If OpenCL, omit - If OpenCL, omit - If OpenCL, omit
lgkmcnt(0). lgkmcnt(0). lgkmcnt(0). lgkmcnt(0).
- Could be split into - Could be split into - Could be split into - Could be split into
separate s_waitcnt separate s_waitcnt separate s_waitcnt separate s_waitcnt
vmcnt(0) and vmcnt(0), s_waitcnt vmcnt(0) and vmcnt(0), s_waitcnt
s_waitcnt vscnt(0) and s_waitcnt s_waitcnt vscnt(0), and s_waitcnt
lgkmcnt(0) to allow lgkmcnt(0) to allow lgkmcnt(0) to allow lgkmcnt(0) to allow
them to be them to be them to be them to be
independently moved independently moved independently moved independently moved
according to the according to the according to the according to the
following rules. following rules. following rules. following rules.
- s_waitcnt vmcnt(0) - s_waitcnt vmcnt(0) - s_waitcnt vmcnt(0) - s_waitcnt vmcnt(0)
must happen after must happen after must happen after must happen after
any preceding any preceding any preceding any preceding
▲ Show 20 Lines • Show All 305 Lines • ▼ Show 20 Lines load atomic seq_cst - workgroup - global 1. s_waitcnt lgkmcnt(0) 1. s_waitcnt lgkmcnt(0) &
- generic vmcnt(0) & vscnt(0) - generic vmcnt(0) & vscnt(0)
- If CU wavefront execution - If CU wavefront execution
mode, omit vmcnt(0) and mode, omit vmcnt(0) and
vscnt(0). vscnt(0).
- Could be split into - Could be split into
separate s_waitcnt separate s_waitcnt
vmcnt(0), s_waitcnt vmcnt(0), s_waitcnt
vscnt(0) and s_waitcnt vscnt(0), and s_waitcnt
lgkmcnt(0) to allow lgkmcnt(0) to allow
them to be them to be
independently moved independently moved
according to the according to the
following rules. following rules.
- Must - waitcnt lgkmcnt(0) must - Must - waitcnt lgkmcnt(0) must
happen after happen after happen after happen after
preceding preceding preceding preceding
▲ Show 20 Lines • Show All 1,804 Lines • Show Last 20 Lines