This is an archive of the discontinued LLVM Phabricator instance.

[CFG] Replace hardcoded max BBs explored as CL option. NFC.
ClosedPublic

Authored by anna on Oct 30 2020, 11:07 AM.

Details

Summary

This option was hardcoded to 32. Changing this as a CL option since we
have seen some cases downstream where increasing this limit allows us to
disprove reachability.

Diff Detail

Event Timeline

anna created this revision.Oct 30 2020, 11:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 30 2020, 11:07 AM
anna requested review of this revision.Oct 30 2020, 11:07 AM
jdoerfert accepted this revision.Oct 30 2020, 11:15 AM

LGTM, one nit though

llvm/lib/Analysis/CFG.cpp
164

If you initialize with DefaultMaxBBsToExplore you don't need to read the global multiple times.

This revision is now accepted and ready to land.Oct 30 2020, 11:15 AM
anna added inline comments.Oct 30 2020, 11:36 AM
llvm/lib/Analysis/CFG.cpp
164

good point, will do. Thanks for the review Johannes!

This revision was landed with ongoing or failed builds.Oct 30 2020, 12:12 PM
This revision was automatically updated to reflect the committed changes.