This is an archive of the discontinued LLVM Phabricator instance.

Address ABI issues introduced with CXCursor_CXXAddrspaceCastExpr

Authored by mantognini on Oct 29 2020, 4:48 AM.



Revert values in CXCursorKind as they were before
CXCursor_CXXAddrspaceCastExpr was introduced in a6a237f2046a ([OpenCL]
Added addrspace_cast operator in C++ mode., 2020-05-18).

Insert CXCursor_CXXAddrspaceCastExpr after the last expression in
CXCursorKind using the next available value.

Diff Detail

Event Timeline

mantognini created this revision.Oct 29 2020, 4:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 29 2020, 4:48 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript


mantognini published this revision for review.Oct 29 2020, 6:39 AM

A follow up on

I don't understand the buildbot failure, I assume it's unrelated to this change.

Feel free to add anyone you feel is relevant to review this change.

akyrtzi accepted this revision.Oct 29 2020, 8:30 AM
This revision is now accepted and ready to land.Oct 29 2020, 8:30 AM
svenvh accepted this revision.Oct 30 2020, 3:27 AM
svenvh added a subscriber: svenvh.

LGTM. I also checked that this brings Index.h back in sync with bindings/python/clang/ again.

We are not exposing CXCursor_CXXAddrspaceCastExpr through the python bindings, but some other values are missing too so that's beyond the scope of this fix.

This revision was landed with ongoing or failed builds.Oct 30 2020, 7:12 AM
This revision was automatically updated to reflect the committed changes.