Page MenuHomePhabricator

[mlir] Catch async.yield operands not matching the number of async.execute results.
ClosedPublic

Authored by csigg on Oct 27 2020, 12:01 AM.

Diff Detail

Event Timeline

csigg created this revision.Oct 27 2020, 12:01 AM
csigg requested review of this revision.Oct 27 2020, 12:01 AM
rriddle added inline comments.Oct 27 2020, 12:06 AM
mlir/lib/Dialect/Async/IR/Async.cpp
107–108

Could you just do: op.getOperandTypes() == types here instead?

107–108
  • Meant != here.
csigg updated this revision to Diff 300916.Oct 27 2020, 1:46 AM

Much cleaner, thanks River!

mlir/lib/Dialect/Async/IR/Async.cpp
107–108

Indeed. Thanks for the suggestion.

ezhulenev accepted this revision.Oct 27 2020, 2:44 AM
This revision is now accepted and ready to land.Oct 27 2020, 2:44 AM