This is an archive of the discontinued LLVM Phabricator instance.

	Show First 20 Lines • Show All 98 Lines • ▼ Show 20 Lines

	static LogicalResult verify(YieldOp op) {			static LogicalResult verify(YieldOp op) {
	// Get the underlying value types from async values returned from the			// Get the underlying value types from async values returned from the
	// parent `async.execute` operation.			// parent `async.execute` operation.
	auto executeOp = op.getParentOfType<ExecuteOp>();			auto executeOp = op.getParentOfType<ExecuteOp>();
	auto types = llvm::map_range(executeOp.results(), [](const OpResult &result) {			auto types = llvm::map_range(executeOp.results(), [](const OpResult &result) {
	return result.getType().cast<ValueType>().getValueType();			return result.getType().cast<ValueType>().getValueType();
	});			});

	if (!std::equal(types.begin(), types.end(), op.getOperandTypes().begin()))			if (op.getOperandTypes() != types)
				rriddleUnsubmitted Not Done Reply Inline Actions Could you just do: `op.getOperandTypes() == types` here instead? rriddle: Could you just do: `op.getOperandTypes() == types` here instead?
				rriddleUnsubmitted Not Done Reply Inline Actions Meant `!=` here. rriddle: * Meant `!=` here.
				csiggAuthorUnsubmitted Done Reply Inline Actions Indeed. Thanks for the suggestion. csigg: Indeed. Thanks for the suggestion.
	return op.emitOpError("Operand types do not match the types returned from "			return op.emitOpError("operand types do not match the types returned from "
	"the parent ExecuteOp");			"the parent ExecuteOp");

	return success();			return success();
	}			}

	//===----------------------------------------------------------------------===//			//===----------------------------------------------------------------------===//
	/// ExecuteOp			/// ExecuteOp
	//===----------------------------------------------------------------------===//			//===----------------------------------------------------------------------===//
	▲ Show 20 Lines • Show All 115 Lines • ▼ Show 20 Lines

	static LogicalResult verify(ExecuteOp op) {			static LogicalResult verify(ExecuteOp op) {
	// Unwrap async.execute value operands types.			// Unwrap async.execute value operands types.
	auto unwrappedTypes = llvm::map_range(op.operands(), [](Value operand) {			auto unwrappedTypes = llvm::map_range(op.operands(), [](Value operand) {
	return operand.getType().cast<ValueType>().getValueType();			return operand.getType().cast<ValueType>().getValueType();
	});			});

	// Verify that unwrapped argument types matches the body region arguments.			// Verify that unwrapped argument types matches the body region arguments.
	if (llvm::size(unwrappedTypes) != llvm::size(op.body().getArgumentTypes()))			if (op.body().getArgumentTypes() != unwrappedTypes)
	return op.emitOpError("the number of async body region arguments does not "
	"match the number of execute operation arguments");

	if (!std::equal(unwrappedTypes.begin(), unwrappedTypes.end(),
	op.body().getArgumentTypes().begin()))
	return op.emitOpError("async body region argument types do not match the "			return op.emitOpError("async body region argument types do not match the "
	"execute operation arguments types");			"execute operation arguments types");

	return success();			return success();
	}			}

	//===----------------------------------------------------------------------===//			//===----------------------------------------------------------------------===//
	/// AwaitOp			/// AwaitOp
	▲ Show 20 Lines • Show All 49 Lines • Show Last 20 Lines

This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Catch async.yield operands not matching the number of async.execute results.ClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 301068

mlir/lib/Dialect/Async/IR/Async.cpp

[mlir] Catch async.yield operands not matching the number of async.execute results.
ClosedPublic