This is somewhat working version able to handle cross block DSE across PHI merges. This is not a final patch in any means. It should be possible to extract several NFCs, split to smaller pieces, tests, etc. If someone wants to take over and continue it would be great. If not I will do my best to push changes as schedule permits. Anyway any feedback is welcome.
Details
Details
- Reviewers
- None
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Great, thanks for sharing!
This currently seems to lead to a bit less stores removed overall on MultiSource/SPEC2000/SPEC2006 with -O3 -flto, but that might be related to some of the limits needing adjustments.
As a first step, it would probably be good to add a set of tests for the new functionality.
Comment Actions
Thanks for giving it a try!
Did you use latest update? If not would be nice to remeasure.
Unfortunately, I don't have access to mentioned Spec and not aware of Multisource benchmarks to look on my side. Is it feasible for you to share IR's for several cases so I could take a look? Would be nice to have them in regression test suite anyway.
On the other side I can try to run similar experiment on our internal tests.
Comment Actions
This currently seems to lead to a bit less stores removed overall on MultiSource/SPEC2000/SPEC2006 with -O3 -flto, but that might be related to some of the limits needing adjustments.
I found PartialLimit preventing DSE to optimize one of my simple cases. Here is the fix https://reviews.llvm.org/D90371 which I believe is beneficial regardless.
I also noted in case of earlier access is overwritten by the later one from the beginning and the end we DSE only beginning. Did you meet such behavior? Any plans fixing that?
Thanks
Evgeniy