This is an archive of the discontinued LLVM Phabricator instance.

[runtimes] Do not set XXX_STANDALONE_BUILD for libc++/abi/unwind
ClosedPublic

Authored by ldionne on Oct 22 2020, 9:04 PM.

Details

Summary

The runtimes build was lying to the various runtimes builds by setting
XXX_STANDALONE_BUILD=ON when they are really not being built standalone.
Only COMPILER_RT_STANDALONE_BUILD appears to be necessary, but setting it
for the other runtimes actually breaks everything.

Diff Detail

Event Timeline

ldionne created this revision.Oct 22 2020, 9:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 22 2020, 9:04 PM
ldionne requested review of this revision.Oct 22 2020, 9:04 PM
phosek accepted this revision.Oct 22 2020, 9:16 PM

LGTM

This revision is now accepted and ready to land.Oct 22 2020, 9:16 PM
This revision was landed with ongoing or failed builds.Oct 22 2020, 10:10 PM
This revision was automatically updated to reflect the committed changes.