Page MenuHomePhabricator

[mlir] Link with pthreads in AsyncRuntime
ClosedPublic

Authored by ezhulenev on Oct 22 2020, 1:36 PM.

Details

Summary

AsyncRuntime must be explicitly linked with LLVM pthreads

Diff Detail

Unit TestsFailed

TimeTest
190 mswindows > LLVM.DebugInfo/X86::convert-debugloc.ll
Script: -- : 'RUN: at line 1'; c:\ws\w32-1\llvm-project\premerge-checks\build\bin\llc.exe -mtriple=x86_64-pc-windows-gnu -dwarf-version=4 -filetype=obj -O0 < C:\ws\w32-1\llvm-project\premerge-checks\llvm\test\DebugInfo\X86\convert-debugloc.ll | c:\ws\w32-1\llvm-project\premerge-checks\build\bin\llvm-dwarfdump.exe - | c:\ws\w32-1\llvm-project\premerge-checks\build\bin\filecheck.exe C:\ws\w32-1\llvm-project\premerge-checks\llvm\test\DebugInfo\X86\convert-debugloc.ll --check-prefix=NOCONV "--implicit-check-not={{DW_TAG|NULL}}"

Event Timeline

ezhulenev created this revision.Oct 22 2020, 1:36 PM
ezhulenev requested review of this revision.Oct 22 2020, 1:36 PM
ezhulenev retitled this revision from Link with ptrheads to [mlir] Link with pthreads in AsyncRuntime.Oct 22 2020, 1:37 PM
ezhulenev edited the summary of this revision. (Show Details)
ezhulenev added a reviewer: mehdi_amini.
mehdi_amini added inline comments.Oct 22 2020, 3:24 PM
mlir/lib/ExecutionEngine/AsyncRuntime.cpp
63

Should we guard for LLVM_ENABLE_THREAD?

ezhulenev updated this revision to Diff 300219.Oct 23 2020, 4:12 AM

Use threads only with LLVM_ENABLE_THREAD

ezhulenev marked an inline comment as done.Oct 23 2020, 4:13 AM
mehdi_amini accepted this revision.Oct 23 2020, 10:40 AM
This revision is now accepted and ready to land.Oct 23 2020, 10:40 AM
This revision was automatically updated to reflect the committed changes.