Differential D89983

[mlir] Link with pthreads in AsyncRuntime
ClosedPublic
Actions

Authored by ezhulenev on Oct 22 2020, 1:36 PM.

Details

Reviewers

Commits

rGb16f6324db21: [mlir] Link with pthreads in AsyncRuntime

Summary

AsyncRuntime must be explicitly linked with LLVM pthreads

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	190 ms	windows > LLVM.DebugInfo/X86::convert-debugloc.ll Script: -- : 'RUN: at line 1'; c:\ws\w32-1\llvm-project\premerge-checks\build\bin\llc.exe -mtriple=x86_64-pc-windows-gnu -dwarf-version=4 -filetype=obj -O0 < C:\ws\w32-1\llvm-project\premerge-checks\llvm\test\DebugInfo\X86\convert-debugloc.ll \| c:\ws\w32-1\llvm-project\premerge-checks\build\bin\llvm-dwarfdump.exe - \| c:\ws\w32-1\llvm-project\premerge-checks\build\bin\filecheck.exe C:\ws\w32-1\llvm-project\premerge-checks\llvm\test\DebugInfo\X86\convert-debugloc.ll --check-prefix=NOCONV "--implicit-check-not={{DW_TAG\|NULL}}"

Event Timeline

ezhulenev created this revision.Oct 22 2020, 1:36 PM

Herald added a project: Restricted Project. · View Herald TranscriptOct 22 2020, 1:36 PM

Herald added subscribers: rdzhabarov, tatianashp, msifontes and 14 others. · View Herald Transcript

ezhulenev requested review of this revision.Oct 22 2020, 1:36 PM

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald TranscriptOct 22 2020, 1:36 PM

ezhulenev retitled this revision from Link with ptrheads to [mlir] Link with pthreads in AsyncRuntime.Oct 22 2020, 1:37 PM

ezhulenev edited the summary of this revision. (Show Details)

ezhulenev added a reviewer: mehdi_amini.

Harbormaster completed remote builds in B76086: Diff 300092.Oct 22 2020, 1:57 PM

mehdi_amini added inline comments.Oct 22 2020, 3:24 PM

mlir/lib/ExecutionEngine/AsyncRuntime.cpp
63	Should we guard for LLVM_ENABLE_THREAD?

Use threads only with LLVM_ENABLE_THREAD

ezhulenev marked an inline comment as done.Oct 23 2020, 4:13 AM

Fix typo

Harbormaster completed remote builds in B76155: Diff 300220.Oct 23 2020, 4:29 AM

Harbormaster completed remote builds in B76154: Diff 300219.Oct 23 2020, 4:44 AM

mehdi_amini accepted this revision.Oct 23 2020, 10:40 AM

This revision is now accepted and ready to land.Oct 23 2020, 10:40 AM

Closed by commit rGb16f6324db21: [mlir] Link with pthreads in AsyncRuntime (authored by ezhulenev). · Explain WhyOct 23 2020, 12:53 PM

This revision was automatically updated to reflect the committed changes.

ezhulenev added a commit: rGb16f6324db21: [mlir] Link with pthreads in AsyncRuntime.

Revision Contents
Changeset List

Path

Size

mlir/

lib/

ExecutionEngine/

AsyncRuntime.cpp

3 lines

1 line

Diff 300092

mlir/lib/ExecutionEngine/AsyncRuntime.cpp

Loading...

mlir/lib/ExecutionEngine/CMakeLists.txt

Loading...