This is an archive of the discontinued LLVM Phabricator instance.

[mlir]: Clarify docs for external OpTrait::FunctionLike ops

Authored by frej on Oct 21 2020, 3:55 AM.



The documentation claims that an op with the trait FunctionLike has a
single region containing the blocks that corresponding to the body of
the function. It then goes on to say that the absence of a region
corresponds to an external function when, in fact, this is represented
by a single empty region. This patch changes the wording in the
documentation to match the implementation.

Signed-off-by: Frej Drejhammar <>
Co-authored-by: Frej Drejhammar <>
Co-authored-by: Klas Segeljakt <>

Diff Detail

Event Timeline

frej created this revision.Oct 21 2020, 3:55 AM
frej requested review of this revision.Oct 21 2020, 3:55 AM
ftynse accepted this revision.Oct 21 2020, 4:23 AM
This revision is now accepted and ready to land.Oct 21 2020, 4:23 AM
frej added a comment.Oct 21 2020, 4:31 AM

@ftynse are you willing to do the commit as I don't have commit rights? I'd like the change to be attributed to "Frej Drejhammar <>" if possible.

This revision was automatically updated to reflect the committed changes.