Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

frej (Frej Drejhammar)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 22 2015, 10:10 PM (462 w, 5 d)

Recent Activity

Oct 21 2020

frej added a comment to D89868: [mlir]: Clarify docs for external OpTrait::FunctionLike ops.

@ftynse are you willing to do the commit as I don't have commit rights? I'd like the change to be attributed to "Frej Drejhammar <frej.drejhammar@gmail.com>" if possible.

Oct 21 2020, 4:31 AM · Restricted Project
frej requested review of D89868: [mlir]: Clarify docs for external OpTrait::FunctionLike ops.
Oct 21 2020, 3:55 AM · Restricted Project
frej abandoned D76231: Make ConstantOp::getAsmResultNames() handle signfull constants.

Superseded by D76493

Oct 21 2020, 3:46 AM · Restricted Project, Restricted Project

Mar 24 2020

frej added a comment to D76493: mlir: Fix attribute parser errors for ui64.

@rriddle : Thanks, are you willing to do the commit as I don't have commit rights? I'd like the change to be attributed to "Frej Drejhammar <frej.drejhammar@gmail.com>" if possible.

Mar 24 2020, 10:56 PM · Restricted Project
frej updated the diff for D76493: mlir: Fix attribute parser errors for ui64.

Incorporated River Riddle's review comments and improved the testing of out-of-range values.

Mar 24 2020, 7:29 AM · Restricted Project

Mar 23 2020

frej added a comment to D76493: mlir: Fix attribute parser errors for ui64.

Thanks for the review.

Mar 23 2020, 12:30 AM · Restricted Project

Mar 20 2020

frej created D76493: mlir: Fix attribute parser errors for ui64.
Mar 20 2020, 7:00 AM · Restricted Project

Mar 16 2020

frej updated the summary of D76231: Make ConstantOp::getAsmResultNames() handle signfull constants.
Mar 16 2020, 7:35 AM · Restricted Project, Restricted Project
frej updated the summary of D76231: Make ConstantOp::getAsmResultNames() handle signfull constants.
Mar 16 2020, 7:03 AM · Restricted Project, Restricted Project
frej created D76231: Make ConstantOp::getAsmResultNames() handle signfull constants.
Mar 16 2020, 7:03 AM · Restricted Project, Restricted Project

Aug 17 2017

frej updated the diff for D36671: debuginfo: Improve line info when translating a CaseBlock to SDNodes.

Updated according to review comments. I had to add a CHECK: successors: after CHECK: bb.4.entry: in order to not crash on the successor info.

Aug 17 2017, 1:39 AM
frej added a comment to D36671: debuginfo: Improve line info when translating a CaseBlock to SDNodes.

Thanks, that's a smart way of doing it, although I had to insert a CHECK: successors: after CHECK: bb.4.entry: for it to not fail on the successor info.

Aug 17 2017, 1:39 AM

Aug 15 2017

frej added inline comments to D36671: debuginfo: Improve line info when translating a CaseBlock to SDNodes.
Aug 15 2017, 11:39 PM
frej added inline comments to D36671: debuginfo: Improve line info when translating a CaseBlock to SDNodes.
Aug 15 2017, 6:25 AM

Aug 14 2017

frej created D36671: debuginfo: Improve line info when translating a CaseBlock to SDNodes.
Aug 14 2017, 5:04 AM

Jun 7 2017

frej added a comment to D32745: Correct debug info bit offset calculation for big-endian targets.

Ping, I don't have have commit permissions, so I am at the mercy of others for getting this fix committed...

Jun 7 2017, 1:35 AM

May 3 2017

frej updated the diff for D32745: Correct debug info bit offset calculation for big-endian targets.

Removed 'REQUIRES'-line.

May 3 2017, 10:52 PM

May 2 2017

frej added a comment to D32745: Correct debug info bit offset calculation for big-endian targets.
In D32745#744280, @rnk wrote:

The REQUIRES tag is unnecessary. Clang can emit IR for any target without a registered backed.

May 2 2017, 11:38 PM
frej updated the diff for D32745: Correct debug info bit offset calculation for big-endian targets.

Added missing "REQUIRES: mips-registered-target".

May 2 2017, 10:37 PM
frej created D32745: Correct debug info bit offset calculation for big-endian targets.
May 2 2017, 6:08 AM

Feb 23 2017

frej added inline comments to D29671: [DebugInfo] Add address space when creating DIDerivedTypes.
Feb 23 2017, 1:29 AM

Feb 15 2017

frej added inline comments to D29673: [DebugInfo] Append extended dereferencing mechanism to variables' DIExpression for targets that support more than one address space.
Feb 15 2017, 4:43 AM

Feb 14 2017

frej added inline comments to D29671: [DebugInfo] Add address space when creating DIDerivedTypes.
Feb 14 2017, 5:25 AM
frej added inline comments to D29673: [DebugInfo] Append extended dereferencing mechanism to variables' DIExpression for targets that support more than one address space.
Feb 14 2017, 5:25 AM

Apr 13 2015

frej updated subscribers of D8961: [PATCH 8/8] Document the explictcc calling convention.
Apr 13 2015, 10:24 AM
frej updated subscribers of D8959: [PATCH 6/8] Implement noclobber function attribute.
Apr 13 2015, 10:23 AM
frej added a reviewer for D8960: [PATCH 7/8] Implement the noclobber function attribute for X86: nadav.
Apr 13 2015, 10:23 AM
frej added a reviewer for D8957: [PATCH 5/8] Implement llvm.experimental.retwr for X86: nadav.
Apr 13 2015, 10:22 AM
frej added a reviewer for D8956: [PATCH 4/8] Introduce the llvm.experimental.retwr intrinsic: resistor.
Apr 13 2015, 10:21 AM
frej added a reviewer for D8955: [PATCH 3/8] Implement the 'explicitcc' calling convention for X86: nadav.
Apr 13 2015, 10:20 AM
frej added reviewers for D8954: [PATCH 2/8] Introduce a 'hwreg' parameter attribute: joe.abbey, resistor.
Apr 13 2015, 10:19 AM
frej updated subscribers of D8953: [PATCH 1/8] Add new calling convention 'explicitcc'.
Apr 13 2015, 10:17 AM

Apr 10 2015

frej retitled D8957: [PATCH 5/8] Implement llvm.experimental.retwr for X86 from Implement llvm.experimental.retwr for X86 to [PATCH 5/8] Implement llvm.experimental.retwr for X86.
Apr 10 2015, 12:52 AM
frej retitled D8961: [PATCH 8/8] Document the explictcc calling convention from to [PATCH 8/8] Document the explictcc calling convention.
Apr 10 2015, 12:51 AM
frej retitled D8960: [PATCH 7/8] Implement the noclobber function attribute for X86 from to [PATCH 7/8] Implement the noclobber function attribute for X86.
Apr 10 2015, 12:49 AM
frej retitled D8959: [PATCH 6/8] Implement noclobber function attribute from to [PATCH 6/8] Implement noclobber function attribute.
Apr 10 2015, 12:48 AM
frej retitled D8957: [PATCH 5/8] Implement llvm.experimental.retwr for X86 from to Implement llvm.experimental.retwr for X86.
Apr 10 2015, 12:37 AM
frej retitled D8956: [PATCH 4/8] Introduce the llvm.experimental.retwr intrinsic from to [PATCH 4/8] Introduce the llvm.experimental.retwr intrinsic.
Apr 10 2015, 12:35 AM
frej retitled D8955: [PATCH 3/8] Implement the 'explicitcc' calling convention for X86 from to [PATCH 3/8] Implement the 'explicitcc' calling convention for X86.
Apr 10 2015, 12:34 AM
frej retitled D8954: [PATCH 2/8] Introduce a 'hwreg' parameter attribute from to [PATCH 2/8] Introduce a 'hwreg' parameter attribute.
Apr 10 2015, 12:31 AM
frej retitled D8953: [PATCH 1/8] Add new calling convention 'explicitcc' from to [PATCH 1/8] Add new calling convention 'explicitcc'.
Apr 10 2015, 12:29 AM