This is an archive of the discontinued LLVM Phabricator instance.

Differential D89760

Add llvm_unreachable to avoid MSVC warning
ClosedPublic

Authored by GMNGeoffrey on Oct 19 2020, 7:20 PM.

Details

Reviewers
rriddle
mehdi_amini
Commits
rGad0b2d9d46a3: Add llvm_unreachable to avoid MSVC warning
Summary

Without this I get a warning about not all paths returning.

Diff Detail

Event Timeline

GMNGeoffrey created this revision.Oct 19 2020, 7:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 19 2020, 7:20 PM
Herald added subscribers: rdzhabarov, tatianashp, msifontes and 13 others. · View Herald Transcript
GMNGeoffrey requested review of this revision.Oct 19 2020, 7:20 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald TranscriptOct 19 2020, 7:20 PM
GMNGeoffrey added a reviewer: rriddle.Oct 19 2020, 7:21 PM
Harbormaster completed remote builds in B75640: Diff 299245.Oct 19 2020, 7:41 PM
mehdi_amini accepted this revision.Oct 19 2020, 7:55 PM
mehdi_amini added inline comments.
mlir/lib/Dialect/StandardOps/IR/Ops.cpp
3006

Maybe "unexpected subview verification result" ?

This revision is now accepted and ready to land.Oct 19 2020, 7:55 PM
GMNGeoffrey updated this revision to Diff 299249.Oct 19 2020, 8:11 PM
  • Improve error message
Harbormaster completed remote builds in B75641: Diff 299249.Oct 19 2020, 8:29 PM
Closed by commit rGad0b2d9d46a3: Add llvm_unreachable to avoid MSVC warning (authored by GMNGeoffrey). · Explain WhyOct 19 2020, 8:29 PM
This revision was automatically updated to reflect the committed changes.
GMNGeoffrey added a commit: rGad0b2d9d46a3: Add llvm_unreachable to avoid MSVC warning.

Revision Contents

PathSize
mlir/
lib/
Dialect/
StandardOps/
IR/
1 line

Diff 299250

mlir/lib/Dialect/StandardOps/IR/Ops.cpp

Show First 20 Lines • Show All 2,997 Lines • ▼ Show 20 Lines return op.emitError("expected result element type to be ")
<< memrefType.getElementType(); << memrefType.getElementType();
case SubViewVerificationResult::MemSpaceMismatch: case SubViewVerificationResult::MemSpaceMismatch:
return op.emitError("expected result and source memory spaces to match."); return op.emitError("expected result and source memory spaces to match.");
case SubViewVerificationResult::AffineMapMismatch: case SubViewVerificationResult::AffineMapMismatch:
return op.emitError("expected result type to be ") return op.emitError("expected result type to be ")
<< expectedType << expectedType
<< " or a rank-reduced version. (mismatch of result affine map)"; << " or a rank-reduced version. (mismatch of result affine map)";
} }
llvm_unreachable("unexpected subview verification result");
mehdi_aminiUnsubmitted
Not Done
ReplyInline Actions

Maybe "unexpected subview verification result" ?

mehdi_amini: Maybe "unexpected subview verification result" ?
} }
template <typename OpType> template <typename OpType>
static LogicalResult verifyOpWithOffsetSizesAndStrides(OpType op) { static LogicalResult verifyOpWithOffsetSizesAndStrides(OpType op) {
// Verify static attributes offsets/sizes/strides. // Verify static attributes offsets/sizes/strides.
if (failed(verifyOpWithOffsetSizesAndStridesPart( if (failed(verifyOpWithOffsetSizesAndStridesPart(
op, "offset", op.getStaticOffsetsAttrName(), op.static_offsets(), op, "offset", op.getStaticOffsetsAttrName(), op.static_offsets(),
ShapedType::isDynamicStrideOrOffset, op.offsets()))) ShapedType::isDynamicStrideOrOffset, op.offsets())))
▲ Show 20 Lines • Show All 1,042 Lines • Show Last 20 Lines