This is an archive of the discontinued LLVM Phabricator instance.

Differential D89658

[MLIR][SPIRVToLLVM] Updated documentation for composite ops
ClosedPublic

Authored by georgemitenkov on Oct 18 2020, 3:00 PM.

Details

Reviewers
antiagainst
mravishankar
ftynse
Commits
rG87a232103294: [MLIR][SPIRVToLLVM] Updated documentation for composite ops
Summary

Added a section on composite ops (spv.CompositeExtract and
spv.CompositeInsert) conversion.

Diff Detail

Event Timeline

georgemitenkov created this revision.Oct 18 2020, 3:00 PM
Herald added a reviewer: ftynse. · View Herald TranscriptOct 18 2020, 3:00 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: rdzhabarov, tatianashp, ThomasRaoux and 14 others. · View Herald Transcript
georgemitenkov requested review of this revision.Oct 18 2020, 3:00 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald TranscriptOct 18 2020, 3:00 PM
Harbormaster completed remote builds in B75469: Diff 298903.Oct 18 2020, 3:15 PM
georgemitenkov retitled this revision from [MLIR][SPIRV] Updated documentation for composite ops to [MLIR][SPIRVToLLVM] Updated documentation for composite ops.Oct 18 2020, 11:02 PM
antiagainst accepted this revision.Oct 19 2020, 6:53 AM
This revision is now accepted and ready to land.Oct 19 2020, 6:53 AM
Closed by commit rG87a232103294: [MLIR][SPIRVToLLVM] Updated documentation for composite ops (authored by georgemitenkov). · Explain WhyOct 19 2020, 7:44 AM
This revision was automatically updated to reflect the committed changes.
georgemitenkov added a commit: rG87a232103294: [MLIR][SPIRVToLLVM] Updated documentation for composite ops.

Revision Contents

PathSize
mlir/
docs/
16 lines

Diff 299051

mlir/docs/SPIRVToLLVMDialectConversion.md

Show First 20 Lines • Show All 346 Lines • ▼ Show 20 Lines
`spv.SGreaterThanEqual` | `llvm.icmp "sge"` `spv.SGreaterThanEqual` | `llvm.icmp "sge"`
`spv.SLessThan` | `llvm.icmp "slt"` `spv.SLessThan` | `llvm.icmp "slt"`
`spv.SLessThanEqual` | `llvm.icmp "sle"` `spv.SLessThanEqual` | `llvm.icmp "sle"`
`spv.UGreaterThan` | `llvm.icmp "ugt"` `spv.UGreaterThan` | `llvm.icmp "ugt"`
`spv.UGreaterThanEqual` | `llvm.icmp "uge"` `spv.UGreaterThanEqual` | `llvm.icmp "uge"`
`spv.ULessThan` | `llvm.icmp "ult"` `spv.ULessThan` | `llvm.icmp "ult"`
`spv.ULessThanEqual` | `llvm.icmp "ule"` `spv.ULessThanEqual` | `llvm.icmp "ule"`
### Composite ops
Currently, conversion supports rewrite patterns for `spv.CompositeExtract` and
`spv.CompositeInsert`. We distinguish two cases for these operations: when the
composite object is a vector, and when the composite object is of a non-vector
type (*i.e.* struct, array or runtime array).
Composite type | SPIR-V Dialect op | LLVM Dialect op
:-------------: | :--------------------: | :--------------------:
vector | `spv.CompositeExtract` | `llvm.extractelement`
vector | `spv.CompositeInsert` | `llvm.insertelement`
non-vector | `spv.CompositeExtract` | `llvm.extractvalue`
non-vector | `spv.CompositeInsert` | `llvm.insertvalue`
### `spv.EntryPoint` and `spv.ExecutionMode` ### `spv.EntryPoint` and `spv.ExecutionMode`
**Note: these conversions are likely to be changed in the future** **Note: these conversions are likely to be changed in the future**
First of all, it is important to note that there is no direct representation of First of all, it is important to note that there is no direct representation of
entry points in LLVM. At the moment, we choose to **remove these ops**, assuming entry points in LLVM. At the moment, we choose to **remove these ops**, assuming
that the module generated from SPIR-V has no other internal functions (This that the module generated from SPIR-V has no other internal functions (This
assumption is actually made in [`mlir-spirv-cpu-runner`](#`mlir-spirv-cpu-runner`)). assumption is actually made in [`mlir-spirv-cpu-runner`](#`mlir-spirv-cpu-runner`)).
▲ Show 20 Lines • Show All 229 Lines • ▼ Show 20 Lines
* All Atomic ops * All Atomic ops
* All matrix ops * All matrix ops
* All GroupNonUniform ops * All GroupNonUniform ops
As well as: As well as:
* spv.CompositeConstruct * spv.CompositeConstruct
* spv.CompositeExtract
* spv.CompositeInsert
* spv.ControlBarrier * spv.ControlBarrier
* spv.CopyMemory * spv.CopyMemory
* spv.FMod * spv.FMod
* spv.GLSL.SAbs * spv.GLSL.SAbs
* spv.GLSL.SSign * spv.GLSL.SSign
* spv.GLSL.FSign * spv.GLSL.FSign
* spv.MemoryBarrier * spv.MemoryBarrier
* spv._reference_of * spv._reference_of
▲ Show 20 Lines • Show All 177 Lines • Show Last 20 Lines