This is an archive of the discontinued LLVM Phabricator instance.

Differential D89568

[AMDGPU] Drop array size in AMDGCNGPUs and R600GPUs
ClosedPublic

Authored by rampitec on Oct 16 2020, 10:45 AM.

Details

Reviewers
foad
kzhuravl
arsenm
Commits
rG874524ab88a9: [AMDGPU] Drop array size in AMDGCNGPUs and R600GPUs

Diff Detail

Event Timeline

rampitec created this revision.Oct 16 2020, 10:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 16 2020, 10:45 AM
Herald added subscribers: hiraditya, t-tye, tpr and 2 others. · View Herald Transcript
rampitec requested review of this revision.Oct 16 2020, 10:45 AM
Herald added a subscriber: wdng. · View Herald TranscriptOct 16 2020, 10:45 AM
rampitec mentioned this in D89487: [AMDGPU] gfx1032 target.Oct 16 2020, 10:45 AM
arsenm added a subscriber: arsenm.Oct 16 2020, 11:03 AM
arsenm added inline comments.
llvm/lib/Support/TargetParser.cpp
58

There's another up here

rampitec added inline comments.Oct 16 2020, 11:11 AM
llvm/lib/Support/TargetParser.cpp
58

We do not change that one all the time, and unlikely will.

arsenm added inline comments.Oct 16 2020, 11:39 AM
llvm/lib/Support/TargetParser.cpp
58

There's no reason to keep it though

rampitec updated this revision to Diff 298713.Oct 16 2020, 12:12 PM
rampitec marked 2 inline comments as done.
rampitec retitled this revision from [AMDGPU] Drop array size in AMDGCNGPUs to [AMDGPU] Drop array size in AMDGCNGPUs and R600GPUs.
arsenm accepted this revision.Oct 16 2020, 12:13 PM
This revision is now accepted and ready to land.Oct 16 2020, 12:13 PM
Closed by commit rG874524ab88a9: [AMDGPU] Drop array size in AMDGCNGPUs and R600GPUs (authored by rampitec). · Explain WhyOct 16 2020, 12:37 PM
This revision was automatically updated to reflect the committed changes.
rampitec added a commit: rG874524ab88a9: [AMDGPU] Drop array size in AMDGCNGPUs and R600GPUs.

Revision Contents

PathSize
llvm/
lib/
Support/
4 lines

Diff 298725

llvm/lib/Support/TargetParser.cpp

Show All 24 Lines
struct GPUInfo { struct GPUInfo {
StringLiteral Name; StringLiteral Name;
StringLiteral CanonicalName; StringLiteral CanonicalName;
AMDGPU::GPUKind Kind; AMDGPU::GPUKind Kind;
unsigned Features; unsigned Features;
}; };
constexpr GPUInfo R600GPUs[26] = { constexpr GPUInfo R600GPUs[] = {
// Name Canonical Kind Features // Name Canonical Kind Features
// Name // Name
{{"r600"}, {"r600"}, GK_R600, FEATURE_NONE }, {{"r600"}, {"r600"}, GK_R600, FEATURE_NONE },
{{"rv630"}, {"r600"}, GK_R600, FEATURE_NONE }, {{"rv630"}, {"r600"}, GK_R600, FEATURE_NONE },
{{"rv635"}, {"r600"}, GK_R600, FEATURE_NONE }, {{"rv635"}, {"r600"}, GK_R600, FEATURE_NONE },
{{"r630"}, {"r630"}, GK_R630, FEATURE_NONE }, {{"r630"}, {"r630"}, GK_R630, FEATURE_NONE },
{{"rs780"}, {"rs880"}, GK_RS880, FEATURE_NONE }, {{"rs780"}, {"rs880"}, GK_RS880, FEATURE_NONE },
{{"rs880"}, {"rs880"}, GK_RS880, FEATURE_NONE }, {{"rs880"}, {"rs880"}, GK_RS880, FEATURE_NONE },
{{"rv610"}, {"rs880"}, GK_RS880, FEATURE_NONE }, {{"rv610"}, {"rs880"}, GK_RS880, FEATURE_NONE },
{{"rv620"}, {"rs880"}, GK_RS880, FEATURE_NONE }, {{"rv620"}, {"rs880"}, GK_RS880, FEATURE_NONE },
{{"rv670"}, {"rv670"}, GK_RV670, FEATURE_NONE }, {{"rv670"}, {"rv670"}, GK_RV670, FEATURE_NONE },
{{"rv710"}, {"rv710"}, GK_RV710, FEATURE_NONE }, {{"rv710"}, {"rv710"}, GK_RV710, FEATURE_NONE },
{{"rv730"}, {"rv730"}, GK_RV730, FEATURE_NONE }, {{"rv730"}, {"rv730"}, GK_RV730, FEATURE_NONE },
{{"rv740"}, {"rv770"}, GK_RV770, FEATURE_NONE }, {{"rv740"}, {"rv770"}, GK_RV770, FEATURE_NONE },
{{"rv770"}, {"rv770"}, GK_RV770, FEATURE_NONE }, {{"rv770"}, {"rv770"}, GK_RV770, FEATURE_NONE },
{{"cedar"}, {"cedar"}, GK_CEDAR, FEATURE_NONE }, {{"cedar"}, {"cedar"}, GK_CEDAR, FEATURE_NONE },
{{"palm"}, {"cedar"}, GK_CEDAR, FEATURE_NONE }, {{"palm"}, {"cedar"}, GK_CEDAR, FEATURE_NONE },
{{"cypress"}, {"cypress"}, GK_CYPRESS, FEATURE_FMA }, {{"cypress"}, {"cypress"}, GK_CYPRESS, FEATURE_FMA },
{{"hemlock"}, {"cypress"}, GK_CYPRESS, FEATURE_FMA }, {{"hemlock"}, {"cypress"}, GK_CYPRESS, FEATURE_FMA },
{{"juniper"}, {"juniper"}, GK_JUNIPER, FEATURE_NONE }, {{"juniper"}, {"juniper"}, GK_JUNIPER, FEATURE_NONE },
{{"redwood"}, {"redwood"}, GK_REDWOOD, FEATURE_NONE }, {{"redwood"}, {"redwood"}, GK_REDWOOD, FEATURE_NONE },
{{"sumo"}, {"sumo"}, GK_SUMO, FEATURE_NONE }, {{"sumo"}, {"sumo"}, GK_SUMO, FEATURE_NONE },
{{"sumo2"}, {"sumo"}, GK_SUMO, FEATURE_NONE }, {{"sumo2"}, {"sumo"}, GK_SUMO, FEATURE_NONE },
{{"barts"}, {"barts"}, GK_BARTS, FEATURE_NONE }, {{"barts"}, {"barts"}, GK_BARTS, FEATURE_NONE },
{{"caicos"}, {"caicos"}, GK_CAICOS, FEATURE_NONE }, {{"caicos"}, {"caicos"}, GK_CAICOS, FEATURE_NONE },
arsenmUnsubmitted
Done
ReplyInline Actions

There's another up here

arsenm: There's another up here
rampitecAuthorUnsubmitted
Done
ReplyInline Actions

We do not change that one all the time, and unlikely will.

rampitec: We do not change that one all the time, and unlikely will.
arsenmUnsubmitted
Done
ReplyInline Actions

There's no reason to keep it though

arsenm: There's no reason to keep it though
{{"aruba"}, {"cayman"}, GK_CAYMAN, FEATURE_FMA }, {{"aruba"}, {"cayman"}, GK_CAYMAN, FEATURE_FMA },
{{"cayman"}, {"cayman"}, GK_CAYMAN, FEATURE_FMA }, {{"cayman"}, {"cayman"}, GK_CAYMAN, FEATURE_FMA },
{{"turks"}, {"turks"}, GK_TURKS, FEATURE_NONE } {{"turks"}, {"turks"}, GK_TURKS, FEATURE_NONE }
}; };
// This table should be sorted by the value of GPUKind // This table should be sorted by the value of GPUKind
// Don't bother listing the implicitly true features // Don't bother listing the implicitly true features
constexpr GPUInfo AMDGCNGPUs[44] = { constexpr GPUInfo AMDGCNGPUs[] = {
// Name Canonical Kind Features // Name Canonical Kind Features
// Name // Name
{{"gfx600"}, {"gfx600"}, GK_GFX600, FEATURE_FAST_FMA_F32}, {{"gfx600"}, {"gfx600"}, GK_GFX600, FEATURE_FAST_FMA_F32},
{{"tahiti"}, {"gfx600"}, GK_GFX600, FEATURE_FAST_FMA_F32}, {{"tahiti"}, {"gfx600"}, GK_GFX600, FEATURE_FAST_FMA_F32},
{{"gfx601"}, {"gfx601"}, GK_GFX601, FEATURE_NONE}, {{"gfx601"}, {"gfx601"}, GK_GFX601, FEATURE_NONE},
{{"pitcairn"}, {"gfx601"}, GK_GFX601, FEATURE_NONE}, {{"pitcairn"}, {"gfx601"}, GK_GFX601, FEATURE_NONE},
{{"verde"}, {"gfx601"}, GK_GFX601, FEATURE_NONE}, {{"verde"}, {"gfx601"}, GK_GFX601, FEATURE_NONE},
{{"gfx602"}, {"gfx602"}, GK_GFX602, FEATURE_NONE}, {{"gfx602"}, {"gfx602"}, GK_GFX602, FEATURE_NONE},
▲ Show 20 Lines • Show All 249 Lines • Show Last 20 Lines