This is an archive of the discontinued LLVM Phabricator instance.

Differential D89516

[MLIR] Fix gcc5 in D89161
ClosedPublic

Authored by rsuderman on Oct 15 2020, 5:02 PM.

Details

Reviewers
antiagainst
GMNGeoffrey
Commits
rGad1fe3963f30: [MLIR] Fix gcc5 in D89161
Summary

Missing .str() makes gcc5 unable to infer the template to use.

Diff Detail

Event Timeline

rsuderman created this revision.Oct 15 2020, 5:02 PM
Herald added a reviewer: antiagainst. · View Herald TranscriptOct 15 2020, 5:02 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: rdzhabarov, tatianashp, msifontes and 13 others. · View Herald Transcript
rsuderman requested review of this revision.Oct 15 2020, 5:02 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald TranscriptOct 15 2020, 5:02 PM
GMNGeoffrey accepted this revision.Oct 15 2020, 5:02 PM
GMNGeoffrey added a subscriber: GMNGeoffrey.

Thanks!

This revision is now accepted and ready to land.Oct 15 2020, 5:02 PM
This revision was landed with ongoing or failed builds.Oct 15 2020, 5:03 PM
Closed by commit rGad1fe3963f30: [MLIR] Fix gcc5 in D89161 (authored by rsuderman). · Explain Why
This revision was automatically updated to reflect the committed changes.
rsuderman added a commit: rGad1fe3963f30: [MLIR] Fix gcc5 in D89161.
Harbormaster completed remote builds in B75250: Diff 298521.Oct 15 2020, 5:31 PM

Revision Contents

PathSize
mlir/
lib/
TableGen/
2 lines

Diff 298522

mlir/lib/TableGen/Pattern.cpp

Show First 20 Lines • Show All 393 Lines • ▼ Show 20 Lines
} }
bool SymbolInfoMap::bindValue(StringRef symbol) { bool SymbolInfoMap::bindValue(StringRef symbol) {
auto inserted = symbolInfoMap.emplace(symbol.str(), SymbolInfo::getValue()); auto inserted = symbolInfoMap.emplace(symbol.str(), SymbolInfo::getValue());
return symbolInfoMap.count(inserted->first) == 1; return symbolInfoMap.count(inserted->first) == 1;
} }
bool SymbolInfoMap::bindAttr(StringRef symbol) { bool SymbolInfoMap::bindAttr(StringRef symbol) {
auto inserted = symbolInfoMap.emplace(symbol, SymbolInfo::getAttr()); auto inserted = symbolInfoMap.emplace(symbol.str(), SymbolInfo::getAttr());
return symbolInfoMap.count(inserted->first) == 1; return symbolInfoMap.count(inserted->first) == 1;
} }
bool SymbolInfoMap::contains(StringRef symbol) const { bool SymbolInfoMap::contains(StringRef symbol) const {
return find(symbol) != symbolInfoMap.end(); return find(symbol) != symbolInfoMap.end();
} }
SymbolInfoMap::const_iterator SymbolInfoMap::find(StringRef key) const { SymbolInfoMap::const_iterator SymbolInfoMap::find(StringRef key) const {
▲ Show 20 Lines • Show All 321 Lines • Show Last 20 Lines