[flang] Fix build with BUILD_SHARED_LIBS=ON

[serge-sans-paille]

Summary

Fix component dependencies specification

Tested with the following cmake flags:

cmake ../llvm -DCMAKE_BUILD_TYPE=Release -DLLVM_TARGETS_TO_BUILD=X86 -DLLVM_ENABLE_PROJECTS=flang\;mlir\;clang -DBUILD_SHARED_LIBS=OFF -DFLANG_BUILD_NEW_DRIVER=OFF
cmake ../llvm -DCMAKE_BUILD_TYPE=Release -DLLVM_TARGETS_TO_BUILD=X86 -DLLVM_ENABLE_PROJECTS=flang\;mlir\;clang -DBUILD_SHARED_LIBS=ON -DFLANG_BUILD_NEW_DRIVER=OFF
cmake ../llvm -DCMAKE_BUILD_TYPE=Release -DLLVM_TARGETS_TO_BUILD=X86 -DLLVM_ENABLE_PROJECTS=flang\;mlir\;clang -DBUILD_SHARED_LIBS=OFF -DFLANG_BUILD_NEW_DRIVER=ON
cmake ../llvm -DCMAKE_BUILD_TYPE=Release -DLLVM_TARGETS_TO_BUILD=X86 -DLLVM_ENABLE_PROJECTS=flang\;mlir\;clang -DBUILD_SHARED_LIBS=ON -DFLANG_BUILD_NEW_DRIVER=ON

[serge-sans-paille]

Still have an issue with -DFLANG_BUILD_NEW_DRIVER=ON -DLLVM_LINK_LLVM_DYLIB=ON

[awarzynski]

Thank you for fixing this so quickly @serge-sans-paille , that's much appreciated!

Btw, I tested the following:

cmake -DLLVM_TARGETS_TO_BUILD=AArch64 -DFLANG_ENABLE_WERROR=ON -DLLVM_ENABLE_ASSERTIONS=ON -DFLANG_BUILD_NEW_DRIVER=ON -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PROJECTS="llvm;clang;mlir;flang" -DBUILD_SHARED_LIBS=On

[serge-sans-paille]

Now fixed with

cmake ../llvm -DCMAKE_BUILD_TYPE=Release -DLLVM_TARGETS_TO_BUILD=X86 -DLLVM_ENABLE_PROJECTS=flang\;mlir\;clang -DFLANG_BUILD_NEW_DRIVER=ON -DLLVM_LINK_LLVM_DYLIB=OFF -DBUILD_SHARED_LIBS=OFF
cmake ../llvm -DCMAKE_BUILD_TYPE=Release -DLLVM_TARGETS_TO_BUILD=X86 -DLLVM_ENABLE_PROJECTS=flang\;mlir\;clang -DFLANG_BUILD_NEW_DRIVER=ON -DLLVM_LINK_LLVM_DYLIB=ON

[awarzynski]

Thanks for testing so extensively! LGTM!

flang/lib/Evaluate/CMakeLists.txt

add_flang_library(FortranEvaluate
   variable.cpp
 
   LINK_LIBS
   FortranCommon
   FortranDecimal
   FortranParser
   ${LIBPGMATH}
 
+  LINK_COMPONENTS
+  Support
+
   DEPENDS
   acc_gen
   omp_gen
 )
 

flang/unittests/Evaluate/CMakeLists.txt

 set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR})
 add_library(FortranEvaluateTesting
   testing.cpp
   fp-testing.cpp
 )
-    if (LLVM_LINK_LLVM_DYLIB)
-      set(llvm_libs LLVM)
-    else()
-      llvm_map_components_to_libnames(llvm_libs Support)
-    endif()
-    target_link_libraries(FortranEvaluateTesting
-      ${llvm_libs})
 
 add_flang_nongtest_unittest(leading-zero-bit-count
   FortranEvaluateTesting
 )
 
 add_flang_nongtest_unittest(bit-population-count
   FortranEvaluateTesting
 )

flang/unittests/Frontend/CMakeLists.txt

 add_flang_unittest(FlangFrontendTests
   CompilerInstanceTest.cpp
 )
 
 target_link_libraries(FlangFrontendTests
   PRIVATE
-  LLVMSupport
   clangBasic
   clangFrontend
   flangFrontend
   flangFrontendTool)

flang/unittests/Runtime/CMakeLists.txt

 set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR})
 
 # RuntimeTesting needs exceptions enabled
 set(LLVM_REQUIRES_EH ON)
 set(LLVM_REQUIRES_RTTI ON)
 add_library(RuntimeTesting
   testing.cpp
 )
 llvm_update_compile_flags(RuntimeTesting)
 
+if (LLVM_LINK_LLVM_DYLIB)
+  set(llvm_libs LLVM)
+else()
+  llvm_map_components_to_libnames(llvm_libs Support)
+endif()
 target_link_libraries(RuntimeTesting
   FortranRuntime
+  ${llvm_libs}
 )
 
 add_flang_nongtest_unittest(format
   RuntimeTesting
   FortranRuntime
 )
 
 add_flang_nongtest_unittest(hello