Page MenuHomePhabricator

[mlir][SPIRV] Adding an attribute to capture configuration for cooperative matrix operations.
ClosedPublic

Authored by mravishankar on Oct 13 2020, 9:58 PM.

Details

Summary

Each hardware that supports SPV_C_CooperativeMatrixNV has a list of
configurations that are supported natively. Add an attribute to
specify the configurations supported to the spv.target_env.

Diff Detail

Event Timeline

mravishankar created this revision.Oct 13 2020, 9:58 PM
mravishankar requested review of this revision.Oct 13 2020, 9:58 PM
This revision is now accepted and ready to land.Oct 13 2020, 10:31 PM
antiagainst accepted this revision.Oct 14 2020, 3:57 PM

Awesome, thanks!

mlir/include/mlir/Dialect/SPIRV/TargetAndABI.td
39

super nit: s/Cooperative/cooperative/

41

We can just use the man page link here: https://www.khronos.org/registry/vulkan/specs/1.2-extensions/man/html/VkCooperativeMatrixPropertiesNV.html.

It's more concentrated and simpler to load in browser. :)

Make the StructAttrField names snake_case.

mravishankar marked 2 inline comments as done.Oct 14 2020, 10:32 PM
This revision was landed with ongoing or failed builds.Oct 14 2020, 10:46 PM
This revision was automatically updated to reflect the committed changes.