This is an archive of the discontinued LLVM Phabricator instance.

Differential D89361

[X86][NFC] Fix RUN line bug in the testcase
ClosedPublic

Authored by LiuChen3 on Oct 13 2020, 7:27 PM.

Details

Reviewers
bruno
craig.topper
dyung
Commits
rGbd05afcb3f40: [X86][NFC] Fix RUN line bug in the testcase
Summary

Testcase added in D78699 doesn't work because the wrong RUN line in the testcase.

Diff Detail

Event Timeline

LiuChen3 created this revision.Oct 13 2020, 7:27 PM
Herald added subscribers: pengfei, dexonsmith. · View Herald TranscriptOct 13 2020, 7:27 PM
LiuChen3 requested review of this revision.Oct 13 2020, 7:27 PM
bruno accepted this revision.Oct 13 2020, 9:28 PM

LGTM

This revision is now accepted and ready to land.Oct 13 2020, 9:28 PM
dyung accepted this revision.Oct 13 2020, 9:34 PM

LGTM as well. I also tested it and it fails before your change, and passes with your change.

Closed by commit rGbd05afcb3f40: [X86][NFC] Fix RUN line bug in the testcase (authored by LiuChen3). · Explain WhyOct 13 2020, 9:41 PM
This revision was automatically updated to reflect the committed changes.
LiuChen3 added a commit: rGbd05afcb3f40: [X86][NFC] Fix RUN line bug in the testcase.
Herald added a project: Restricted Project. · View Herald TranscriptOct 13 2020, 9:41 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
LiuChen3 added a comment.Oct 13 2020, 9:42 PM

Thanks for all of your help!

Revision Contents

PathSize
clang/
test/
CodeGen/
X86/
10 lines

Diff 298016

clang/test/CodeGen/X86/avx-union.c

// RUN: %clang_cc1 -w -ffreestanding -triple x86_64-linux-gnu -target-feature +avx -emit-llvm -o %t %s || FileCheck < %t %s --check-prefix=CHECK, AVX // RUN: %clang_cc1 -w -ffreestanding -triple x86_64-linux-gnu -target-feature +avx -emit-llvm -o - %s | FileCheck %s --check-prefix=CHECK --check-prefix=AVX
// RUN: %clang_cc1 -w -ffreestanding -triple x86_64-linux-gnu -target-feature +avx512f -emit-llvm -o %t %s || FileCheck < %t %s --check-prefix=CHECK, AVX512 // RUN: %clang_cc1 -w -ffreestanding -triple x86_64-linux-gnu -target-feature +avx512f -emit-llvm -o - %s | FileCheck %s --check-prefix=CHECK --check-prefix=AVX512
// This tests verifies that a union parameter should pass by a vector regitster whose first eightbyte is SSE and the other eightbytes are SSEUP. // This tests verifies that a union parameter should pass by a vector regitster whose first eightbyte is SSE and the other eightbytes are SSEUP.
typedef int __m256 __attribute__ ((__vector_size__ (32))); typedef int __m256 __attribute__ ((__vector_size__ (32)));
typedef int __m512 __attribute__ ((__vector_size__ (64))); typedef int __m512 __attribute__ ((__vector_size__ (64)));
union M256 { union M256 {
double d; double d;
__m256 m; __m256 m;
}; };
union M512 { union M512 {
double d; double d;
__m512 m; __m512 m;
}; };
extern void foo1(union M256 A); extern void foo1(union M256 A);
extern void foo2(union M512 A); extern void foo2(union M512 A);
union M256 m1; union M256 m1;
union M512 m2; union M512 m2;
// CHECK-LABEL: define dso_local void @test() // CHECK-LABEL: define void @test()
// CHECK: void @foo1(<4 x double> // CHECK: call void @foo1(<4 x double>
// AVX: call void @foo2(%union.M512* byval(%union.M512) align 64 // AVX: call void @foo2(%union.M512* byval(%union.M512) align 64
// AVX512: call void @foo2(<8 x double> // AVX512: call void @foo2(<8 x double>
void test() { void test() {
foo1(m1); foo1(m1);
foo2(m2); foo2(m2);
} }