[mlir] expand the legal floating-point types in the LLVM IR dialect type check

[schweitz]

Summary

This patch adds a couple missing LLVM IR dialect floating point types to the legality check.

[ftynse]

mlir/include/mlir/Dialect/LLVMIR/LLVMTypes.h

94–95

These methods don't seem used anywhere. I kept the methods above to minimize breakage, but MLIR clients should use isa consistently.

97–100

This can use variadic isa instead.

[schweitz]

mlir/include/mlir/Dialect/LLVMIR/LLVMTypes.h

94–95

That's fine with me. I just included these for the sake of consistency for the moment. We can drop the entire group of these at some point, I agree.

mlir/include/mlir/Dialect/LLVMIR/LLVMOpBase.td

And<[LLVM_Type.predicate,
                          "::mlir::LLVM::LLVMFunctionType>()">]>,
   "primitive LLVM type">;
 
 // Type constraint accepting any LLVM floating point type.
 def LLVM_AnyFloat : Type<
   CPred<"$_self.isa<::mlir::LLVM::LLVMBFloatType, "
                    "::mlir::LLVM::LLVMHalfType, "
                    "::mlir::LLVM::LLVMFloatType, "
-                   "::mlir::LLVM::LLVMDoubleType>()">,
+                   "::mlir::LLVM::LLVMDoubleType, "
+                   "::mlir::LLVM::LLVMFP128Type, "
+                   "::mlir::LLVM::LLVMX86FP80Type>()">,
   "floating point LLVM type">;
 
 // Type constraint accepting any LLVM pointer type.
 def LLVM_AnyPointer : Type<CPred<"$_self.isa<::mlir::LLVM::LLVMPointerType>()">,
                           "LLVM pointer type">;
 
 // Type constraint accepting LLVM pointer type with an additional constraint
 // on the element type.

mlir/include/mlir/Dialect/LLVMIR/LLVMTypes.h

 struct LLVMStructTypeStorage;
 struct LLVMTypeAndSizeStorage;
 } // namespace detail
 
 class LLVMBFloatType;
 class LLVMHalfType;
 class LLVMFloatType;
 class LLVMDoubleType;
+class LLVMFP128Type;
+class LLVMX86FP80Type;
 class LLVMIntegerType;
 
 //===----------------------------------------------------------------------===//
 // LLVMType.
 //===----------------------------------------------------------------------===//
 
 /// Base class for LLVM dialect types.
 ///
public:
   /// that don't have a size (such as void).
   llvm::TypeSize getPrimitiveSizeInBits();
 
   /// Floating-point type utilities.
   bool isBFloatTy() { return isa<LLVMBFloatType>(); }
   bool isHalfTy() { return isa<LLVMHalfType>(); }
   bool isFloatTy() { return isa<LLVMFloatType>(); }
   bool isDoubleTy() { return isa<LLVMDoubleType>(); }
+  bool isFP128Ty() { return isa<LLVMFP128Type>(); }
+  bool isX86_FP80Ty() { return isa<LLVMX86FP80Type>(); }
   bool isFloatingPointTy() {
     return isa<LLVMHalfType>() || isa<LLVMBFloatType>() ||
-           isa<LLVMFloatType>() || isa<LLVMDoubleType>();
+           isa<LLVMFloatType>() || isa<LLVMDoubleType>() ||
+           isa<LLVMFP128Type>() || isa<LLVMX86FP80Type>();
   }
 
   /// Array type utilities.
   LLVMType getArrayElementType();
   unsigned getArrayNumElements();
   bool isArrayTy();
 
   /// Integer type utilities.
   bool isIntegerTy() { return isa<LLVMIntegerType>(); }