Page MenuHomePhabricator

[mlir] expand the legal floating-point types in the LLVM IR dialect type check
ClosedPublic

Authored by schweitz on Oct 13 2020, 4:50 PM.

Details

Summary

This patch adds a couple missing LLVM IR dialect floating point types to the legality check.

Diff Detail

Event Timeline

schweitz created this revision.Oct 13 2020, 4:50 PM
schweitz requested review of this revision.Oct 13 2020, 4:50 PM
ftynse accepted this revision.Oct 14 2020, 1:05 AM
ftynse added inline comments.
mlir/include/mlir/Dialect/LLVMIR/LLVMTypes.h
94–95

These methods don't seem used anywhere. I kept the methods above to minimize breakage, but MLIR clients should use isa consistently.

97–100

This can use variadic isa instead.

This revision is now accepted and ready to land.Oct 14 2020, 1:05 AM
schweitz added inline comments.Oct 14 2020, 6:54 AM
mlir/include/mlir/Dialect/LLVMIR/LLVMTypes.h
94–95

That's fine with me. I just included these for the sake of consistency for the moment. We can drop the entire group of these at some point, I agree.

This revision was landed with ongoing or failed builds.Oct 14 2020, 6:56 AM
This revision was automatically updated to reflect the committed changes.