Page MenuHomePhabricator

[Attributor][NFC] Make `createShallowWrapper()` available outside of Attributor
ClosedPublic

Authored by sstefan1 on Oct 13 2020, 2:06 PM.

Details

Summary

D85703 will need to create shallow wrappers in order to track the spmd icv. We need to make it available.

Diff Detail

Event Timeline

sstefan1 created this revision.Oct 13 2020, 2:06 PM
Herald added a reviewer: homerdin. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
sstefan1 requested review of this revision.Oct 13 2020, 2:06 PM
jdoerfert added inline comments.Oct 13 2020, 2:11 PM
llvm/include/llvm/Transforms/IPO/Attributor.h
1596

No need to move the code in the header, right? Just move the declaration here.

sstefan1 added inline comments.Oct 13 2020, 2:20 PM
llvm/include/llvm/Transforms/IPO/Attributor.h
1596

Right...rushed this a bit, will update shortly.

sstefan1 updated this revision to Diff 297960.Oct 13 2020, 2:28 PM

Only move the declaration

This revision is now accepted and ready to land.Oct 13 2020, 9:06 PM
This revision was landed with ongoing or failed builds.Oct 14 2020, 1:10 AM
This revision was automatically updated to reflect the committed changes.