[Attributor][NFC] Make `createShallowWrapper()` available outside of Attributor
ClosedPublic
Actions

Authored by sstefan1 on Oct 13 2020, 2:06 PM.

Details

Reviewers

jdoerfert
bbn
uenoku
homerdin
baziotis

Commits

rGce16be253c4d: [Attributor][NFC] Make `createShallowWrapper()` available outside of Attributor

Summary

D85703 will need to create shallow wrappers in order to track the spmd icv. We need to make it available.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

sstefan1 created this revision.Oct 13 2020, 2:06 PM

Herald added a reviewer: uenoku. · View Herald TranscriptOct 13 2020, 2:06 PM

Herald added a reviewer: homerdin. · View Herald Transcript

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: llvm-commits, okura, kuter and 2 others. · View Herald Transcript

sstefan1 requested review of this revision.Oct 13 2020, 2:06 PM

Herald added a reviewer: baziotis. · View Herald TranscriptOct 13 2020, 2:06 PM

jdoerfert added inline comments.Oct 13 2020, 2:11 PM

llvm/include/llvm/Transforms/IPO/Attributor.h
1596	No need to move the code in the header, right? Just move the declaration here.

sstefan1 added inline comments.Oct 13 2020, 2:20 PM

llvm/include/llvm/Transforms/IPO/Attributor.h
1596	Right...rushed this a bit, will update shortly.

Only move the declaration

Harbormaster completed remote builds in B74975: Diff 297954.Oct 13 2020, 2:42 PM

Harbormaster completed remote builds in B74977: Diff 297960.Oct 13 2020, 3:00 PM

LGTM

This revision is now accepted and ready to land.Oct 13 2020, 9:06 PM

This revision was landed with ongoing or failed builds.Oct 14 2020, 1:10 AM

Closed by commit rGce16be253c4d: [Attributor][NFC] Make `createShallowWrapper()` available outside of Attributor (authored by sstefan1). · Explain Why

This revision was automatically updated to reflect the committed changes.

sstefan1 added a commit: rGce16be253c4d: [Attributor][NFC] Make `createShallowWrapper()` available outside of Attributor.

Revision Contents
Changeset List

Path

Size

llvm/

include/

llvm/

Transforms/

IPO/

Attributor.h

16 lines

lib/

Transforms/

IPO/

Attributor.cpp

24 lines

Diff 298062

View Options

llvm/include/llvm/Transforms/IPO/Attributor.h