This is an archive of the discontinued LLVM Phabricator instance.

Differential D89309

[ThinLTO] In documentation, mention possible values for concurrency flags
ClosedPublic

Authored by aganea on Oct 13 2020, 5:21 AM.

Details

Reviewers
thakis
hans
tejohnson
Commits
rG1dbf05f5b44d: [ThinLTO][Documentation] Mention possible values for concurrency flags
Summary

As suggested here: https://reviews.llvm.org/D75153#2323939

Diff Detail

Unit TestsFailed

TimeTest
4,220 mswindows > Clang-Unit.DirectoryWatcher/_/DirectoryWatcherTests_exe::DirectoryWatcherTest.AddFiles
4,019 mswindows > Clang-Unit.DirectoryWatcher/_/DirectoryWatcherTests_exe::DirectoryWatcherTest.DeleteFile
4,019 mswindows > Clang-Unit.DirectoryWatcher/_/DirectoryWatcherTests_exe::DirectoryWatcherTest.ModifyFile

Event Timeline

aganea created this revision.Oct 13 2020, 5:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 13 2020, 5:21 AM
Herald added subscribers: cfe-commits, dexonsmith, steven_wu and 2 others. · View Herald Transcript
aganea requested review of this revision.Oct 13 2020, 5:21 AM
aganea retitled this revision from [ThinLTO] In documentation, mention possible value for concurrency flags to [ThinLTO] In documentation, mention possible values for concurrency flags.
aganea added a reviewer: tejohnson.
hans added a comment.Oct 13 2020, 6:00 AM

Thanks for documenting these!

I wonder if including the "CPU sockets" part is more confusing than helpful (especially if the reader doesn't know about CPU sockets). The sockets don't really matter here anyway.

Sometimes the term "physical core" is used in relation to hyper-threading and I find that pretty understandable. How about something line:

  • 0: Use one thread per physical core (default)
  • 1: Use a single thread only (disable multi-threading)
  • all: Use one thread per logical core (uses all hyper threads)
Harbormaster completed remote builds in B74924: Diff 297830.Oct 13 2020, 6:24 AM
aganea updated this revision to Diff 297845.Oct 13 2020, 6:44 AM

As suggested by @hans.

hans accepted this revision.Oct 13 2020, 6:49 AM
This revision is now accepted and ready to land.Oct 13 2020, 6:49 AM
This revision was landed with ongoing or failed builds.Oct 13 2020, 6:58 AM
Closed by commit rG1dbf05f5b44d: [ThinLTO][Documentation] Mention possible values for concurrency flags (authored by aganea). · Explain Why
This revision was automatically updated to reflect the committed changes.
aganea added a commit: rG1dbf05f5b44d: [ThinLTO][Documentation] Mention possible values for concurrency flags.
Harbormaster completed remote builds in B74933: Diff 297845.Oct 13 2020, 7:24 AM

Revision Contents

PathSize
clang/
docs/
5 lines

Diff 297845

clang/docs/ThinLTO.rst

Show First 20 Lines • Show All 117 Lines • ▼ Show 20 Lines- gold:
``-Wl,-plugin-opt,jobs=N`` ``-Wl,-plugin-opt,jobs=N``
- ld64: - ld64:
``-Wl,-mllvm,-threads=N`` ``-Wl,-mllvm,-threads=N``
- lld: - lld:
``-Wl,--thinlto-jobs=N`` ``-Wl,--thinlto-jobs=N``
- lld-link: - lld-link:
``/opt:lldltojobs=N`` ``/opt:lldltojobs=N``
Other possible values for ``N`` are:
- 0: Use one thread per physical core (default)
- 1: Use a single thread only (disable multi-threading)
- all: Use one thread per logical core (uses all hyper-threads)
Incremental Incremental
----------- -----------
.. _incremental: .. _incremental:
ThinLTO supports fast incremental builds through the use of a cache, ThinLTO supports fast incremental builds through the use of a cache,
which currently must be enabled through a linker option. which currently must be enabled through a linker option.
- gold (as of LLVM 4.0): - gold (as of LLVM 4.0):
▲ Show 20 Lines • Show All 105 Lines • Show Last 20 Lines