Add initial infra to convert annotations to MD and display summary remarks (WIP)
AbandonedPublic
Actions

Authored by fhahn on Oct 12 2020, 7:52 AM.

Details

Reviewers: None

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	390 ms	linux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp Script: -- : 'RUN: at line 3'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang --driver-mode=g++ -m64 -gline-tables-only -fsanitize=hwaddress -fuse-ld=lld -mcmodel=large -mllvm -hwasan-globals -mllvm -hwasan-use-short-granules -mllvm -hwasan-instrument-landing-pads=0 -mllvm -hwasan-instrument-personality-functions /mnt/disks/ssd0/agent/llvm-project/compiler-rt/test/hwasan/TestCases/sizes.cpp -nostdlib++ -lstdc++ -o /mnt/disks/ssd0/agent/llvm-project/build/projects/compiler-rt/test/hwasan/X86_64/TestCases/Output/sizes.cpp.tmp
	40 ms	linux > LLVM.CodeGen/AMDGPU::opt-pipeline.ll Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/build/bin/opt -O0 -mtriple=amdgcn--amdhsa -disable-output -disable-verify -debug-pass=Structure /mnt/disks/ssd0/agent/llvm-project/llvm/test/CodeGen/AMDGPU/opt-pipeline.ll 2>&1 \| /mnt/disks/ssd0/agent/llvm-project/build/bin/FileCheck -check-prefix=GCN-O0 /mnt/disks/ssd0/agent/llvm-project/llvm/test/CodeGen/AMDGPU/opt-pipeline.ll
	50 ms	linux > LLVM.Other::opt-O0-pipeline.ll Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/build/bin/opt -enable-new-pm=0 -mtriple=x86_64-- -O0 -debug-pass=Structure < /mnt/disks/ssd0/agent/llvm-project/llvm/test/Other/opt-O0-pipeline.ll -o /dev/null 2>&1 \| /mnt/disks/ssd0/agent/llvm-project/build/bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/llvm/test/Other/opt-O0-pipeline.ll --check-prefixes=CHECK,CHECK-NOEXT
	40 ms	linux > LLVM.Other::opt-O2-pipeline.ll Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/build/bin/opt -enable-new-pm=0 -mtriple=x86_64-- -O2 -debug-pass=Structure < /mnt/disks/ssd0/agent/llvm-project/llvm/test/Other/opt-O2-pipeline.ll -o /dev/null 2>&1 \| /mnt/disks/ssd0/agent/llvm-project/build/bin/FileCheck --check-prefixes=CHECK,CHECK-NOEXT /mnt/disks/ssd0/agent/llvm-project/llvm/test/Other/opt-O2-pipeline.ll
	40 ms	linux > LLVM.Other::opt-O3-pipeline-enable-matrix.ll Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/build/bin/opt -enable-new-pm=0 -O3 -enable-matrix -debug-pass=Structure < /mnt/disks/ssd0/agent/llvm-project/llvm/test/Other/opt-O3-pipeline-enable-matrix.ll -o /dev/null 2>&1 \| /mnt/disks/ssd0/agent/llvm-project/build/bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/llvm/test/Other/opt-O3-pipeline-enable-matrix.ll
		View Full Test Results (13 Failed)

Event Timeline

fhahn created this revision.Oct 12 2020, 7:52 AM

Herald added a project: Restricted Project. · View Herald TranscriptOct 12 2020, 7:52 AM

Herald added subscribers: hiraditya, mgorny. · View Herald Transcript

fhahn requested review of this revision.Oct 12 2020, 7:52 AM

Harbormaster completed remote builds in B74797: Diff 297587.Oct 12 2020, 8:31 AM

rebase

Herald added a subscriber: dexonsmith. · View Herald TranscriptNov 4 2020, 6:48 AM

Harbormaster completed remote builds in B77546: Diff 302833.Nov 4 2020, 7:31 AM

thegameg added a subscriber: thegameg.Nov 6 2020, 12:02 PM

thegameg added inline comments.

llvm/lib/IR/Instruction.cpp
127
llvm/lib/Transforms/Scalar/AnnotationRemarks.cpp
40

thegameg added inline comments.Nov 6 2020, 12:07 PM

llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
908	How does this get scheduled for LTO? This should probably run after IR linking and all that (when prototyping, I put it in TargetPassConfig for better results, but that doesn't sound like the right place to schedule passes like this in general)
llvm/lib/Transforms/Scalar/AnnotationRemarks.cpp
37	One other way would be to walk back the uses of the metadata, but it might not be worth it since it would require a ModulePass.

Address most of Francis' comments, thanks!

Herald added subscribers: nikic, kerbowa, steven_wu and 2 others. · View Herald TranscriptNov 9 2020, 10:13 AM

fhahn marked an inline comment as done.Nov 9 2020, 10:15 AM

fhahn added inline comments.

llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
908	I also added it to the end of the LTO pipeline. Still need to add this for the new PM.
llvm/lib/Transforms/Scalar/AnnotationRemarks.cpp
37	Yeah that would probably be better. I'll try to update the code.