Page MenuHomePhabricator

[RTDYLD] add debug statements for resolveX86Relocation
AbandonedPublic

Authored by vchuravy on Oct 11 2020, 11:21 AM.

Details

Reviewers
lhames
Summary

Adds some debug statements to resolveX86Relocation so that the next person doesn't have to diff the object to figure out what changed.

Diff Detail

Unit TestsFailed

TimeTest
3,500 mswindows > Clang-Unit.DirectoryWatcher/_/DirectoryWatcherTests_exe::DirectoryWatcherTest.AddFiles
Note: Google Test filter = DirectoryWatcherTest.AddFiles [==========] Running 1 test from 1 test case.
3,420 mswindows > Clang-Unit.DirectoryWatcher/_/DirectoryWatcherTests_exe::DirectoryWatcherTest.DeleteFile
Note: Google Test filter = DirectoryWatcherTest.DeleteFile [==========] Running 1 test from 1 test case.
3,430 mswindows > Clang-Unit.DirectoryWatcher/_/DirectoryWatcherTests_exe::DirectoryWatcherTest.ModifyFile
Note: Google Test filter = DirectoryWatcherTest.ModifyFile [==========] Running 1 test from 1 test case.

Event Timeline

vchuravy created this revision.Oct 11 2020, 11:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 11 2020, 11:21 AM
vchuravy requested review of this revision.Oct 11 2020, 11:21 AM

I think this can be very noisy as the number of relocations can be very large.

I think this can be very noisy as the number of relocations can be very large.

I agree. They can be rather noisy, but without them the only tool you have to debug relocations going wrong is to dump the section before and after relocations and to perform a manual diff,
and the code for x86_64 has the same debug statements for some relocations types as well. This kinda makes me wish we had multiple levels of debug output for LLVM, but let's not go there.

vchuravy abandoned this revision.Nov 23 2020, 4:06 PM

Sorry -- I missed this one earlier. For what it's worth JITLink prints with wild abandon. In general I'd rather log everything and then concentrate on log formatting to make it searchable/digestible.