Page MenuHomePhabricator

[mlir] Fix bug in computing operation order
ClosedPublic

Authored by jmolloy on Oct 9 2020, 3:55 AM.

Details

Summary

When attempting to compute a differential orderIndex we were calculating the
bailout condition correctly, but then an errant "+ 1" meant the orderIndex we
created was invalid.

Added test.

Diff Detail

Event Timeline

jmolloy created this revision.Oct 9 2020, 3:55 AM
Herald added a project: Restricted Project. · View Herald Transcript
jmolloy requested review of this revision.Oct 9 2020, 3:55 AM
ftynse accepted this revision.Oct 9 2020, 4:00 AM
ftynse added inline comments.
mlir/unittests/IR/OperationSupportTest.cpp
173

Style nit: MLIR doesn't use const on stack variables.

This revision is now accepted and ready to land.Oct 9 2020, 4:00 AM
jmolloy updated this revision to Diff 297186.Oct 9 2020, 4:12 AM

Removed errant "const".

jmolloy marked an inline comment as done.Oct 9 2020, 4:12 AM
This revision was landed with ongoing or failed builds.Oct 9 2020, 4:19 AM
This revision was automatically updated to reflect the committed changes.