This is an archive of the discontinued LLVM Phabricator instance.

Differential D89081

[mlir][CAPI] Remove the exclusion of the MLIR C-API from libMLIR.so.
ClosedPublic

Authored by stellaraccident on Oct 8 2020, 4:42 PM.

Details

Reviewers
silvas
ftynse
Commits
rG137da82b8682: [mlir][CAPI] Remove the exclusion of the MLIR C-API from libMLIR.so.
Summary
  • I believe this was done early on due to it being experimental/etc.
  • Needed for dynamic linking in npcomp.

Diff Detail

Event Timeline

stellaraccident created this revision.Oct 8 2020, 4:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 8 2020, 4:42 PM
Herald added subscribers: tatianashp, msifontes, jurahul and 13 others. · View Herald Transcript
stellaraccident requested review of this revision.Oct 8 2020, 4:42 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald TranscriptOct 8 2020, 4:42 PM
stellaraccident added reviewers: silvas, ftynse.Oct 8 2020, 4:43 PM
Harbormaster completed remote builds in B74504: Diff 297078.Oct 8 2020, 4:58 PM
silvas accepted this revision.Oct 8 2020, 5:14 PM
This revision is now accepted and ready to land.Oct 8 2020, 5:14 PM
Closed by commit rG137da82b8682: [mlir][CAPI] Remove the exclusion of the MLIR C-API from libMLIR.so. (authored by stellaraccident). · Explain WhyOct 8 2020, 6:28 PM
This revision was automatically updated to reflect the committed changes.
stellaraccident added a commit: rG137da82b8682: [mlir][CAPI] Remove the exclusion of the MLIR C-API from libMLIR.so..

Revision Contents

PathSize
mlir/
lib/
CAPI/
IR/
2 lines
Registration/
2 lines

Diff 297102

mlir/lib/CAPI/IR/CMakeLists.txt

# Main API. # Main API.
add_mlir_library(MLIRCAPIIR add_mlir_library(MLIRCAPIIR
AffineMap.cpp AffineMap.cpp
Diagnostics.cpp Diagnostics.cpp
IR.cpp IR.cpp
StandardAttributes.cpp StandardAttributes.cpp
StandardTypes.cpp StandardTypes.cpp
Support.cpp Support.cpp
EXCLUDE_FROM_LIBMLIR
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir-c ${MLIR_MAIN_INCLUDE_DIR}/mlir-c
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRIR MLIRIR
MLIRParser MLIRParser
MLIRSupport MLIRSupport
) )

mlir/lib/CAPI/Registration/CMakeLists.txt

# Dialect registration. # Dialect registration.
get_property(dialect_libs GLOBAL PROPERTY MLIR_DIALECT_LIBS) get_property(dialect_libs GLOBAL PROPERTY MLIR_DIALECT_LIBS)
add_mlir_library(MLIRCAPIRegistration add_mlir_library(MLIRCAPIRegistration
Registration.cpp Registration.cpp
EXCLUDE_FROM_LIBMLIR
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir-c ${MLIR_MAIN_INCLUDE_DIR}/mlir-c
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRCAPIIR MLIRCAPIIR
${dialect_libs} ${dialect_libs}
) )