This is an archive of the discontinued LLVM Phabricator instance.

[LoopInterchange][NewPM] Port -loop-interchange to NPM
ClosedPublic

Authored by aeubanks on Oct 8 2020, 11:01 AM.

Diff Detail

Unit TestsFailed

Event Timeline

aeubanks created this revision.Oct 8 2020, 11:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 8 2020, 11:01 AM
aeubanks requested review of this revision.Oct 8 2020, 11:01 AM
fhahn accepted this revision.Oct 9 2020, 2:54 AM

LGTM, thanks

llvm/include/llvm/Transforms/Scalar/LoopInterchange.h
1

Needs updating to Loop interchange pass or something?

17

unneeded?

20

nit: I think the style guide suggest using struct instead of class, if the first/all members are public.

llvm/lib/Transforms/Scalar/LoopInterchange.cpp
1634

nit: /// ?

This revision is now accepted and ready to land.Oct 9 2020, 2:54 AM
aeubanks updated this revision to Diff 297255.Oct 9 2020, 9:09 AM

address comments

This revision was landed with ongoing or failed builds.Oct 9 2020, 9:21 AM
This revision was automatically updated to reflect the committed changes.