Page MenuHomePhabricator

[mlir][CAPI] Attribute set/remove on operations.
ClosedPublic

Authored by stellaraccident on Oct 6 2020, 11:06 PM.

Details

Summary
  • New functions: mlirOperationSetAttributeByName, mlirOperationRemoveAttributeByName
  • Also adds some *IsNull checks and standardizes the rest to use "static inline" form, which makes them all non-opaque and not part of the ABI (which is desirable).
  • Changes needed to resolve TODOs in npcomp PyTorch capture.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptOct 6 2020, 11:06 PM
stellaraccident requested review of this revision.Oct 6 2020, 11:06 PM
ftynse accepted this revision.Oct 7 2020, 2:48 AM
This revision is now accepted and ready to land.Oct 7 2020, 2:48 AM
This revision was landed with ongoing or failed builds.Oct 7 2020, 10:06 AM
This revision was automatically updated to reflect the committed changes.