RequiresDataSharing was always 0, resulting dead code in device runtime library.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Change looks great to me.
Rolling the reduction in leading whitespace in nvptx_target_parallel_reduction_codegen.cpp in with the patch might be contentious, added a couple more reviewers to see if other people would prefer that part split out. I'll accept in a day or so if there are no comments on the whitespace.
Thanks!
openmp/libomptarget/deviceRTLs/common/src/omptarget.cu | ||
---|---|---|
135–136 | This is interesting. This turns out to be the only call to RootS(), and that cascades through a bunch of other code removed in this patch. |
Comment Actions
Fine by me, I don't think it's worth uploading an extra patch just for this minor formatting detail.
Comment Actions
Thanks guys, will remember that as the local convention on rolling whitespace changes into other stuff.
This is interesting. This turns out to be the only call to RootS(), and that cascades through a bunch of other code removed in this patch.