This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt][cmake][powerpc] Remove TEST_BIG_ENDIAN from base-config-ix.cmake
ClosedPublic

Authored by daltenty on Sep 30 2020, 1:01 PM.

Details

Summary

It's actually not safe to call TEST_BIG_ENDIAN here, since we may be
running from the builtins build (i.e builtins-config-ix) context where
TEST_COMPILE_ONLY is set since without builtins already built we may
fail to link, and TEST_BIG_ENDIAN internally performs tests which may
fail to link without builtins.

Fortunately powerpc is the only target that uses this information here and
we actually already know the whether we are targeting the LE variant due
to earlier macro checks, so we can simply this to remove our reliance on
TEST_BIG_ENDIAN.

Diff Detail

Event Timeline

daltenty created this revision.Sep 30 2020, 1:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 30 2020, 1:01 PM
Herald added subscribers: Restricted Project, steven.zhang, shchenz and 3 others. · View Herald Transcript
daltenty requested review of this revision.Sep 30 2020, 1:01 PM
Whitney accepted this revision.Sep 30 2020, 1:52 PM
This revision is now accepted and ready to land.Sep 30 2020, 1:52 PM