This is an archive of the discontinued LLVM Phabricator instance.

Differential D88546

[ARM] Update NEON testcase with missing target string in
ClosedPublic

Authored by rs on Sep 30 2020, 2:45 AM.

Details

Reviewers
SjoerdMeijer
john.brawn
Commits
rGe4f50e587f07: [ARM] Add missing target for Arm neon test case.
Summary

This is a follow-up from https://reviews.llvm.org/D61717. Where Richard described the issue with compiling arm_neon.h under -flax-vector-conversions=none. It looks like the example reproducer does actually work:

echo '#include <arm_neon.h>' | clang -target arm64-linux-gnu -arch +neon -fsyntax-only -x c - -fno-lax-vector-conversions

but was missing the -ffreestanding compiler option otherwise the compiler would select the system headers from /usr. However, arm-neon-header.c test was missing this target triple 'arm64-linux-gnu' so I've added it here.

Diff Detail

Event Timeline

rs created this revision.Sep 30 2020, 2:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 30 2020, 2:45 AM
Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. · View Herald Transcript
rs requested review of this revision.Sep 30 2020, 2:45 AM
Harbormaster completed remote builds in B73479: Diff 295219.Sep 30 2020, 2:55 AM
john.brawn accepted this revision.Sep 30 2020, 8:12 AM

LGTM.

This revision is now accepted and ready to land.Sep 30 2020, 8:12 AM
Closed by commit rGe4f50e587f07: [ARM] Add missing target for Arm neon test case. (authored by rs). · Explain WhySep 30 2020, 4:37 PM
This revision was automatically updated to reflect the committed changes.
rs added a commit: rGe4f50e587f07: [ARM] Add missing target for Arm neon test case..

Revision Contents

PathSize
clang/
test/
Headers/
1 line

Diff 295435

clang/test/Headers/arm-neon-header.c

Show All 16 Lines
// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding -nostdinc++ --target=aarch64_be-none-eabi -march=armv8.2-a+fp16 -std=c++98 -xc++ %s // RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding -nostdinc++ --target=aarch64_be-none-eabi -march=armv8.2-a+fp16 -std=c++98 -xc++ %s
// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding -nostdinc++ --target=aarch64_be-none-eabi -march=armv8.2-a+fp16 -std=c++11 -xc++ %s // RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding -nostdinc++ --target=aarch64_be-none-eabi -march=armv8.2-a+fp16 -std=c++11 -xc++ %s
// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding -nostdinc++ --target=aarch64_be-none-eabi -march=armv8.2-a+fp16 -std=c++14 -xc++ %s // RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding -nostdinc++ --target=aarch64_be-none-eabi -march=armv8.2-a+fp16 -std=c++14 -xc++ %s
// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding -nostdinc++ --target=aarch64_be-none-eabi -march=armv8.2-a+fp16 -std=c++17 -xc++ %s // RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding -nostdinc++ --target=aarch64_be-none-eabi -march=armv8.2-a+fp16 -std=c++17 -xc++ %s
// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-none-eabi -march=armv8.2-a+fp16fml+crypto+dotprod -std=c11 -xc -flax-vector-conversions=none %s // RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-none-eabi -march=armv8.2-a+fp16fml+crypto+dotprod -std=c11 -xc -flax-vector-conversions=none %s
// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64_be-none-eabi -march=armv8.2-a+fp16fml+crypto+dotprod -std=c11 -xc -flax-vector-conversions=none %s // RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64_be-none-eabi -march=armv8.2-a+fp16fml+crypto+dotprod -std=c11 -xc -flax-vector-conversions=none %s
// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=arm64-linux-gnu -arch +neon -std=c11 -xc -flax-vector-conversions=none %s
#include <arm_neon.h> #include <arm_neon.h>