This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Disable msan instrumentation for generated Evaluate().
ClosedPublic

Authored by usaxena95 on Sep 29 2020, 8:22 AM.

Details

Summary

MSAN build times out for generated DecisionForest inference runtime.

A solution worth trying is splitting the function into 300 smaller
functions and then re-enable msan.

For now we are disabling instrumentation for the generated function.

Diff Detail

Event Timeline

usaxena95 created this revision.Sep 29 2020, 8:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 29 2020, 8:22 AM
usaxena95 requested review of this revision.Sep 29 2020, 8:22 AM
adamcz accepted this revision.Sep 29 2020, 8:24 AM
adamcz added inline comments.
clang-tools-extra/clangd/quality/CompletionModelCodegen.py
164

Please add a comment here explaining why this is disabled.

This revision is now accepted and ready to land.Sep 29 2020, 8:24 AM
usaxena95 updated this revision to Diff 295005.Sep 29 2020, 8:38 AM

Addressed comments.

usaxena95 marked an inline comment as done.Sep 29 2020, 8:38 AM