This is an archive of the discontinued LLVM Phabricator instance.

Differential D88467

fix out-of-tree clang build due to sysexits change
ClosedPublic

Authored by airlied on Sep 28 2020, 10:02 PM.

Details

Reviewers
Kai
Summary

The sysexists change broke clang building out of tree against llvm.

Diff Detail

Unit TestsFailed

TimeTest
960 mslinux > Clang.Headers::nvptx_device_math_complex.cpp

Event Timeline

airlied created this revision.Sep 28 2020, 10:02 PM
Herald added subscribers: llvm-commits, mgorny. · View Herald TranscriptSep 28 2020, 10:02 PM
airlied requested review of this revision.Sep 28 2020, 10:02 PM
Harbormaster completed remote builds in B73280: Diff 294883.Sep 28 2020, 10:14 PM
Kai accepted this revision.Oct 2 2020, 9:28 AM

LGTM. Sorry for causing the build break.

This revision is now accepted and ready to land.Oct 2 2020, 9:28 AM
airlied added a comment.Oct 5 2020, 4:47 PM

I don't have commit access, can someone please push this.

arsenm mentioned this in rG5e4409f30817: Fix out-of-tree clang build due to sysexits change.Oct 6 2020, 3:21 PM
arsenm closed this revision.Oct 6 2020, 3:24 PM
rnk mentioned this in D113610: Only set LLVM_EXTERNAL_VISIBILITY when building libLLVM dylib.Nov 11 2021, 1:47 PM

Revision Contents

PathSize
llvm/
include/
llvm/
Config/
3 lines
3 lines
Support/
2 lines

Diff 294883

llvm/include/llvm/Config/config.h.cmake

Context not available.
/* Define to 1 if you have the <sys/types.h> header file. */ /* Define to 1 if you have the <sys/types.h> header file. */
#cmakedefine HAVE_SYS_TYPES_H ${HAVE_SYS_TYPES_H} #cmakedefine HAVE_SYS_TYPES_H ${HAVE_SYS_TYPES_H}
/* Define to 1 if you have the <sysexits.h> header file. */
#cmakedefine HAVE_SYSEXITS_H ${HAVE_SYSEXITS_H}
/* Define if the setupterm() function is supported this platform. */ /* Define if the setupterm() function is supported this platform. */
#cmakedefine LLVM_ENABLE_TERMINFO ${LLVM_ENABLE_TERMINFO} #cmakedefine LLVM_ENABLE_TERMINFO ${LLVM_ENABLE_TERMINFO}
Context not available.

llvm/include/llvm/Config/llvm-config.h.cmake

Context not available.
/* Define if LLVM was built with a dependency to the tensorflow compiler */ /* Define if LLVM was built with a dependency to the tensorflow compiler */
#cmakedefine LLVM_HAVE_TF_AOT #cmakedefine LLVM_HAVE_TF_AOT
/* Define to 1 if you have the <sysexits.h> header file. */
#cmakedefine HAVE_SYSEXITS_H ${HAVE_SYSEXITS_H}
#endif #endif
Context not available.

llvm/include/llvm/Support/ExitCodes.h

Context not available.
#ifndef LLVM_SUPPORT_EXITCODES_H #ifndef LLVM_SUPPORT_EXITCODES_H
#define LLVM_SUPPORT_EXITCODES_H #define LLVM_SUPPORT_EXITCODES_H
#include "llvm/Config/config.h" #include "llvm/Config/llvm-config.h"
#if HAVE_SYSEXITS_H #if HAVE_SYSEXITS_H
#include <sysexits.h> #include <sysexits.h>
Context not available.