Page MenuHomePhabricator

airlied (Dave Airlie)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 9 2016, 11:45 PM (293 w, 2 d)

Recent Activity

Jan 20 2022

airlied committed rGe1b7bd911d9e: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images (authored by airlied).
[OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images
Jan 20 2022, 3:51 PM
airlied closed D107539: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images.
Jan 20 2022, 3:51 PM · Restricted Project

Oct 4 2021

airlied abandoned D111111: libclc: fix include directory in pc file.

not sure what I misread here.

Oct 4 2021, 8:05 PM · Restricted Project
airlied requested review of D111111: libclc: fix include directory in pc file.
Oct 4 2021, 8:04 PM · Restricted Project

Aug 6 2021

airlied updated the diff for D107539: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images.

fixed issues with check-clang, might need some follow up changes.

Aug 6 2021, 6:14 PM · Restricted Project
airlied committed rG1854db74c549: opencl-c.h: add 3.0 optional extension support for a few more bits (authored by airlied).
opencl-c.h: add 3.0 optional extension support for a few more bits
Aug 6 2021, 4:26 PM
airlied closed D105858: opencl-c.h: add 3.0 optional extension support for a few more bits.
Aug 6 2021, 4:25 PM · Restricted Project

Aug 5 2021

airlied updated the diff for D107539: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images.

missed a couple of hunks.

Aug 5 2021, 2:46 AM · Restricted Project
airlied updated the diff for D107539: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images.

found a few more places to replace these and fix them up. there might still be some strays in there.

Aug 5 2021, 2:41 AM · Restricted Project
airlied updated subscribers of D107539: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images.

Add @azabaznov

Aug 5 2021, 1:18 AM · Restricted Project
airlied requested review of D107539: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images.
Aug 5 2021, 1:17 AM · Restricted Project
airlied updated the diff for D105858: opencl-c.h: add 3.0 optional extension support for a few more bits.

Added a comment on the subgroups difference.

Aug 5 2021, 12:31 AM · Restricted Project

Aug 4 2021

airlied committed rG14cb67862a72: [OpenCL] allow generic address and non-generic defs for CL3.0 (authored by airlied).
[OpenCL] allow generic address and non-generic defs for CL3.0
Aug 4 2021, 2:33 PM
airlied closed D107318: [OpenCL] allow generic address and non-generic defs for CL3.0.
Aug 4 2021, 2:33 PM · Restricted Project

Aug 3 2021

airlied added a comment to D107318: [OpenCL] allow generic address and non-generic defs for CL3.0.

@azabaznov no bad effects here in my initial basic testing with CL 3.0, I'll land this tomorrow or next day when I get a chance.

Aug 3 2021, 8:07 PM · Restricted Project

Aug 2 2021

airlied updated subscribers of D107318: [OpenCL] allow generic address and non-generic defs for CL3.0.

@azabaznov is this what you meant? I haven't tested this yet as my clang dev box died, but I'll get to it as soon as I can.

Aug 2 2021, 4:27 PM · Restricted Project
airlied requested review of D107318: [OpenCL] allow generic address and non-generic defs for CL3.0.
Aug 2 2021, 4:24 PM · Restricted Project

Jul 29 2021

airlied committed rG3c7d2f1b67d1: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics (authored by airlied).
[OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics
Jul 29 2021, 9:48 PM
airlied closed D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics.
Jul 29 2021, 9:47 PM · Restricted Project

Jul 28 2021

airlied added inline comments to D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics.
Jul 28 2021, 5:18 PM · Restricted Project
airlied updated the diff for D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics.

added comments.

Jul 28 2021, 5:16 PM · Restricted Project

Jul 27 2021

airlied added a comment to D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics.

Generally LGTM, but I think we should guard the else blocks with CL_VERSION_2_0 or higher to avoid exposing the functions in earlier standards because the spec says:

The C11 style atomic functions in this sub-section require support for OpenCL 2.0 or newer. However, this statement does not apply to the "OpenCL C 1.x Legacy Atomics" descriptions at the end of this sub-section.

Adding @azabaznov to check if he can suggest anything for testing. Although it seems like this is only related to the new functionality of OpenCL3.0.

Jul 27 2021, 7:15 PM · Restricted Project
airlied added a comment to D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics.

Generally LGTM, but I think we should guard the else blocks with CL_VERSION_2_0 or higher to avoid exposing the functions in earlier standards because the spec says:

The C11 style atomic functions in this sub-section require support for OpenCL 2.0 or newer. However, this statement does not apply to the "OpenCL C 1.x Legacy Atomics" descriptions at the end of this sub-section.

Adding @azabaznov to check if he can suggest anything for testing. Although it seems like this is only related to the new functionality of OpenCL3.0.

Jul 27 2021, 7:11 PM · Restricted Project

Jul 25 2021

airlied updated subscribers of D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics.
Jul 25 2021, 7:44 PM · Restricted Project
airlied updated the summary of D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics.
Jul 25 2021, 7:42 PM · Restricted Project
airlied requested review of D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics.
Jul 25 2021, 7:42 PM · Restricted Project
airlied committed rG9451403c5f8c: [OPENCL] opencl-c.h: add initial CL 3.0 conditionals for atomic operations. (authored by airlied).
[OPENCL] opencl-c.h: add initial CL 3.0 conditionals for atomic operations.
Jul 25 2021, 6:07 PM
airlied closed D106111: opencl-c.h: add initial CL 3.0 conditionals for atomic operations..
Jul 25 2021, 6:06 PM · Restricted Project

Jul 20 2021

airlied updated the diff for D106111: opencl-c.h: add initial CL 3.0 conditionals for atomic operations..

add conditional around memory_order_seq_cst

Jul 20 2021, 8:32 PM · Restricted Project

Jul 15 2021

airlied requested review of D106111: opencl-c.h: add initial CL 3.0 conditionals for atomic operations..
Jul 15 2021, 4:45 PM · Restricted Project
airlied added a comment to D105858: opencl-c.h: add 3.0 optional extension support for a few more bits.

yeah I agree I'll drop those two changes.

Jul 15 2021, 4:42 PM · Restricted Project
airlied updated the diff for D105858: opencl-c.h: add 3.0 optional extension support for a few more bits.

leave version checks alone since they are inside the outer extension check.

Jul 15 2021, 4:41 PM · Restricted Project
airlied updated the diff for D105858: opencl-c.h: add 3.0 optional extension support for a few more bits.

fixed up missing cl_khr_subgroups checks.

Jul 15 2021, 1:39 PM · Restricted Project

Jul 14 2021

airlied committed rGde79ba9f9a2d: [OpenCL] opencl-c.h: CL3.0 generic address space (authored by airlied).
[OpenCL] opencl-c.h: CL3.0 generic address space
Jul 14 2021, 5:51 PM
airlied closed D105526: opencl-c.h: CL3.0 generic address space.
Jul 14 2021, 5:51 PM · Restricted Project
airlied committed rG090f007e3481: [OpenCL][NFC] opencl-c.h: reorder atomic operations (authored by airlied).
[OpenCL][NFC] opencl-c.h: reorder atomic operations
Jul 14 2021, 5:49 PM
airlied closed D105601: opencl-c.h: reorder atomic operations.
Jul 14 2021, 5:49 PM · Restricted Project
airlied abandoned D105419: libclc: fix build since recent opencl-c-base.h default include changes..

fixed alternate way.

Jul 14 2021, 5:47 PM · Restricted Project
airlied committed rGea469b08b847: libclc: Add -cl-no-stdinc to clang flags on clang >=13 (authored by jvesely).
libclc: Add -cl-no-stdinc to clang flags on clang >=13
Jul 14 2021, 5:45 PM
airlied closed D99794: libclc: Add -cl-no-stdinc to clang flags on clang >=13.
Jul 14 2021, 5:45 PM · Restricted Project

Jul 12 2021

airlied requested review of D105858: opencl-c.h: add 3.0 optional extension support for a few more bits.
Jul 12 2021, 4:35 PM · Restricted Project
airlied updated the diff for D105526: opencl-c.h: CL3.0 generic address space.

full diff.

Jul 12 2021, 11:23 AM · Restricted Project

Jul 7 2021

airlied requested review of D105601: opencl-c.h: reorder atomic operations.
Jul 7 2021, 5:11 PM · Restricted Project
airlied updated the diff for D105526: opencl-c.h: CL3.0 generic address space.

I've dropped the SPIR change in the base header until things are resolved for library SPIR users to disable extension defines.

Jul 7 2021, 4:11 PM · Restricted Project
airlied added inline comments to D105526: opencl-c.h: CL3.0 generic address space.
Jul 7 2021, 3:34 PM · Restricted Project
airlied updated the diff for D105526: opencl-c.h: CL3.0 generic address space.

updated to full diff.

Jul 7 2021, 10:18 AM · Restricted Project

Jul 6 2021

airlied retitled D105526: opencl-c.h: CL3.0 generic address space from opencl-c.h: some CL3.0 compat bits to opencl-c.h: CL3.0 generic address space.
Jul 6 2021, 8:48 PM · Restricted Project
airlied requested review of D105526: opencl-c.h: CL3.0 generic address space.
Jul 6 2021, 8:46 PM · Restricted Project

Jul 5 2021

airlied requested review of D105419: libclc: fix build since recent opencl-c-base.h default include changes..
Jul 5 2021, 12:11 AM · Restricted Project

Jul 4 2021

airlied added a comment to D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h.

I'll have to rebase/rebuild my build env, I'll try and have something rebasing this cleaner soon.

Jul 4 2021, 11:22 PM · Restricted Project

Nov 26 2020

airlied updated the diff for D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h.

I've moved a bunch of longer checks into just feature checks and defined the features at the top of the file.

Nov 26 2020, 7:16 PM · Restricted Project

Nov 24 2020

airlied added a comment to D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h.

Btw how about making some checks simpler. We could always define feature macros __opencl_c_atomic_scope_device, __opencl_c_generic_address_space for OpenCL 2.0 or C++ for OpenCL . Then everywhere we would only need to check feature macros instead of language versions and feature macros together.

#if !(defined()) && (defined(__OPENCL_CPP_VERSION__) || (__OPENCL_C_VERSION__ == CL_VERSION_2_0))
#define __opencl_c_atomic_scope_device      1
#define __opencl_c_generic_address_space   1
...
#endif
Nov 24 2020, 12:30 PM · Restricted Project

Nov 23 2020

airlied added a comment to D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h.

this file has never been clang-format clean, happy to make changes if reviewer decides they are needed.

Nov 23 2020, 10:41 PM · Restricted Project
airlied requested review of D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h.
Nov 23 2020, 9:44 PM · Restricted Project

Oct 5 2020

airlied added a comment to D88467: fix out-of-tree clang build due to sysexits change.

I don't have commit access, can someone please push this.

Oct 5 2020, 4:47 PM · Restricted Project, Restricted Project

Sep 28 2020

airlied requested review of D88467: fix out-of-tree clang build due to sysexits change.
Sep 28 2020, 10:02 PM · Restricted Project, Restricted Project

Aug 29 2018

airlied updated the diff for D48582: Reverse subregister saved loops in register usage info collector..

Rebased onto latest master. I require someone else to push this as I don't have commit rights.

Aug 29 2018, 3:25 PM

Jul 9 2018

airlied abandoned D48578: use a MapVector for pass manage LastUser.

Thanks for the review, Chandler,

Jul 9 2018, 4:27 PM

Jun 25 2018

airlied created D48582: Reverse subregister saved loops in register usage info collector..
Jun 25 2018, 8:10 PM
airlied created D48578: use a MapVector for pass manage LastUser.
Jun 25 2018, 7:21 PM

May 1 2018

airlied created D46346: AMDGPU: rename OpenCL lowering pass to be R600 specific..
May 1 2018, 8:15 PM · Restricted Project
airlied abandoned D32413: AMDGPU: try and convert fmad to add + omod.
May 1 2018, 8:13 PM

Jun 25 2017

airlied added a comment to D34549: fix regression on VI with SDWA gfx9 support.

At the moment this is more than an assert fix, we have broken VI in favour of GFX9 which nobody has. Please get a workaround, revert or fix into llvm master asap.

Jun 25 2017, 4:46 PM
airlied accepted D34495: AMDGPU: Partially fix implicit.buffer.ptr intrinsic handling.
Jun 25 2017, 4:45 PM
airlied added a comment to D34495: AMDGPU: Partially fix implicit.buffer.ptr intrinsic handling.

Looks good to me, I regression tested a few things with it in geom/tess shader land and they seemed fine.

Jun 25 2017, 4:45 PM

Jun 22 2017

airlied added a comment to D34549: fix regression on VI with SDWA gfx9 support.

Consider this a bug report for Sam, I'm not even sure where to start writing a test.

Jun 22 2017, 9:02 PM
airlied added a reviewer for D34549: fix regression on VI with SDWA gfx9 support: SamWot.
Jun 22 2017, 8:44 PM
airlied created D34549: fix regression on VI with SDWA gfx9 support.
Jun 22 2017, 8:40 PM

May 16 2017

airlied added a comment to D33114: [AMDGPU] Fixes for the new waitcnt insertion pass. Add test..

radv regression looks related do ds_bpermute interactions if I had to guess.

May 16 2017, 5:36 PM

May 8 2017

airlied added inline comments to D32960: AMDGPU/SI: Add llvm.amdgcn.s.buffer.load intrinsic.
May 8 2017, 6:18 PM
airlied updated the diff for D32960: AMDGPU/SI: Add llvm.amdgcn.s.buffer.load intrinsic.

This adds support for the x2/x4 paths. Probably could be done better, and I've tested this with a few vulkan games.

May 8 2017, 5:13 PM
airlied created D32960: AMDGPU/SI: Add llvm.amdgcn.s.buffer.load intrinsic.
May 8 2017, 12:19 AM

Apr 23 2017

airlied added a reviewer for D32413: AMDGPU: try and convert fmad to add + omod: arsenm.
Apr 23 2017, 9:14 PM
airlied created D32413: AMDGPU: try and convert fmad to add + omod.
Apr 23 2017, 9:14 PM

Jan 23 2017

airlied updated the diff for D25428: AMDGPU add support for spilling to a user sgpr pointed buffers.

fixed a regression in the when to emit spill setup path, should have just added isMesaGfx option not removed the other one.

Jan 23 2017, 9:48 PM
airlied updated the diff for D25428: AMDGPU add support for spilling to a user sgpr pointed buffers.

fix pedantry
fix two bugs found in testing.

Jan 23 2017, 9:20 PM
airlied updated the diff for D25428: AMDGPU add support for spilling to a user sgpr pointed buffers.

updates after taking to Tom on irc, still might cause a flag day.

Jan 23 2017, 8:42 PM

Dec 28 2016

airlied updated the diff for D25428: AMDGPU add support for spilling to a user sgpr pointed buffers.

This rewrites the patch, using a new triple OsType (needs renaming to something better), and adds an intrinsic to get access to the private buffer.

Dec 28 2016, 7:18 PM

Dec 15 2016

airlied updated the diff for D25428: AMDGPU add support for spilling to a user sgpr pointed buffers.
Dec 15 2016, 5:53 PM

Oct 10 2016

airlied updated the diff for D25428: AMDGPU add support for spilling to a user sgpr pointed buffers.

Updated diff to spill to a 64-bit buffer, pointed to by 64-bits in the buffer pointed to by SGPR0/1.

Oct 10 2016, 10:35 PM
airlied added a comment to D25428: AMDGPU add support for spilling to a user sgpr pointed buffers.

I think ABI changes should be encoded as part of the triple (a radv environment type?) rather than a subtarget feature. This is supposed to be just the pointer and not the full scratch resource descriptor?

Oct 10 2016, 12:49 AM

Oct 9 2016

airlied added a comment to D25428: AMDGPU add support for spilling to a user sgpr pointed buffers.

FYI: The current mesa side of this is here:
https://github.com/airlied/mesa/tree/radv-wip-spilling

Oct 9 2016, 11:55 PM
airlied retitled D25428: AMDGPU add support for spilling to a user sgpr pointed buffers from to AMDGPU add support for spilling to a user data SREG address..
Oct 9 2016, 11:53 PM