This is an archive of the discontinued LLVM Phabricator instance.

[Object][MachO] Refactor MachOUniversalWriter

Authored by alexander-shaposhnikov on Sep 26 2020, 11:09 PM.



This diff refactors writeUniversalBinary and adds writeUniversalBinaryToBuffer.
This is a preparation for adding support for universal binaries to llvm-objcopy.
The idea behind this diff is similar to D84858.

Test plan: make check-all

Diff Detail

Event Timeline

alexander-shaposhnikov created this object with visibility "All Users".
Herald added a project: Restricted Project. · View Herald TranscriptSep 26 2020, 11:09 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
alexander-shaposhnikov requested review of this revision.Sep 26 2020, 11:09 PM
MaskRay accepted this revision.Sep 27 2020, 1:36 PM

LGTM. It may be good to have the dependent patch posted to demonstrate the refactoring.

This revision is now accepted and ready to land.Sep 27 2020, 1:36 PM
alexander-shaposhnikov added a child revision: Restricted Differential Revision.Sep 28 2020, 3:43 AM
smeenai accepted this revision.Oct 2 2020, 6:15 PM


alexander-shaposhnikov changed the visibility from "All Users" to "Public (No Login Required)".Oct 6 2020, 11:54 PM