Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

[Object][MachO] Refactor MachOUniversalWriter
ClosedPublic
Actions

Authored by alexander-shaposhnikov on Sep 26 2020, 11:09 PM.

Details

Reviewers

smeenai
MaskRay
jhenderson

Commits

rGd20c602aad7c: [Object][MachO] Refactor MachOUniversalWriter

Summary

This diff refactors writeUniversalBinary and adds writeUniversalBinaryToBuffer.
This is a preparation for adding support for universal binaries to llvm-objcopy.
The idea behind this diff is similar to D84858.

Test plan: make check-all

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

alexander-shaposhnikov created this revision.Sep 26 2020, 11:09 PM

alexander-shaposhnikov created this object with visibility "All Users".

Herald added a project: Restricted Project. · View Herald TranscriptSep 26 2020, 11:09 PM

Herald added a subscriber: hiraditya. · View Herald Transcript

alexander-shaposhnikov requested review of this revision.Sep 26 2020, 11:09 PM

Harbormaster completed remote builds in B73080: Diff 294537.Sep 26 2020, 11:20 PM

LGTM. It may be good to have the dependent patch posted to demonstrate the refactoring.

This revision is now accepted and ready to land.Sep 27 2020, 1:36 PM

alexander-shaposhnikov added a child revision: Restricted Differential Revision.Sep 28 2020, 3:43 AM

LGTM

Closed by commit rGd20c602aad7c: [Object][MachO] Refactor MachOUniversalWriter (authored by alexander-shaposhnikov). · Explain WhyOct 3 2020, 2:34 PM

This revision was automatically updated to reflect the committed changes.

alexander-shaposhnikov added a commit: rGd20c602aad7c: [Object][MachO] Refactor MachOUniversalWriter.

alexander-shaposhnikov changed the visibility from "All Users" to "Public (No Login Required)".Oct 6 2020, 11:54 PM

Revision Contents
Changeset List

Path

Size

llvm/

include/

llvm/

Object/

MachOUniversalWriter.h

3 lines

lib/

Object/

MachOUniversalWriter.cpp

83 lines

Diff 296006

View Options

llvm/include/llvm/Object/MachOUniversalWriter.h