Page MenuHomePhabricator

[libc++abi] Add an option to avoid demangling in terminate.
ClosedPublic

Authored by danalbert on Sep 23 2020, 4:08 PM.

Details

Summary

We've been using this patch in Android so we can avoid including the
demangler in libc++.so. It comes with a rather large cost in RSS and
isn't commonly needed.

Diff Detail

Event Timeline

danalbert created this revision.Sep 23 2020, 4:08 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 23 2020, 4:08 PM
danalbert requested review of this revision.Sep 23 2020, 4:08 PM
compnerd accepted this revision.Jan 21 2021, 8:57 AM
compnerd added a subscriber: compnerd.

I can sympathize with the desire to avoid the undecoration. Unless @ldionne has some reason why this is a poor choice to support, this seems okay to me.

This revision is now accepted and ready to land.Jan 21 2021, 8:57 AM

Thanks! Has been up for a while and I haven't heard any objections. Will submit and we can revert if issues are found.

This revision was landed with ongoing or failed builds.Jan 21 2021, 1:33 PM
This revision was automatically updated to reflect the committed changes.

Sorry this got through the cracks.

The general idea looks alright to me, but it seems that you're still including the code for the demangler, aren't you?