Page MenuHomePhabricator

[UpdateTestChecks] Match 'attributes #' at the end
AcceptedPublic

Authored by jdoerfert on Sep 22 2020, 7:06 AM.

Details

Summary

Based on D85932, modified slightly, works with the Attributor tests.

With this patch we can now add check lines outside of the function.
For now we match only attributes at the end of the module, but other
values can be added later as well.

Haven't actually tried it yet, but adding checks for other values
should be as easy as adding appropriate regexps in nameless_values list.

Diff Detail

Event Timeline

jdoerfert created this revision.Sep 22 2020, 7:06 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: uenoku, bollu. · View Herald Transcript
jdoerfert requested review of this revision.Sep 22 2020, 7:06 AM
sstefan1 accepted this revision.Sep 22 2020, 7:23 AM

Now I see where the problem was. Thanks for taking a look.

LGTM!

llvm/utils/UpdateTestChecks/common.py
569

Indentation seems off here and in few other places below.

This revision is now accepted and ready to land.Sep 22 2020, 7:23 AM