Page MenuHomePhabricator

[LLD][ELF][test] Fix CHECKs in map-file test
ClosedPublic

Authored by edd on Sep 21 2020, 7:38 AM.

Details

Summary

A repeated typo in lld/test/ELF/map-file.s prevented a number of checks from being executed.

CHECk-NEXT -> CHECK-NEXT
^ ^

After correcting the typo, a small adjustment was needed to match the size of the synthetic .comment section (which always contains "LLD 1.0" in the test environment).

Diff Detail

Event Timeline

edd created this revision.Sep 21 2020, 7:38 AM
Herald added a project: Restricted Project. · View Herald Transcript
edd requested review of this revision.Sep 21 2020, 7:38 AM
grimar accepted this revision.Sep 21 2020, 7:39 AM

LGTM, thanks!

This revision is now accepted and ready to land.Sep 21 2020, 7:39 AM
edd added a comment.Sep 21 2020, 7:48 AM

Thanks for the review. I don't have commit access. Would you be willing to commit on my behalf?

In D88023#2285358, @edd wrote:

Thanks for the review. I don't have commit access. Would you be willing to commit on my behalf?

Sure.

grimar added a comment.EditedSep 21 2020, 7:50 AM

I need the name and email you'd like to use to set patch author info.
E.g:

Name Surname <namesurname@mail.com>
edd added a comment.Sep 21 2020, 8:00 AM

I need the name and email you'd like to use to set patch author info.
E.g:

Name Surname <namesurname@mail.com>
Edd Dawson <edd.dawson@sony.com>

Thanks!

MaskRay accepted this revision.Sep 21 2020, 8:36 AM

LGTM.

This revision was automatically updated to reflect the committed changes.