This is an archive of the discontinued LLVM Phabricator instance.

[MemProf] Rename HeapProfiler to MemProfiler for consistency
ClosedPublic

Authored by tejohnson on Sep 14 2020, 11:00 AM.

Details

Summary

This is consistent with the clang option added in
7ed8124d46f94601d5f1364becee9cee8538265e, and the comments on the
runtime patch in D87120.

Diff Detail

Event Timeline

tejohnson created this revision.Sep 14 2020, 11:00 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptSep 14 2020, 11:00 AM
tejohnson requested review of this revision.Sep 14 2020, 11:00 AM

LG. (Nit: technically this is not NFC: it affects command line options and runtime function names (ABI changes).)

LG. (Nit: technically this is not NFC: it affects command line options and runtime function names (ABI changes).)

Fair enough, will remove that.

tejohnson retitled this revision from [MemProf] Rename HeapProfiler to MemProfiler for consistency (NFC) to [MemProf] Rename HeapProfiler to MemProfiler for consistency.Sep 14 2020, 12:59 PM
davidxl accepted this revision.Sep 14 2020, 1:08 PM

LGTM (if the option is documented, the documentation part also needs to be updated).

This revision is now accepted and ready to land.Sep 14 2020, 1:08 PM

LGTM (if the option is documented, the documentation part also needs to be updated).

It isn't documented yet, since the generated code won't work until the runtime is in. I will be sending a patch for documentation after that is in.

This revision was landed with ongoing or failed builds.Sep 14 2020, 1:16 PM
This revision was automatically updated to reflect the committed changes.
llvm/include/llvm/InitializePasses.h