This is an archive of the discontinued LLVM Phabricator instance.

Differential D87364

clang-cl: Alias /wd4238 to -Wno-address-of-temporary
AcceptedPublic

Authored by ki.stfu on Sep 9 2020, 4:38 AM.

Details

Reviewers
rsmith
rnk
hans
craig.topper
Summary

See https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4238

Diff Detail

Event Timeline

ki.stfu created this revision.Sep 9 2020, 4:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 9 2020, 4:38 AM
Herald added subscribers: cfe-commits, dang. · View Herald Transcript
ki.stfu requested review of this revision.Sep 9 2020, 4:38 AM
Harbormaster completed remote builds in B71066: Diff 290701.Sep 9 2020, 5:18 AM
ki.stfu added a comment.Oct 12 2020, 9:31 AM

@rsmith Friendly ping.

ki.stfu added reviewers: rnk, hans, craig.topper.Nov 3 2020, 8:45 AM
hans accepted this revision.Nov 4 2020, 4:20 AM

lgtm

This revision is now accepted and ready to land.Nov 4 2020, 4:20 AM

Revision Contents

PathSize
clang/
include/
clang/
Driver/
2 lines
test/
Driver/
3 lines

Diff 290701

clang/include/clang/Driver/Options.td

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 4,624 Lines • ▼ Show 20 Linesdef _SLASH_WX_ : CLFlag<"WX-">,
Alias<W_Joined>, AliasArgs<["no-error"]>; Alias<W_Joined>, AliasArgs<["no-error"]>;
def _SLASH_w_flag : CLFlag<"w">, HelpText<"Disable all warnings">, Alias<w>; def _SLASH_w_flag : CLFlag<"w">, HelpText<"Disable all warnings">, Alias<w>;
def _SLASH_wd4005 : CLFlag<"wd4005">, Alias<W_Joined>, def _SLASH_wd4005 : CLFlag<"wd4005">, Alias<W_Joined>,
AliasArgs<["no-macro-redefined"]>; AliasArgs<["no-macro-redefined"]>;
def _SLASH_wd4018 : CLFlag<"wd4018">, Alias<W_Joined>, def _SLASH_wd4018 : CLFlag<"wd4018">, Alias<W_Joined>,
AliasArgs<["no-sign-compare"]>; AliasArgs<["no-sign-compare"]>;
def _SLASH_wd4100 : CLFlag<"wd4100">, Alias<W_Joined>, def _SLASH_wd4100 : CLFlag<"wd4100">, Alias<W_Joined>,
AliasArgs<["no-unused-parameter"]>; AliasArgs<["no-unused-parameter"]>;
def _SLASH_wd4238 : CLFlag<"wd4238">, Alias<W_Joined>,
AliasArgs<["no-address-of-temporary"]>;
def _SLASH_wd4910 : CLFlag<"wd4910">, Alias<W_Joined>, def _SLASH_wd4910 : CLFlag<"wd4910">, Alias<W_Joined>,
AliasArgs<["no-dllexport-explicit-instantiation-decl"]>; AliasArgs<["no-dllexport-explicit-instantiation-decl"]>;
def _SLASH_wd4996 : CLFlag<"wd4996">, Alias<W_Joined>, def _SLASH_wd4996 : CLFlag<"wd4996">, Alias<W_Joined>,
AliasArgs<["no-deprecated-declarations"]>; AliasArgs<["no-deprecated-declarations"]>;
def _SLASH_vd : CLJoined<"vd">, HelpText<"Control vtordisp placement">, def _SLASH_vd : CLJoined<"vd">, HelpText<"Control vtordisp placement">,
Alias<vtordisp_mode_EQ>; Alias<vtordisp_mode_EQ>;
def _SLASH_X : CLFlag<"X">, def _SLASH_X : CLFlag<"X">,
HelpText<"Do not add %INCLUDE% to include search path">, Alias<nostdlibinc>; HelpText<"Do not add %INCLUDE% to include search path">, Alias<nostdlibinc>;
▲ Show 20 Lines • Show All 270 Lines • Show Last 20 Lines

clang/test/Driver/cl-options.c

Show First 20 Lines • Show All 324 Lines • ▼ Show 20 Lines
// RUN: %clang_cl -c -### /std:c++latest -- %s 2>&1 | FileCheck -check-prefix CHECK-LATEST-CHAR8_T %s // RUN: %clang_cl -c -### /std:c++latest -- %s 2>&1 | FileCheck -check-prefix CHECK-LATEST-CHAR8_T %s
// CHECK-LATEST-CHAR8_T-NOT: "-fchar8_t" // CHECK-LATEST-CHAR8_T-NOT: "-fchar8_t"
// RUN: %clang_cl -c -### /Zc:char8_t -- %s 2>&1 | FileCheck -check-prefix CHECK-CHAR8_T %s // RUN: %clang_cl -c -### /Zc:char8_t -- %s 2>&1 | FileCheck -check-prefix CHECK-CHAR8_T %s
// CHECK-CHAR8_T: "-fchar8_t" // CHECK-CHAR8_T: "-fchar8_t"
// RUN: %clang_cl -c -### /Zc:char8_t- -- %s 2>&1 | FileCheck -check-prefix CHECK-CHAR8_T_ %s // RUN: %clang_cl -c -### /Zc:char8_t- -- %s 2>&1 | FileCheck -check-prefix CHECK-CHAR8_T_ %s
// CHECK-CHAR8_T_: "-fno-char8_t" // CHECK-CHAR8_T_: "-fno-char8_t"
// For some warning ids, we can map from MSVC warning to Clang warning. // For some warning ids, we can map from MSVC warning to Clang warning.
// RUN: %clang_cl -wd4005 -wd4100 -wd4910 -wd4996 -### -- %s 2>&1 | FileCheck -check-prefix=Wno %s // RUN: %clang_cl -wd4005 -wd4100 -wd4238 -wd4910 -wd4996 -### -- %s 2>&1 | FileCheck -check-prefix=Wno %s
// Wno: "-cc1" // Wno: "-cc1"
// Wno: "-Wno-macro-redefined" // Wno: "-Wno-macro-redefined"
// Wno: "-Wno-unused-parameter" // Wno: "-Wno-unused-parameter"
// Wno: "-Wno-address-of-temporary"
// Wno: "-Wno-dllexport-explicit-instantiation-decl" // Wno: "-Wno-dllexport-explicit-instantiation-decl"
// Wno: "-Wno-deprecated-declarations" // Wno: "-Wno-deprecated-declarations"
// Ignored options. Check that we don't get "unused during compilation" errors. // Ignored options. Check that we don't get "unused during compilation" errors.
// RUN: %clang_cl /c \ // RUN: %clang_cl /c \
// RUN: /analyze- \ // RUN: /analyze- \
// RUN: /bigobj \ // RUN: /bigobj \
// RUN: /cgthreads4 \ // RUN: /cgthreads4 \
▲ Show 20 Lines • Show All 350 Lines • Show Last 20 Lines