This is an archive of the discontinued LLVM Phabricator instance.

Differential D87275

[obj2yaml][test] Test generating and dumping a broken debug_ranges section.
ClosedPublic

Authored by Higuoxing on Sep 8 2020, 1:34 AM.

Details

Reviewers
jhenderson
grimar
MaskRay
Commits
rG4682f654031c: [obj2yaml][test] Test generating and dumping a broken debug_ranges section.
Summary

This patch tests generating and dumping a broken debug_ranges section.

Diff Detail

Event Timeline

Higuoxing created this revision.Sep 8 2020, 1:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 8 2020, 1:34 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Higuoxing requested review of this revision.Sep 8 2020, 1:34 AM
Higuoxing added a parent revision: D87263: [DWARFYAML] Make the debug_ranges section optional..Sep 8 2020, 1:34 AM
Harbormaster completed remote builds in B70913: Diff 290430.Sep 8 2020, 2:07 AM
jhenderson accepted this revision.Sep 8 2020, 2:33 AM

You should add a [test] tag to the patch/commit title. LGTM, with that and the inline nit.

llvm/test/ObjectYAML/MachO/DWARF-debug_ranges.yaml
288

You might want to reflow these lines too. They're all getting quite long.

This revision is now accepted and ready to land.Sep 8 2020, 2:33 AM
Higuoxing updated this revision to Diff 290447.Sep 8 2020, 4:07 AM
Higuoxing marked an inline comment as done.

Reflow comments.

Higuoxing retitled this revision from [obj2yaml] Test generating and dumping a broken debug_ranges section. to [obj2yaml][test] Test generating and dumping a broken debug_ranges section..Sep 8 2020, 4:07 AM
Harbormaster completed remote builds in B70920: Diff 290447.Sep 8 2020, 4:39 AM
Closed by commit rG4682f654031c: [obj2yaml][test] Test generating and dumping a broken debug_ranges section. (authored by Higuoxing). · Explain WhySep 8 2020, 5:49 PM
This revision was automatically updated to reflect the committed changes.
Higuoxing added a commit: rG4682f654031c: [obj2yaml][test] Test generating and dumping a broken debug_ranges section..

Revision Contents

PathSize
llvm/
test/
ObjectYAML/
MachO/
23 lines

Diff 290430

llvm/test/ObjectYAML/MachO/DWARF-debug_ranges.yaml

Show First 20 Lines • Show All 278 Lines • ▼ Show 20 Lines Sections:
align: 0 align: 0
reloff: 0x00000000 reloff: 0x00000000
nreloc: 0 nreloc: 0
flags: 0x00000000 flags: 0x00000000
reserved1: 0x00000000 reserved1: 0x00000000
reserved2: 0x00000000 reserved2: 0x00000000
reserved3: 0x00000000 reserved3: 0x00000000
content: [[CONTENT=<none>]] content: [[CONTENT=<none>]]
## Test generating and dumping a __debug_ranges section whose size isn't a multiple of address size.
jhendersonUnsubmitted
Done
ReplyInline Actions
content: [[CONTENT=<none>]]
- ## Test generating and dumping a __debug_ranges section whose size isn't a multiple of address size.
+ ## Test generating and dumping a __debug_ranges section whose size isn't a multiple of the address size.
## This test case is to ensure that when the parser fails, the content of the __debug_ranges section

You might want to reflow these lines too. They're all getting quite long.

jhenderson: You might want to reflow these lines too. They're all getting quite long.
## This test case is to ensure that when the parser fails, the content of the __debug_ranges section
## will be dumped into the 'content' entry and the 'debug_ranges' entry will not exist.
# RUN: yaml2obj --docnum=2 -DSIZE=3 -DCONTENT='010203' %s | obj2yaml | FileCheck %s --check-prefix=FAILS
# FAILS-NOT: DWARF:
# FAILS: Sections:
# FAILS-NEXT: - sectname: __debug_ranges
# FAILS-NEXT: segname: __DWARF
# FAILS-NEXT: addr: 0x0000000000000000
# FAILS-NEXT: size: 3
# FAILS-NEXT: offset: 0x00000210
# FAILS-NEXT: align: 0
# FAILS-NEXT: reloff: 0x00000000
# FAILS-NEXT: nreloc: 0
# FAILS-NEXT: flags: 0x00000000
# FAILS-NEXT: reserved1: 0x00000000
# FAILS-NEXT: reserved2: 0x00000000
# FAILS-NEXT: reserved3: 0x00000000
# FAILS-NEXT: content: '010203'
# FAILS-NEXT: ...