Page MenuHomePhabricator

[obj2yaml][test] Test generating and dumping a broken debug_ranges section.
ClosedPublic

Authored by Higuoxing on Sep 8 2020, 1:34 AM.

Details

Summary

This patch tests generating and dumping a broken debug_ranges section.

Diff Detail

Event Timeline

Higuoxing created this revision.Sep 8 2020, 1:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 8 2020, 1:34 AM
Higuoxing requested review of this revision.Sep 8 2020, 1:34 AM
jhenderson accepted this revision.Sep 8 2020, 2:33 AM

You should add a [test] tag to the patch/commit title. LGTM, with that and the inline nit.

llvm/test/ObjectYAML/MachO/DWARF-debug_ranges.yaml
288

You might want to reflow these lines too. They're all getting quite long.

This revision is now accepted and ready to land.Sep 8 2020, 2:33 AM
Higuoxing updated this revision to Diff 290447.Sep 8 2020, 4:07 AM
Higuoxing marked an inline comment as done.

Reflow comments.

Higuoxing retitled this revision from [obj2yaml] Test generating and dumping a broken debug_ranges section. to [obj2yaml][test] Test generating and dumping a broken debug_ranges section..Sep 8 2020, 4:07 AM