Page MenuHomePhabricator

[Attributor] Re-enable a run line in noalias.ll
AcceptedPublic

Authored by jdoerfert on Sep 7 2020, 9:42 PM.

Details

Summary

This was disabled as we were looking for a weird CGSCC problem. I
think/hope we fixed it as there were a lot of updates recently. I could
never reproduce this locally so I'll use the pre-commit phab builds to
confirm this suspicion and if they seem to be happy I'll assume this is
fixed.

Diff Detail

Event Timeline

jdoerfert created this revision.Sep 7 2020, 9:42 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: okura, kuter, bollu. · View Herald Transcript
jdoerfert requested review of this revision.Sep 7 2020, 9:42 PM

I remember this being windows only issue. I was able to always reproduce it on windows, but never had the chance to look into it.

Pre-merge checks seem green, but I see no mention of windows build and tests. Maybe I'm looking at the wrong place, or it hasn't started them yet.

I can try to reproduce it locally again.

sstefan1 accepted this revision.Sep 7 2020, 11:56 PM

Actually windows tests passed, I was looking at the wrong place.

LGTM

This revision is now accepted and ready to land.Sep 7 2020, 11:56 PM
This revision was automatically updated to reflect the committed changes.
jdoerfert reopened this revision.Sep 9 2020, 8:48 AM

This broke the windows bot, I'm pushing the revert as soon as my tests come back.

http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/25479/steps/test-check-all/logs/FAIL%3A%20LLVM%3A%3Anoalias.ll
This revision is now accepted and ready to land.Sep 9 2020, 8:48 AM

Looks same as the failures before. I may be able to do a windows build next week and try to see what is going on.