Page MenuHomePhabricator

[Inliner] Preserve maynotprogress function attribute
AbandonedPublic

Authored by atmnpatel on Sep 4 2020, 10:12 PM.

Details

Reviewers
jdoerfert
hfinkel
Summary

When inlining a function with the maynotprogress function attribute,
semantically, the caller function must also inherit the maynotprogress
attribute.

Diff Detail

Event Timeline

atmnpatel created this revision.Sep 4 2020, 10:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 4 2020, 10:12 PM
atmnpatel requested review of this revision.Sep 4 2020, 10:12 PM
atmnpatel added a comment.EditedSep 13 2020, 3:54 PM

On second thought, we don't need this for mustprogress. If the callee is` mustprogress`, the caller cannot become mustprogress as well without changing program behavior as a result of inlining.

nikic added a subscriber: nikic.Sep 25 2020, 12:39 PM

Abandon this as no longer necessary for mustprogress?

Yep I wasn't entirely sure before but I am now.

atmnpatel abandoned this revision.Sep 25 2020, 12:41 PM