Page MenuHomePhabricator

atmnpatel (Atmn Patel)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 12 2020, 7:33 AM (42 w, 17 h)

Recent Activity

Mon, Nov 30

atmnpatel added inline comments to D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops.
Mon, Nov 30, 3:05 AM · Restricted Project, Restricted Project

Sun, Nov 29

atmnpatel requested review of D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops.
Sun, Nov 29, 5:30 PM · Restricted Project, Restricted Project
atmnpatel updated the diff for D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops.

I believe this happened becase when I removed the loop, I did not update MemorySSA. The exact error was from GVN, but this update seems to fix the stage 2 build compile time error locally (I checked by running the build bot script).

Sun, Nov 29, 5:29 PM · Restricted Project, Restricted Project
atmnpatel reopened D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops.

This introduced a compile-time error that showed up during a stage 2 build.

Sun, Nov 29, 5:29 PM · Restricted Project, Restricted Project

Mon, Nov 9

atmnpatel committed rGfd3cad7a6016: [clang] Fix ForStmt mustprogress handling (authored by atmnpatel).
[clang] Fix ForStmt mustprogress handling
Mon, Nov 9, 8:38 AM
atmnpatel closed D91075: [clang] Fix ForStmt mustprogress handling.
Mon, Nov 9, 8:38 AM · Restricted Project
atmnpatel requested review of D91075: [clang] Fix ForStmt mustprogress handling.
Mon, Nov 9, 6:29 AM · Restricted Project

Fri, Nov 6

atmnpatel added a comment to rG04a08964879f: Revert "[LoopDeletion] Allows deletion of possibly infinite side-effect free….

I'm so sorry, I saw that you fixed it, thank you.

Fri, Nov 6, 9:59 PM
atmnpatel added a comment to rG04a08964879f: Revert "[LoopDeletion] Allows deletion of possibly infinite side-effect free….

I naively assumed that reverting it would be fine, I'm working on a fixing right now.

Fri, Nov 6, 9:58 PM
atmnpatel added inline comments to rGb1878b4641e0: [CodeGen] Fixes sanitizer test.
Fri, Nov 6, 9:35 PM
atmnpatel added a reverting change for rG0b17c6e4479d: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops: rG04a08964879f: Revert "[LoopDeletion] Allows deletion of possibly infinite side-effect free….
Fri, Nov 6, 9:32 PM
atmnpatel committed rG04a08964879f: Revert "[LoopDeletion] Allows deletion of possibly infinite side-effect free… (authored by atmnpatel).
Revert "[LoopDeletion] Allows deletion of possibly infinite side-effect free…
Fri, Nov 6, 9:32 PM
atmnpatel added a reverting change for rGb1878b4641e0: [CodeGen] Fixes sanitizer test: rGd3e75d31e3c8: Revert "[CodeGen] Fixes sanitizer test".
Fri, Nov 6, 9:32 PM
atmnpatel added a reverting change for D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops: rG04a08964879f: Revert "[LoopDeletion] Allows deletion of possibly infinite side-effect free….
Fri, Nov 6, 9:32 PM · Restricted Project, Restricted Project
atmnpatel committed rGd3e75d31e3c8: Revert "[CodeGen] Fixes sanitizer test" (authored by atmnpatel).
Revert "[CodeGen] Fixes sanitizer test"
Fri, Nov 6, 9:32 PM
atmnpatel committed rGb1878b4641e0: [CodeGen] Fixes sanitizer test (authored by atmnpatel).
[CodeGen] Fixes sanitizer test
Fri, Nov 6, 8:54 PM
atmnpatel committed rG569abb530ece: [LoopDeletion] Fixes failing test (authored by atmnpatel).
[LoopDeletion] Fixes failing test
Fri, Nov 6, 7:46 PM
atmnpatel committed rG0b17c6e4479d: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops (authored by atmnpatel).
[LoopDeletion] Allows deletion of possibly infinite side-effect free loops
Fri, Nov 6, 7:07 PM
atmnpatel closed D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops.
Fri, Nov 6, 7:07 PM · Restricted Project, Restricted Project
atmnpatel updated the diff for D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops.

final fixes.

Fri, Nov 6, 5:29 PM · Restricted Project, Restricted Project
atmnpatel committed rG46a29e9c6e7f: [Inliner] Handle `mustprogress` functions (authored by atmnpatel).
[Inliner] Handle `mustprogress` functions
Fri, Nov 6, 5:04 PM
atmnpatel closed D87262: [Inliner] Handle `mustprogress` functions.
Fri, Nov 6, 5:04 PM · Restricted Project
atmnpatel committed rGbabc224c5d74: [LoopDeletion] Remove dead loops with no exit blocks (authored by atmnpatel).
[LoopDeletion] Remove dead loops with no exit blocks
Fri, Nov 6, 2:09 PM
atmnpatel closed D90115: [LoopDeletion] Remove dead loops with no exit blocks.
Fri, Nov 6, 2:09 PM · Restricted Project
atmnpatel updated the diff for D90115: [LoopDeletion] Remove dead loops with no exit blocks.
  • Fixed failing test
Fri, Nov 6, 12:20 PM · Restricted Project

Thu, Nov 5

atmnpatel updated the diff for D87262: [Inliner] Handle `mustprogress` functions.

Rebase

Thu, Nov 5, 9:11 PM · Restricted Project
atmnpatel updated the diff for D90115: [LoopDeletion] Remove dead loops with no exit blocks.

removed non-parent revision.

Thu, Nov 5, 9:03 PM · Restricted Project
atmnpatel updated the diff for D90115: [LoopDeletion] Remove dead loops with no exit blocks.

using buildkite recommended fix

Thu, Nov 5, 8:55 PM · Restricted Project
atmnpatel updated the diff for D90115: [LoopDeletion] Remove dead loops with no exit blocks.
  • Addressed nits
  • Rebase
  • Final Pre-commit testing
Thu, Nov 5, 8:46 PM · Restricted Project

Wed, Nov 4

atmnpatel committed rGcea0599aa75b: [LangRef] Adds llvm.loop.mustprogress loop metadata (authored by atmnpatel).
[LangRef] Adds llvm.loop.mustprogress loop metadata
Wed, Nov 4, 7:33 PM
atmnpatel closed D88464: [LangRef] Adds llvm.loop.mustprogress loop metadata.
Wed, Nov 4, 7:33 PM · Restricted Project
atmnpatel committed rGac73b73c1652: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction (authored by atmnpatel).
[clang] Add mustprogress and llvm.loop.mustprogress attribute deduction
Wed, Nov 4, 7:03 PM
atmnpatel closed D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction.
Wed, Nov 4, 7:03 PM · Restricted Project

Tue, Nov 3

atmnpatel updated the diff for D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction.

Hopefully the unrelated hwasan test failure is now fixed on master, trying again.

Tue, Nov 3, 10:04 AM · Restricted Project

Nov 2 2020

atmnpatel updated the diff for D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction.

try 2.

Nov 2 2020, 10:02 PM · Restricted Project
atmnpatel updated the diff for D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction.

ignore, testing pre-build bots again.

Nov 2 2020, 9:51 PM · Restricted Project
atmnpatel updated the diff for D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction.

Rebase.

Nov 2 2020, 9:49 PM · Restricted Project
atmnpatel committed rGa95b25b29ecf: [Libomptarget][NFC] Move global Libomptarget state to a struct (authored by atmnpatel).
[Libomptarget][NFC] Move global Libomptarget state to a struct
Nov 2 2020, 9:12 PM
atmnpatel closed D90519: [Libomptarget][NFC] Move global Libomptarget state to a struct.
Nov 2 2020, 9:12 PM · Restricted Project
atmnpatel updated the diff for D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction.
  • Added triple to fix mangling errors in test
  • Modified (unrelated) recently added test to have the mustprogress attribute
Nov 2 2020, 2:21 PM · Restricted Project
atmnpatel updated the diff for D90519: [Libomptarget][NFC] Move global Libomptarget state to a struct.
  • Updated title, revision summary, and commit message
  • Added documentation for struct and members
Nov 2 2020, 1:02 PM · Restricted Project
atmnpatel retitled D90519: [Libomptarget][NFC] Move global Libomptarget state to a struct from [Libomptarget][NFC] Encapsulate Global Libomptarget State to [Libomptarget][NFC] Move global Libomptarget state to a struct.
Nov 2 2020, 12:59 PM · Restricted Project
atmnpatel committed rGeed8df6a1314: [Coroutines][Docs] Remove frame packing as a TODO (authored by atmnpatel).
[Coroutines][Docs] Remove frame packing as a TODO
Nov 2 2020, 12:57 PM
atmnpatel closed D90550: [Coroutines][Docs] Remove frame packing as a TODO.
Nov 2 2020, 12:57 PM · Restricted Project

Nov 1 2020

atmnpatel requested review of D90550: [Coroutines][Docs] Remove frame packing as a TODO.
Nov 1 2020, 3:52 AM · Restricted Project

Oct 30 2020

atmnpatel requested review of D90519: [Libomptarget][NFC] Move global Libomptarget state to a struct.
Oct 30 2020, 9:12 PM · Restricted Project

Oct 29 2020

atmnpatel abandoned D89654: [WIP][libomptarget][NFC] Refactor Libomptarget functionality into a class.

Thank you for the comments. I think I follow, I'll post another less intrusive patch soon.

Oct 29 2020, 8:22 PM · Restricted Project

Oct 25 2020

atmnpatel updated the diff for D90115: [LoopDeletion] Remove dead loops with no exit blocks.

Update comments.

Oct 25 2020, 5:36 PM · Restricted Project
atmnpatel updated the diff for D90115: [LoopDeletion] Remove dead loops with no exit blocks.
  • Adds test.
  • Uses getExitBlocks() instead of getUniqueExitBlocks() and moved definition.
  • Changed definition of hasNoExitBlocks() to use empty() instead of conditional
  • Style changes in deleteDeadLoop for readibility.
Oct 25 2020, 5:34 PM · Restricted Project
atmnpatel updated the diff for D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops.

Added word back in.

Oct 25 2020, 3:26 PM · Restricted Project, Restricted Project
atmnpatel updated the diff for D90115: [LoopDeletion] Remove dead loops with no exit blocks.

Add parent revision for buildkite.

Oct 25 2020, 2:22 AM · Restricted Project
atmnpatel requested review of D90115: [LoopDeletion] Remove dead loops with no exit blocks.
Oct 25 2020, 2:21 AM · Restricted Project

Oct 21 2020

atmnpatel added a comment to D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction.

ping. @jyknight @aaron.ballman @rjmccall any more thoughts?

Oct 21 2020, 5:03 PM · Restricted Project
atmnpatel updated the diff for D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction.

rebase.

Oct 21 2020, 4:43 PM · Restricted Project

Oct 20 2020

atmnpatel committed rG595c61560684: [IR] Adds mustprogress as a LLVM IR attribute (authored by adpatel6).
[IR] Adds mustprogress as a LLVM IR attribute
Oct 20 2020, 12:10 AM
atmnpatel closed D85393: [IR] Adds mustprogress as a LLVM IR attribute.
Oct 20 2020, 12:10 AM · Restricted Project

Oct 19 2020

atmnpatel updated the diff for D87975: [IR] MaxObjSize Attribute.

Sorry, I understand now. Is this more correct?

Oct 19 2020, 2:28 PM · Restricted Project
atmnpatel committed rG1e55cf77f389: [LangRef] Define mustprogress attribute (authored by adpatel6).
[LangRef] Define mustprogress attribute
Oct 19 2020, 10:36 AM
atmnpatel closed D86233: [LangRef] Define mustprogress attribute.
Oct 19 2020, 10:35 AM · Restricted Project

Oct 18 2020

atmnpatel requested review of D89654: [WIP][libomptarget][NFC] Refactor Libomptarget functionality into a class.
Oct 18 2020, 11:54 AM · Restricted Project

Oct 16 2020

atmnpatel updated the diff for D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops.

fixed splice.

Oct 16 2020, 1:22 PM · Restricted Project, Restricted Project
atmnpatel updated the diff for D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops.
Oct 16 2020, 1:15 PM · Restricted Project, Restricted Project
atmnpatel updated the diff for D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops.

Reverted to prior diff.

Oct 16 2020, 1:13 PM · Restricted Project, Restricted Project

Oct 14 2020

atmnpatel added a comment to D88353: [BasicAA] Integrate MaxObjSize for NoAlias.

I think that phrase ("w/o maxobjsize deduction") could be a bit misleading, IINM, when @jdoerfert says w/o maxobjsize deduction he means without having the functionality built into the attributor to update the maximum object size estimate. So in the patch D87975, there's a crude over-approximation for the maxobjsize (getPointerMaxObjSize) and the numbers are for just using that over-approximation without including the changes in D87978 that refine it, so we would still need the maxobjsize attribute first in order to do this.

Oct 14 2020, 12:15 PM · Restricted Project
atmnpatel added inline comments to D87975: [IR] MaxObjSize Attribute.
Oct 14 2020, 12:15 PM · Restricted Project

Oct 8 2020

atmnpatel updated the diff for D87262: [Inliner] Handle `mustprogress` functions.

Fixed nit.

Oct 8 2020, 6:25 PM · Restricted Project
atmnpatel abandoned D89089: [Inliner] Handle `mustprogress` functions.
Oct 8 2020, 6:24 PM · Restricted Project
atmnpatel requested review of D89089: [Inliner] Handle `mustprogress` functions.
Oct 8 2020, 6:24 PM · Restricted Project
atmnpatel updated the diff for D86233: [LangRef] Define mustprogress attribute.

Rebase to fix buildkite build.

Oct 8 2020, 5:48 PM · Restricted Project
atmnpatel updated the diff for D88464: [LangRef] Adds llvm.loop.mustprogress loop metadata.

Rebase.

Oct 8 2020, 5:47 PM · Restricted Project
atmnpatel updated the diff for D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction.

Fixes.

Oct 8 2020, 4:04 PM · Restricted Project
atmnpatel updated the diff for D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops.

Fixes.

Oct 8 2020, 4:02 PM · Restricted Project, Restricted Project

Oct 7 2020

atmnpatel planned changes to D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops.
Oct 7 2020, 11:30 AM · Restricted Project, Restricted Project
atmnpatel updated the diff for D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops.

Updates made to try to remove infinite loops with no exit edge. It seems to work with the new pass manager, but hopelessly breaks for the old pass manager, changes planned.

Oct 7 2020, 11:29 AM · Restricted Project, Restricted Project
atmnpatel updated the diff for D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction.

Bump for bot.

Oct 7 2020, 11:24 AM · Restricted Project
atmnpatel updated the diff for D86233: [LangRef] Define mustprogress attribute.

rebase.

Oct 7 2020, 11:23 AM · Restricted Project
atmnpatel updated the diff for D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction.

Fixes.

Oct 7 2020, 11:14 AM · Restricted Project
atmnpatel updated the diff for D87975: [IR] MaxObjSize Attribute.

nit fix.

Oct 7 2020, 10:17 AM · Restricted Project
atmnpatel updated the diff for D87975: [IR] MaxObjSize Attribute.

Rebase.

Oct 7 2020, 10:13 AM · Restricted Project
atmnpatel updated the diff for D87978: [Attributor] Adds deduction for the MaxObjSize Attribute.

Updates.

Oct 7 2020, 10:08 AM · Restricted Project

Sep 30 2020

atmnpatel added inline comments to D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction.
Sep 30 2020, 10:29 PM · Restricted Project
atmnpatel updated the diff for D86233: [LangRef] Define mustprogress attribute.

Updated to include syntax modifications in the llvm/utils

Sep 30 2020, 1:50 PM · Restricted Project
atmnpatel updated the diff for D88353: [BasicAA] Integrate MaxObjSize for NoAlias.

Fixed broken tests, think the changes make sense.

Sep 30 2020, 1:11 PM · Restricted Project
atmnpatel updated the diff for D87978: [Attributor] Adds deduction for the MaxObjSize Attribute.

Fixed broken test.

Sep 30 2020, 12:19 PM · Restricted Project
atmnpatel updated the diff for D88353: [BasicAA] Integrate MaxObjSize for NoAlias.

Added a specific basic-aa maxobjsize test.

Sep 30 2020, 9:47 AM · Restricted Project

Sep 29 2020

atmnpatel updated the diff for D87262: [Inliner] Handle `mustprogress` functions.

Updated commit message.

Sep 29 2020, 6:46 PM · Restricted Project
atmnpatel retitled D87262: [Inliner] Handle `mustprogress` functions from [Inliner] Apply llvm.loop.mustprogress to callee loops if callee is `mustprogress` to [Inliner] Handle `mustprogress` functions.
Sep 29 2020, 6:45 PM · Restricted Project
atmnpatel updated the diff for D87262: [Inliner] Handle `mustprogress` functions.

Inliner changes now that the clang implementation in D86841 has changed. Can I remove the inliner nested loops and multiple loops tests now? They're not as relevant anymore.

Sep 29 2020, 6:06 PM · Restricted Project
atmnpatel updated the diff for D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction.

Fixing buildkite build.

Sep 29 2020, 4:24 PM · Restricted Project
atmnpatel updated the diff for D85393: [IR] Adds mustprogress as a LLVM IR attribute.

Rebasing.

Sep 29 2020, 4:23 PM · Restricted Project
atmnpatel added inline comments to D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction.
Sep 29 2020, 4:19 PM · Restricted Project
atmnpatel updated the diff for D88464: [LangRef] Adds llvm.loop.mustprogress loop metadata.

buildkite fix.

Sep 29 2020, 4:18 PM · Restricted Project
atmnpatel updated the diff for D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops.

Fixes.

Sep 29 2020, 4:13 PM · Restricted Project, Restricted Project
atmnpatel added inline comments to D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops.
Sep 29 2020, 4:13 PM · Restricted Project, Restricted Project
atmnpatel updated the diff for D88464: [LangRef] Adds llvm.loop.mustprogress loop metadata.

Removed extra file.

Sep 29 2020, 3:33 PM · Restricted Project
atmnpatel updated the diff for D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction.

NFC fixes.

Sep 29 2020, 2:12 PM · Restricted Project
atmnpatel updated the diff for D87978: [Attributor] Adds deduction for the MaxObjSize Attribute.

changed stats trackers

Sep 29 2020, 11:58 AM · Restricted Project
atmnpatel updated the diff for D87978: [Attributor] Adds deduction for the MaxObjSize Attribute.

Rebase

Sep 29 2020, 11:49 AM · Restricted Project
atmnpatel updated the diff for D87978: [Attributor] Adds deduction for the MaxObjSize Attribute.

Fixes.

Sep 29 2020, 11:25 AM · Restricted Project
atmnpatel retitled D87978: [Attributor] Adds deduction for the MaxObjSize Attribute from [WIP][Attributor] Adds deduction for the MaxObjSize Attribute to [Attributor] Adds deduction for the MaxObjSize Attribute.
Sep 29 2020, 11:24 AM · Restricted Project