Page MenuHomePhabricator

atmnpatel (Atmn Patel)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 12 2020, 7:33 AM (14 w, 6 d)

Recent Activity

Yesterday

atmnpatel added a comment to D80057: [libc++][NFCI] Optimization to std::~unique_ptr.

I agree with @ldionne

Mon, May 25, 2:28 PM · Unknown Object (Project)

Fri, May 22

atmnpatel updated the diff for D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang.

Updated tests and includes changes made by @ABataev.

Fri, May 22, 12:52 PM · Restricted Project, Restricted Project

Thu, May 21

atmnpatel added a comment to D80057: [libc++][NFCI] Optimization to std::~unique_ptr.

@jfb I did a microbenchmark yesterday and the upside is very small and basically non-existent for slightly non-trivial classes. In fact, there is a performance regression for the case that @zoecarver made on compiler explorer of using moves. Furthermore, for simple unique pointers such as to int, it also leads to a performance regression (for reasons which are not entirely clear to me). I think it's best to table this until it can be concretely established that this does lead to a performance improvement.

Thu, May 21, 10:15 AM · Unknown Object (Project)

Sat, May 16

atmnpatel updated the diff for D80057: [libc++][NFCI] Optimization to std::~unique_ptr.

Aye aye.

Sat, May 16, 7:53 AM · Unknown Object (Project)

Fri, May 15

atmnpatel created D80057: [libc++][NFCI] Optimization to std::~unique_ptr.
Fri, May 15, 9:11 PM · Unknown Object (Project)
atmnpatel added inline comments to D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang.
Fri, May 15, 3:14 PM · Restricted Project, Restricted Project
atmnpatel updated the diff for D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang.

Necessary cleanups and adds a basic check for static local variables and static data members.

Fri, May 15, 3:14 PM · Restricted Project, Restricted Project

Wed, May 13

atmnpatel updated the diff for D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang.

Addresses inline comments.

Wed, May 13, 1:03 PM · Restricted Project, Restricted Project

Mon, May 11

atmnpatel updated the diff for D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang.

Fixed check for scalar types.

Mon, May 11, 6:23 PM · Restricted Project, Restricted Project
atmnpatel added a comment to D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang.

ping

Mon, May 11, 1:28 PM · Restricted Project, Restricted Project

Fri, May 1

atmnpatel added a comment to D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang.

ping

Fri, May 1, 5:10 PM · Restricted Project, Restricted Project

Apr 21 2020

atmnpatel added inline comments to D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang.
Apr 21 2020, 4:16 PM · Restricted Project, Restricted Project
atmnpatel added inline comments to D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang.
Apr 21 2020, 4:16 PM · Restricted Project, Restricted Project
atmnpatel updated the diff for D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang.

Add capture by value for scalars.

Apr 21 2020, 4:16 PM · Restricted Project, Restricted Project
atmnpatel added inline comments to D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang.
Apr 21 2020, 12:59 PM · Restricted Project, Restricted Project
atmnpatel added inline comments to D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang.
Apr 21 2020, 12:26 PM · Restricted Project, Restricted Project
atmnpatel updated the diff for D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang.

Addresses inline comments.

Apr 21 2020, 12:26 PM · Restricted Project, Restricted Project

Apr 8 2020

atmnpatel updated the diff for D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang.

Addresses D77731 and fixes the comment.

Apr 8 2020, 5:56 PM · Restricted Project, Restricted Project

Apr 3 2020

atmnpatel updated the diff for D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang.

Fixes clang-tidy check, and hopefully the other unrelated test failure too.

Apr 3 2020, 2:38 PM · Restricted Project, Restricted Project

Apr 1 2020

atmnpatel updated the diff for D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang.

Rebase.

Apr 1 2020, 7:04 PM · Restricted Project, Restricted Project
atmnpatel updated the diff for D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang.

Fixes to tests.

Apr 1 2020, 5:59 PM · Restricted Project, Restricted Project

Mar 29 2020

atmnpatel updated the diff for D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang.

Second try at generating a patch file.

Mar 29 2020, 11:01 PM · Restricted Project, Restricted Project
atmnpatel updated the diff for D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang.

Rebased.

Mar 29 2020, 7:15 PM · Restricted Project, Restricted Project
atmnpatel updated the diff for D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang.

Added error based on OpenMP version.

Mar 29 2020, 4:04 PM · Restricted Project, Restricted Project

Mar 28 2020

atmnpatel added a comment to D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang.

In D75591#1936152, @lebedev.ri wrote:
It should be handled consistently with how other newer openmp features are handled with older openmp version specified.

Mar 28 2020, 1:27 PM · Restricted Project, Restricted Project

Mar 21 2020

atmnpatel updated the diff for D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang.

Fixed linter error.

Mar 21 2020, 11:44 AM · Restricted Project, Restricted Project
atmnpatel updated the diff for D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang.

Comment fixes.

Mar 21 2020, 9:37 AM · Restricted Project, Restricted Project
atmnpatel added inline comments to D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang.
Mar 21 2020, 9:37 AM · Restricted Project, Restricted Project

Mar 14 2020

atmnpatel added inline comments to D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang.
Mar 14 2020, 7:53 PM · Restricted Project, Restricted Project

Mar 13 2020

atmnpatel added a comment to D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang.

Yep, it is still an open issue. I am actually unsure of how to do that, and I'd love some pointers.

Mar 13 2020, 4:45 PM · Restricted Project, Restricted Project
atmnpatel added a comment to D74997: [libc++] Bugfix to std::binomial_distribution<int>.

Better? Or did I misunderstand the request? The updated patch paragraph from the Code Reviews page seems to be primarily for changes in the content of the patch rather than changes in the commit message/context provided.

Mar 13 2020, 4:45 PM · Unknown Object (Project)
atmnpatel updated the summary of D74997: [libc++] Bugfix to std::binomial_distribution<int>.
Mar 13 2020, 4:44 PM · Unknown Object (Project)

Mar 11 2020

atmnpatel added a comment to D74997: [libc++] Bugfix to std::binomial_distribution<int>.

Sorry, I was transitioning between machines while updating the commit and I couldn't figure out arc diff - I'd like it to be committed under a335pate@uwaterloo.ca.

Mar 11 2020, 6:20 PM · Unknown Object (Project)
atmnpatel updated the diff for D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang.

Modified the unit test for CodeGen of default(firstprivate) to more accurately reflect the IR.

Mar 11 2020, 3:03 AM · Restricted Project, Restricted Project

Mar 4 2020

atmnpatel updated the diff for D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang.

Modifies clang-tidy to include the new clause, and changes the value of DSA_firstprivate.

Mar 4 2020, 2:05 PM · Restricted Project, Restricted Project

Mar 3 2020

atmnpatel updated the diff for D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang.

Fixes typos that causes certain unit tests to fail.

Mar 3 2020, 9:15 PM · Restricted Project, Restricted Project
atmnpatel created D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang.
Mar 3 2020, 8:09 PM · Restricted Project, Restricted Project

Feb 25 2020

atmnpatel updated the diff for D74997: [libc++] Bugfix to std::binomial_distribution<int>.

Yep, sorry I forgot to add it before. It's a bit of a wordy and entirely based on the bug report.

Feb 25 2020, 8:56 PM · Unknown Object (Project)

Feb 21 2020

atmnpatel created D74997: [libc++] Bugfix to std::binomial_distribution<int>.
Feb 21 2020, 4:02 PM · Unknown Object (Project)

Feb 13 2020

atmnpatel added a comment to D74513: [OpenMP][NFCI] Use the libFrontend DefaultKind in Clang.

I am unable to commit this myself, can someone commit for me?

Feb 13 2020, 10:43 AM · Restricted Project, Restricted Project

Feb 12 2020

atmnpatel updated the diff for D74513: [OpenMP][NFCI] Use the libFrontend DefaultKind in Clang.

Removes specified values in favor of defaults in the DefaultKind enum.

Feb 12 2020, 10:13 PM · Restricted Project, Restricted Project
atmnpatel created D74513: [OpenMP][NFCI] Use the libFrontend DefaultKind in Clang.
Feb 12 2020, 3:45 PM · Restricted Project, Restricted Project