This is an archive of the discontinued LLVM Phabricator instance.

Differential D87125

Update recipe for flang-aarch64 slaves
ClosedPublic

Authored by CarolineConcatto on Sep 4 2020, 12:16 AM.

Details

Reviewers
DavidTruby
sscalpone
gkistanova
Commits
rZORG965bd9eb785e: Update recipe for flang-aarch64 slaves
Summary
  • Update compiler location for flang-aarch64-ubuntu-{clang and gcc10}
  • Add another email to the extra recipient for flang-aarch64
  • Make flang-aarch64 slaves build new flang driver by default
  • Add a missing coma to flang-aarch64-ubuntu-gcc10 recipe

Diff Detail

Event Timeline

CarolineConcatto created this revision.Sep 4 2020, 12:16 AM
Herald added a reviewer: DavidTruby. · View Herald TranscriptSep 4 2020, 12:16 AM
Herald added a reviewer: sscalpone. · View Herald Transcript
Herald added a reviewer: gkistanova. · View Herald Transcript
Herald added subscribers: danielkiss, kristof.beyls. · View Herald Transcript
Harbormaster completed remote builds in B70623: Diff 289873.Sep 4 2020, 12:16 AM
CarolineConcatto requested review of this revision.Sep 4 2020, 12:16 AM
CarolineConcatto updated this revision to Diff 289875.Sep 4 2020, 12:19 AM

-correct mail for flang

Harbormaster completed remote builds in B70624: Diff 289875.Sep 4 2020, 12:19 AM
DavidTruby accepted this revision.Sep 7 2020, 6:38 AM

LGTM

This revision is now accepted and ready to land.Sep 7 2020, 6:38 AM
CarolineConcatto added a comment.Sep 9 2020, 1:21 AM

@gkistanova is it fine for me to push?

CarolineConcatto updated this revision to Diff 290719.Sep 9 2020, 5:43 AM

Add the build of the new driver as default for flang-aarch64 slaves

Harbormaster completed remote builds in B71081: Diff 290719.Sep 9 2020, 5:43 AM
gkistanova requested changes to this revision.Sep 10 2020, 8:29 PM

Hi Caroline,

This patch contains changes not related to adding extra recipient mail for flang-aarch64.
Could you either change the description, so it would be accurate, or split the patch, please?

This revision now requires changes to proceed.Sep 10 2020, 8:29 PM
CarolineConcatto retitled this revision from Add extra recipient mail for flang-aarch64 slaves to Update recipe for flang-aarch64 slaves.Sep 10 2020, 11:40 PM
CarolineConcatto edited the summary of this revision. (Show Details)

Thank you @gkistanova, I did miss that.
It was updated on my local repo, but not in here.

CarolineConcatto updated this revision to Diff 293021.Sep 20 2020, 10:11 AM
CarolineConcatto retitled this revision from Update recipe for flang-aarch64 slaves to Update recipe for flang-aarch64 slaves.

Update compile location for flang-aarch64-ubuntu{clang and gcc10}

Harbormaster completed remote builds in B72311: Diff 293021.Sep 20 2020, 10:11 AM
CarolineConcatto edited the summary of this revision. (Show Details)Sep 20 2020, 10:12 AM
CarolineConcatto added a comment.Sep 21 2020, 6:37 AM

@gkistanova is now fine?

gkistanova accepted this revision.Sep 21 2020, 10:02 PM

LGTM

This revision is now accepted and ready to land.Sep 21 2020, 10:02 PM
Closed by commit rZORG965bd9eb785e: Update recipe for flang-aarch64 slaves (authored by CarolineConcatto). · Explain WhySep 21 2020, 11:55 PM
This revision was automatically updated to reflect the committed changes.
CarolineConcatto added a commit: rZORG965bd9eb785e: Update recipe for flang-aarch64 slaves.

Revision Contents

PathSize
buildbot/
osuosl/
master/
config/
5 lines
3 lines

Diff 290719

buildbot/osuosl/master/config/builders.py

Show First 20 Lines • Show All 1,543 Lines • ▼ Show 20 Lines return [
'factory': UnifiedTreeBuilder.getCmakeWithNinjaBuildFactory( 'factory': UnifiedTreeBuilder.getCmakeWithNinjaBuildFactory(
clean=True, clean=True,
depends_on_projects=['llvm','mlir','clang','flang'], depends_on_projects=['llvm','mlir','clang','flang'],
extra_configure_args=[ extra_configure_args=[
"-DLLVM_TARGETS_TO_BUILD=AArch64", "-DLLVM_TARGETS_TO_BUILD=AArch64",
"-DCMAKE_C_COMPILER=/usr/bin/gcc-9", "-DCMAKE_C_COMPILER=/usr/bin/gcc-9",
"-DCMAKE_CXX_COMPILER=/usr/bin/g++-9", "-DCMAKE_CXX_COMPILER=/usr/bin/g++-9",
"-DLLVM_INSTALL_UTILS=ON", "-DLLVM_INSTALL_UTILS=ON",
"-DFLANG_BUILD_NEW_DRIVER=ON",
"-DCMAKE_CXX_STANDARD=17", "-DCMAKE_CXX_STANDARD=17",
], ],
), ),
'category' : 'flang'}, 'category' : 'flang'},
{'name': "flang-aarch64-ubuntu-clang", {'name': "flang-aarch64-ubuntu-clang",
'slavenames':["flang-aarch64-ubuntu-clang-build"], 'slavenames':["flang-aarch64-ubuntu-clang-build"],
'builddir':"flang-aarch64-ubuntu-clang", 'builddir':"flang-aarch64-ubuntu-clang",
'factory': UnifiedTreeBuilder.getCmakeWithNinjaBuildFactory( 'factory': UnifiedTreeBuilder.getCmakeWithNinjaBuildFactory(
clean=True, clean=True,
depends_on_projects=['llvm','mlir','clang','flang'], depends_on_projects=['llvm','mlir','clang','flang'],
extra_configure_args=[ extra_configure_args=[
"-DLLVM_TARGETS_TO_BUILD=AArch64", "-DLLVM_TARGETS_TO_BUILD=AArch64",
"-DCMAKE_C_COMPILER=/usr/local/bin/clang", "-DCMAKE_C_COMPILER=/usr/local/bin/clang",
"-DCMAKE_CXX_COMPILER=/usr/local/bin/clang++", "-DCMAKE_CXX_COMPILER=/usr/local/bin/clang++",
"-DLLVM_INSTALL_UTILS=ON", "-DLLVM_INSTALL_UTILS=ON",
"-DCMAKE_CXX_STANDARD=17", "-DCMAKE_CXX_STANDARD=17",
"-DLLVM_ENABLE_WERROR=ON", "-DLLVM_ENABLE_WERROR=ON",
"-DBUILD_SHARED_LIBS=ON", "-DBUILD_SHARED_LIBS=ON",
"-DLLVM_ENABLE_ASSERTIONS=ON", "-DLLVM_ENABLE_ASSERTIONS=ON",
"-DLLVM_ENABLE_LIBCXX=On", "-DLLVM_ENABLE_LIBCXX=On",
"-DFLANG_BUILD_NEW_DRIVER=ON",
"-DCMAKE_BUILD_TYPE=Release", "-DCMAKE_BUILD_TYPE=Release",
], ],
), ),
'category' : 'flang'}, 'category' : 'flang'},
{'name': "flang-aarch64-ubuntu-gcc10", {'name': "flang-aarch64-ubuntu-gcc10",
'slavenames':["flang-aarch64-ubuntu-gcc10-build"], 'slavenames':["flang-aarch64-ubuntu-gcc10-build"],
'builddir':"flang-aarch64-ubuntu-gcc10", 'builddir':"flang-aarch64-ubuntu-gcc10",
'factory': UnifiedTreeBuilder.getCmakeWithNinjaBuildFactory( 'factory': UnifiedTreeBuilder.getCmakeWithNinjaBuildFactory(
clean=True, clean=True,
depends_on_projects=['llvm','mlir','clang','flang'], depends_on_projects=['llvm','mlir','clang','flang'],
extra_configure_args=[ extra_configure_args=[
"-DLLVM_TARGETS_TO_BUILD=AArch64", "-DLLVM_TARGETS_TO_BUILD=AArch64",
"-DCMAKE_C_COMPILER=/usr/local/bin/gcc-10", "-DCMAKE_C_COMPILER=/usr/local/bin/gcc-10",
"-DCMAKE_CXX_COMPILER=/usr/local/bin/g++-10", "-DCMAKE_CXX_COMPILER=/usr/local/bin/g++-10",
"-DLLVM_INSTALL_UTILS=ON", "-DLLVM_INSTALL_UTILS=ON",
"-DCMAKE_CXX_STANDARD=17", "-DCMAKE_CXX_STANDARD=17",
"-DLLVM_ENABLE_WERROR=OFF", "-DLLVM_ENABLE_WERROR=OFF",
"-DFLANG_ENABLE_WERROR=ON" "-DFLANG_ENABLE_WERROR=ON",
"-DBUILD_SHARED_LIBS=ON", "-DBUILD_SHARED_LIBS=ON",
"-DLLVM_ENABLE_ASSERTIONS=ON", "-DLLVM_ENABLE_ASSERTIONS=ON",
"-DFLANG_BUILD_NEW_DRIVER=ON",
"-DCMAKE_BUILD_TYPE=Release", "-DCMAKE_BUILD_TYPE=Release",
], ],
), ),
'category' : 'flang'}, 'category' : 'flang'},
{'name': "flang-x86_64-linux", {'name': "flang-x86_64-linux",
'slavenames':["nersc-flang"], 'slavenames':["nersc-flang"],
'builddir':"flang-x86_64-linux", 'builddir':"flang-x86_64-linux",
▲ Show 20 Lines • Show All 260 Lines • Show Last 20 Lines

buildbot/osuosl/master/config/status.py

Show First 20 Lines • Show All 285 Lines • ▼ Show 20 Lines return [
subject="ML Compiler Opt Failure: %(builder)s", subject="ML Compiler Opt Failure: %(builder)s",
mode="failing", mode="failing",
builders=[ builders=[
"ml-opt-dev-x86-64", "ml-opt-rel-x86-64", "ml-opt-devrel-x86-64"], "ml-opt-dev-x86-64", "ml-opt-rel-x86-64", "ml-opt-devrel-x86-64"],
addLogs=False), addLogs=False),
InformativeMailNotifier( InformativeMailNotifier(
fromaddr = "llvm.buildmaster@lab.llvm.org", fromaddr = "llvm.buildmaster@lab.llvm.org",
sendToInterestedUsers = False, sendToInterestedUsers = False,
extraRecipients = ["caroline.concatto@arm.com"], extraRecipients = [
"caroline.concatto@arm.com", "flang_llvm_buildbots@arm.com"],
subject="Build %(builder)s Failure", subject="Build %(builder)s Failure",
mode = "failing", mode = "failing",
builders = [ builders = [
"flang-aarch64-ubuntu", "flang-aarch64-ubuntu-clang", "flang-aarch64-ubuntu", "flang-aarch64-ubuntu-clang",
"flang-aarch64-ubuntu-gcc10"], "flang-aarch64-ubuntu-gcc10"],
addLogs=False, addLogs=False,
num_lines = 15), num_lines = 15),
] ]