[llvm-symbolizer] Add back --use-symbol-table=true

[MaskRay]

Summary

It is used by clusterfuzz (https://github.com/google/clusterfuzz/pull/2009/)
and having this compatibility option for a while can help they do bisection
with the latest llvm-symbolizer.

[MaskRay]

Add a test

[MaskRay]

llvm/test/tools/llvm-symbolizer/use-symbol-table.s

7

Cc @srhines: ndk-stack.py should probably remove --use-symbol-table=true

[jhenderson]

LGTM. Maybe the test name should be use-symbol-table-true.s? Do you plan to add more --use-symbol-table tests (there are currently no others)?

[jhenderson]

In D87067#2254053, @jhenderson wrote:

Do you plan to add more --use-symbol-table tests (there are currently no others)?

Never mind this question - I hadn't registered that the option was missing completely. Did --use-symbol-table=false (or some equivalent option) previously do something? If so, wemight want to add it back (with testing), as my understanding is that you didn't remove it deliberately.

[MaskRay]

In D87067#2254066, @jhenderson wrote:

In D87067#2254053, @jhenderson wrote:

Do you plan to add more --use-symbol-table tests (there are currently no others)?

Never mind this question - I hadn't registered that the option was missing completely. Did --use-symbol-table=false (or some equivalent option) previously do something? If so, wemight want to add it back (with testing), as my understanding is that you didn't remove it deliberately.

--use-symbol-table=false did something previously but I cannot find it in code search. --use-symbol-table=true was a strange option name but was used previously by asan_symbolize.py (in llvm-project) and elsewhere (I don't know why they used it). --use-symbol-table can override function names with .symtab information, which supposedly has at least some debugging meanings. We can bring it back when proper tests are added.

[srhines]

llvm/test/tools/llvm-symbolizer/use-symbol-table.s

7

https://android-review.googlesource.com/c/platform/ndk/+/1419436 should remove this unnecessary option. Thanks for the heads up.

[Dor1s]

LGTM, thanks for adding this back!

llvm/test/tools/llvm-symbolizer/use-symbol-table.s

+# REQUIRES: x86-registered-target
+
+# RUN: llvm-mc -filetype=obj -triple=x86_64 -g %s -o %t.o
+
+## --use-symbol-table=true is used by old asan_symbolize.py and Android ndk
+## ndk-stack.py. Keep it as a no-op compatibility option for a while.
+# RUN: llvm-symbolizer --use-symbol-table=true %t.o

llvm/tools/llvm-symbolizer/Opts.td

 def : Flag<["-"], "v">, Alias<version>, HelpText<"Alias for --version">;
 
 // Compatibility aliases for old asan_symbolize.py and sanitizer binaries (before 2020-08).
 def : Flag<["--"], "inlining=true">, Alias<inlines>, HelpText<"Alias for --inlines">;
 def : Flag<["--"], "inlining=false">, Alias<no_inlines>, HelpText<"Alias for --no-inlines">;
 // Compatibility aliases for pprof's symbolizer.
 def : Flag<["-"], "demangle=true">, Alias<demangle>, HelpText<"Alias for --demangle">;
 def : Flag<["-"], "demangle=false">, Alias<no_demangle>, HelpText<"Alias for --no-demangle">;
+// Compatibility no-op options.
+def : Flag<["--"], "use-symbol-table=true">;