Page MenuHomePhabricator

[early-ifcvt] Add OptRemarks
ClosedPublic

Authored by jroelofs on Aug 28 2020, 10:26 AM.

Details

Reviewers
fhahn
thegameg

Diff Detail

Event Timeline

jroelofs created this revision.Aug 28 2020, 10:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 28 2020, 10:26 AM
jroelofs requested review of this revision.Aug 28 2020, 10:26 AM
thegameg accepted this revision.Aug 28 2020, 11:55 AM

This looks great, thanks! Since it's a CodeGen pass, I would suggest using a MIR test instead of an IR one, but I think it's probably easier to read it as it is right now.

This revision is now accepted and ready to land.Aug 28 2020, 11:55 AM

This looks great, thanks! Since it's a CodeGen pass, I would suggest using a MIR test instead of an IR one, but I think it's probably easier to read it as it is right now.

Good call. As-is, this is probably more sensitive to changes in the passes that happen before early-ifcvt than it should be. Making it a MIR test should tighten that up a bit.

jroelofs updated this revision to Diff 288706.Aug 28 2020, 2:27 PM

I'm having trouble getting -stop-before MIR output to trigger these remarks when fed back into llc, so instead I've just relaxed the checks against specific cycle counts to be more forgiving.