Page MenuHomePhabricator

[ARM]{MVE] Enable MVE gathers and scatters by default

Authored by anwel on Aug 28 2020, 4:52 AM.



This patch enables MVE gather/scatters by default.
The respective command line argument can then be removed from all tests for gather/scatters, and a few other tests have to be adapted.

Diff Detail

Event Timeline

anwel created this revision.Aug 28 2020, 4:52 AM
anwel requested review of this revision.Aug 28 2020, 4:52 AM

Before we flip the switch, can you give an impression of the performance impact of this? Does this not regress cases, is it overall a win, etc.?

dmgreen accepted this revision.Aug 28 2020, 8:13 AM

I asked Anna to put this patch together so that we had it when we needed it. I've been testing things out and I don't see any real reason not to go for it now though. Performance looks OK, if a bit conservative now that we have the higher costs. And I've not found any correctness issues. I've been trying any code I can find with a forced vector user cost and not run into any problems.

I think this is good to go.

LGTM. Thanks!

This revision is now accepted and ready to land.Aug 28 2020, 8:13 AM
This revision was automatically updated to reflect the committed changes.