Page MenuHomePhabricator

anwel (Anna Welker)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 11 2019, 1:25 AM (15 w, 14 h)

Recent Activity

Tue, Jan 21

anwel committed rGff9877ce34b8: [ARM][MVE] Enable masked scatter (authored by anwel).
[ARM][MVE] Enable masked scatter
Tue, Jan 21, 1:53 AM
anwel closed D72856: [ARM][MVE] Enable masked scatter.
Tue, Jan 21, 1:53 AM · Restricted Project

Mon, Jan 20

anwel updated the diff for D72856: [ARM][MVE] Enable masked scatter.
Mon, Jan 20, 8:53 AM · Restricted Project
anwel added inline comments to D72856: [ARM][MVE] Enable masked scatter.
Mon, Jan 20, 8:52 AM · Restricted Project
anwel added inline comments to D73021: [ARM] Basic gather scatter cost model.
Mon, Jan 20, 7:54 AM · Restricted Project
anwel updated the diff for D72856: [ARM][MVE] Enable masked scatter.
Mon, Jan 20, 3:12 AM · Restricted Project
anwel added inline comments to D72856: [ARM][MVE] Enable masked scatter.
Mon, Jan 20, 3:12 AM · Restricted Project

Thu, Jan 16

anwel created D72856: [ARM][MVE] Enable masked scatter.
Thu, Jan 16, 9:16 AM · Restricted Project
anwel committed rGc24cf9796082: [ARM][MVE] Enable extending gathers (authored by anwel).
[ARM][MVE] Enable extending gathers
Thu, Jan 16, 7:31 AM
anwel closed D72451: [ARM][MVE] Enable extending gathers.
Thu, Jan 16, 7:30 AM · Restricted Project
anwel updated the diff for D72451: [ARM][MVE] Enable extending gathers.
Thu, Jan 16, 5:32 AM · Restricted Project
anwel added inline comments to D72451: [ARM][MVE] Enable extending gathers.
Thu, Jan 16, 5:32 AM · Restricted Project

Wed, Jan 15

anwel updated the diff for D72451: [ARM][MVE] Enable extending gathers.

Small change to make sure that Root will never be changed if no Qd load is built

Wed, Jan 15, 7:07 AM · Restricted Project
anwel added inline comments to D72451: [ARM][MVE] Enable extending gathers.
Wed, Jan 15, 5:35 AM · Restricted Project

Tue, Jan 14

anwel updated the diff for D72451: [ARM][MVE] Enable extending gathers.
Tue, Jan 14, 4:00 AM · Restricted Project
anwel added inline comments to D72451: [ARM][MVE] Enable extending gathers.
Tue, Jan 14, 4:00 AM · Restricted Project
anwel committed rG72ca86fd34ec: [ARM][MVE] Masked gathers from base + vector of offsets (authored by anwel).
[ARM][MVE] Masked gathers from base + vector of offsets
Tue, Jan 14, 2:38 AM
anwel closed D72330: [ARM][MVE] Enable masked gathers from base + vector of offsets.
Tue, Jan 14, 2:37 AM · Restricted Project
anwel updated the diff for D72330: [ARM][MVE] Enable masked gathers from base + vector of offsets.

Rebase and fix a typo.

Tue, Jan 14, 2:33 AM · Restricted Project

Mon, Jan 13

anwel updated the diff for D72330: [ARM][MVE] Enable masked gathers from base + vector of offsets.

Added a space in the debug message.

Mon, Jan 13, 3:29 AM · Restricted Project
anwel updated the diff for D72451: [ARM][MVE] Enable extending gathers.

Simplified the search for the gather instruction's user

Mon, Jan 13, 3:19 AM · Restricted Project
anwel added inline comments to D72451: [ARM][MVE] Enable extending gathers.
Mon, Jan 13, 3:10 AM · Restricted Project
anwel added inline comments to D72451: [ARM][MVE] Enable extending gathers.
Mon, Jan 13, 2:16 AM · Restricted Project
anwel updated the diff for D72451: [ARM][MVE] Enable extending gathers.

Rebase on parent revision which now takes a more moduralised approach

Mon, Jan 13, 2:16 AM · Restricted Project

Fri, Jan 10

anwel added inline comments to D72330: [ARM][MVE] Enable masked gathers from base + vector of offsets.
Fri, Jan 10, 8:02 AM · Restricted Project
anwel updated the diff for D72330: [ARM][MVE] Enable masked gathers from base + vector of offsets.

@dmgreen You are absolutely right about the danger regarding the class variables, I had missed that aspect.
I managed to reduce the number of variables which need to be passed between functions to at most four, which I think is acceptable.
Please have a look and tell me what you think.

Fri, Jan 10, 8:02 AM · Restricted Project
anwel added a parent revision for D72451: [ARM][MVE] Enable extending gathers: D72330: [ARM][MVE] Enable masked gathers from base + vector of offsets.
Fri, Jan 10, 8:02 AM · Restricted Project
anwel added a child revision for D72330: [ARM][MVE] Enable masked gathers from base + vector of offsets: D72451: [ARM][MVE] Enable extending gathers.
Fri, Jan 10, 8:02 AM · Restricted Project
anwel added inline comments to D72330: [ARM][MVE] Enable masked gathers from base + vector of offsets.
Fri, Jan 10, 3:46 AM · Restricted Project
anwel updated the diff for D72330: [ARM][MVE] Enable masked gathers from base + vector of offsets.

Moduralised and re-ordered the code to give it a clearer structure and make the fallback to constructing a "basic" gather easier.

Fri, Jan 10, 3:46 AM · Restricted Project

Thu, Jan 9

anwel created D72451: [ARM][MVE] Enable extending gathers.
Thu, Jan 9, 6:56 AM · Restricted Project
anwel updated the diff for D72330: [ARM][MVE] Enable masked gathers from base + vector of offsets.

Fixed regress in some lines introduced by rebase on llvm master where the parent patch now has been commited.

Thu, Jan 9, 5:40 AM · Restricted Project
anwel updated the diff for D72330: [ARM][MVE] Enable masked gathers from base + vector of offsets.

Fixing a typo.

Thu, Jan 9, 2:20 AM · Restricted Project
anwel updated the diff for D72330: [ARM][MVE] Enable masked gathers from base + vector of offsets.
Thu, Jan 9, 1:49 AM · Restricted Project
anwel added inline comments to D72330: [ARM][MVE] Enable masked gathers from base + vector of offsets.
Thu, Jan 9, 1:49 AM · Restricted Project

Wed, Jan 8

anwel added inline comments to D72330: [ARM][MVE] Enable masked gathers from base + vector of offsets.
Wed, Jan 8, 9:15 AM · Restricted Project
anwel committed rG346f6b54bd12: [ARM][MVE] Enable masked gathers from vector of pointers (authored by anwel).
[ARM][MVE] Enable masked gathers from vector of pointers
Wed, Jan 8, 5:48 AM
anwel closed D71743: [ARM][MVE] Enable masked gathers from vector of pointers.
Wed, Jan 8, 5:48 AM · Restricted Project

Tue, Jan 7

anwel updated the diff for D72330: [ARM][MVE] Enable masked gathers from base + vector of offsets.

Some small changes to address Sam's comments

Tue, Jan 7, 8:40 AM · Restricted Project
anwel added inline comments to D72330: [ARM][MVE] Enable masked gathers from base + vector of offsets.
Tue, Jan 7, 8:39 AM · Restricted Project
anwel updated the diff for D71743: [ARM][MVE] Enable masked gathers from vector of pointers.

Yes, that's a good idea. Better safe then sorry. I added a test that makes sure that the gathers are not constructed if the mve or enable-arm-maskedgatscat option is not set

Tue, Jan 7, 8:11 AM · Restricted Project
anwel created D72330: [ARM][MVE] Enable masked gathers from base + vector of offsets.
Tue, Jan 7, 6:00 AM · Restricted Project
anwel added a parent revision for D72330: [ARM][MVE] Enable masked gathers from base + vector of offsets: D71743: [ARM][MVE] Enable masked gathers from vector of pointers.
Tue, Jan 7, 6:00 AM · Restricted Project
anwel added a child revision for D71743: [ARM][MVE] Enable masked gathers from vector of pointers: D72330: [ARM][MVE] Enable masked gathers from base + vector of offsets.
Tue, Jan 7, 6:00 AM · Restricted Project
anwel updated the diff for D71743: [ARM][MVE] Enable masked gathers from vector of pointers.

Changed the comment in ARMTTIImpl::isLegalMaskedGather to give a better description, and addressed the nits

Tue, Jan 7, 5:13 AM · Restricted Project
anwel added inline comments to D71743: [ARM][MVE] Enable masked gathers from vector of pointers.
Tue, Jan 7, 5:13 AM · Restricted Project

Mon, Jan 6

anwel updated the diff for D71743: [ARM][MVE] Enable masked gathers from vector of pointers.
Mon, Jan 6, 7:38 AM · Restricted Project
anwel updated the diff for D71743: [ARM][MVE] Enable masked gathers from vector of pointers.
Mon, Jan 6, 6:42 AM · Restricted Project
anwel added inline comments to D71743: [ARM][MVE] Enable masked gathers from vector of pointers.
Mon, Jan 6, 6:42 AM · Restricted Project
anwel updated the diff for D71743: [ARM][MVE] Enable masked gathers from vector of pointers.

Moved the transformation of the gather from ARMTargetTransformInfo to a separate FunctionPass.

Mon, Jan 6, 5:32 AM · Restricted Project
anwel added inline comments to D71743: [ARM][MVE] Enable masked gathers from vector of pointers.
Mon, Jan 6, 5:29 AM · Restricted Project

Dec 20 2019

anwel added inline comments to D71743: [ARM][MVE] Enable masked gathers from vector of pointers.
Dec 20 2019, 2:54 AM · Restricted Project
anwel updated the diff for D71743: [ARM][MVE] Enable masked gathers from vector of pointers.

Adopt the changes suggested in comments and give a more detailed summary of the patch and the motivation to do it this way.

Dec 20 2019, 2:54 AM · Restricted Project
anwel created D71743: [ARM][MVE] Enable masked gathers from vector of pointers.
Dec 20 2019, 1:27 AM · Restricted Project

Dec 18 2019

anwel committed rG7cd1cfdd6b6c: [NFC][TTI] Add Alignment for isLegalMasked[Gather/Scatter] (authored by anwel).
[NFC][TTI] Add Alignment for isLegalMasked[Gather/Scatter]
Dec 18 2019, 1:15 AM
anwel closed D71610: [NFC][TTI] Add Alignment for isLegalMasked[Gather/Scatter].
Dec 18 2019, 1:15 AM · Restricted Project

Dec 17 2019

anwel created D71610: [NFC][TTI] Add Alignment for isLegalMasked[Gather/Scatter].
Dec 17 2019, 7:42 AM · Restricted Project

Nov 25 2019

anwel committed rG6fc3e6f2eb96: [ARM][MVE] Select vqneg (authored by anwel).
[ARM][MVE] Select vqneg
Nov 25 2019, 3:30 AM
anwel closed D70491: [ARM][MVE] Select VQNEG.
Nov 25 2019, 3:30 AM · Restricted Project
anwel updated the diff for D70491: [ARM][MVE] Select VQNEG.

Remove trailing whitespace from test

Nov 25 2019, 3:29 AM · Restricted Project

Nov 22 2019

anwel created D70591: [ARM] Allow Usage of R4-R5 as Global Register Variables for ARM.
Nov 22 2019, 3:40 AM · Restricted Project, Restricted Project

Nov 20 2019

anwel created D70491: [ARM][MVE] Select VQNEG.
Nov 20 2019, 7:08 AM · Restricted Project
anwel closed D70181: [MVE] [ARM] Select VQABS.

Pushed this as commit

96e94e37e3a7d62eddd79fe40f025831327a4bfd
Nov 20 2019, 6:11 AM · Restricted Project
anwel committed rG96e94e37e3a7: [ARM][MVE] Select vqabs (authored by anwel).
[ARM][MVE] Select vqabs
Nov 20 2019, 6:00 AM

Nov 19 2019

anwel added inline comments to D70181: [MVE] [ARM] Select VQABS.
Nov 19 2019, 6:43 AM · Restricted Project
anwel updated the diff for D70181: [MVE] [ARM] Select VQABS.

Added a comment that depicts what expression the tree pattern matches.

Nov 19 2019, 6:43 AM · Restricted Project

Nov 18 2019

anwel added inline comments to D70181: [MVE] [ARM] Select VQABS.
Nov 18 2019, 3:06 AM · Restricted Project
anwel updated the diff for D70181: [MVE] [ARM] Select VQABS.

Wrapped vqabs pattern into a multiclass as suggested by @simon_tatham

Nov 18 2019, 2:56 AM · Restricted Project
anwel committed rG2d739f98d8a5: [ARM] Allocatable Global Register Variables for ARM (authored by anwel).
[ARM] Allocatable Global Register Variables for ARM
Nov 18 2019, 2:10 AM

Nov 15 2019

anwel updated the diff for D68862: [ARM] Allocatable Global Register Variables for ARM.
Nov 15 2019, 6:40 AM · Restricted Project, Restricted Project

Nov 14 2019

anwel updated the diff for D68862: [ARM] Allocatable Global Register Variables for ARM.

Change clang's error message when trying to use the target's frame pointer as GRV to sound more like an error then a warning.

Nov 14 2019, 6:08 AM · Restricted Project, Restricted Project
anwel updated the diff for D68862: [ARM] Allocatable Global Register Variables for ARM.

Rebase on current llvm-project master

Nov 14 2019, 4:06 AM · Restricted Project, Restricted Project
anwel committed rGe78083929d1a: [NFC] Fix typo in ARMBaseRegisterInfo (authored by anwel).
[NFC] Fix typo in ARMBaseRegisterInfo
Nov 14 2019, 2:04 AM

Nov 13 2019

anwel created D70181: [MVE] [ARM] Select VQABS.
Nov 13 2019, 7:03 AM · Restricted Project

Oct 30 2019

anwel added inline comments to D68862: [ARM] Allocatable Global Register Variables for ARM.
Oct 30 2019, 7:47 AM · Restricted Project, Restricted Project
anwel updated the diff for D68862: [ARM] Allocatable Global Register Variables for ARM.

Rebase and make some variables const

Oct 30 2019, 7:47 AM · Restricted Project, Restricted Project

Oct 14 2019

anwel updated the diff for D68862: [ARM] Allocatable Global Register Variables for ARM.

Applied some minor changes suggested in the comments, including renaming the array of reserved registers.

Oct 14 2019, 8:06 AM · Restricted Project, Restricted Project

Oct 11 2019

anwel created D68862: [ARM] Allocatable Global Register Variables for ARM.
Oct 11 2019, 2:34 AM · Restricted Project, Restricted Project