Page MenuHomePhabricator

anwel (Anna Welker)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 11 2019, 1:25 AM (60 w, 1 d)

Recent Activity

Aug 28 2020

anwel committed rG064981f0cee4: [ARM][MVE] Enable MVE gathers and scatters by default (authored by anwel).
[ARM][MVE] Enable MVE gathers and scatters by default
Aug 28 2020, 11:06 AM
anwel closed D86776: [ARM]{MVE] Enable MVE gathers and scatters by default.
Aug 28 2020, 11:06 AM · Restricted Project
anwel accepted D86791: [ARM] Correct predicate offset for offset gather/scatter.

LGTM

Aug 28 2020, 9:15 AM · Restricted Project
anwel requested review of D86776: [ARM]{MVE] Enable MVE gathers and scatters by default.
Aug 28 2020, 4:52 AM · Restricted Project

Aug 24 2020

anwel added inline comments to D86452: [LV] Fix scalar cost for tail predicated loops.
Aug 24 2020, 7:38 AM · Restricted Project
anwel updated the diff for D86452: [LV] Fix scalar cost for tail predicated loops.

Thanks for the suggestions, I cleaned up the test so it looks a bit nicer now.

Aug 24 2020, 7:38 AM · Restricted Project
anwel requested review of D86452: [LV] Fix scalar cost for tail predicated loops.
Aug 24 2020, 6:06 AM · Restricted Project
anwel committed rG8048068c3ec5: [ARM][MVE] Allow tail predication for strides !=1 with gather/scatters (authored by anwel).
[ARM][MVE] Allow tail predication for strides !=1 with gather/scatters
Aug 24 2020, 5:55 AM
anwel closed D85410: [ARM][MVE] Allow loops containing strides != 1 to be tail predicated with gather/scatters enabled.
Aug 24 2020, 5:55 AM · Restricted Project
anwel added inline comments to D85410: [ARM][MVE] Allow loops containing strides != 1 to be tail predicated with gather/scatters enabled.
Aug 24 2020, 3:59 AM · Restricted Project

Aug 20 2020

anwel added inline comments to D85410: [ARM][MVE] Allow loops containing strides != 1 to be tail predicated with gather/scatters enabled.
Aug 20 2020, 2:45 AM · Restricted Project
anwel updated the diff for D85410: [ARM][MVE] Allow loops containing strides != 1 to be tail predicated with gather/scatters enabled.

I made the NextStride == 2 condition more future proof as requested by Dave's comment. This required to make the MVEMaxSupportedInterleaveFactor from ARMISelLowering non-static.

Aug 20 2020, 2:45 AM · Restricted Project

Aug 17 2020

anwel added inline comments to D85410: [ARM][MVE] Allow loops containing strides != 1 to be tail predicated with gather/scatters enabled.
Aug 17 2020, 4:21 AM · Restricted Project
anwel updated the diff for D85410: [ARM][MVE] Allow loops containing strides != 1 to be tail predicated with gather/scatters enabled.

Widened the range of allowed strides to also include loop invariant expressions.

Aug 17 2020, 4:21 AM · Restricted Project

Aug 13 2020

anwel committed rG9eb9ba076a7d: [ARM][MVE] Fix for tail predication for loops containing MVE gather/scatters (authored by anwel).
[ARM][MVE] Fix for tail predication for loops containing MVE gather/scatters
Aug 13 2020, 4:25 AM
anwel closed D85889: [ARM][MVE] Fix for tail predication for loops containing MVE gather/scatters.
Aug 13 2020, 4:25 AM · Restricted Project
anwel updated the diff for D85889: [ARM][MVE] Fix for tail predication for loops containing MVE gather/scatters.

Added a test that would fail the VecTy && "No scalable vectors expected here" assert without this fix.

Aug 13 2020, 4:14 AM · Restricted Project
anwel requested review of D85889: [ARM][MVE] Fix for tail predication for loops containing MVE gather/scatters.
Aug 13 2020, 3:04 AM · Restricted Project

Aug 12 2020

anwel committed rG4fe5615eabbb: [ARM][MVE] Enable tail predication for loops containing MVE gather/scatters (authored by anwel).
[ARM][MVE] Enable tail predication for loops containing MVE gather/scatters
Aug 12 2020, 7:33 AM
anwel closed D85138: [ARM][MVE] Enable tail predication for loops containing MVE gather/scatters.
Aug 12 2020, 7:32 AM · Restricted Project

Aug 6 2020

anwel requested review of D85410: [ARM][MVE] Allow loops containing strides != 1 to be tail predicated with gather/scatters enabled.
Aug 6 2020, 1:27 AM · Restricted Project
anwel added inline comments to D85138: [ARM][MVE] Enable tail predication for loops containing MVE gather/scatters.
Aug 6 2020, 12:57 AM · Restricted Project
anwel updated the diff for D85138: [ARM][MVE] Enable tail predication for loops containing MVE gather/scatters.

Changed getVectorType.

Aug 6 2020, 12:57 AM · Restricted Project

Aug 3 2020

anwel requested review of D85138: [ARM][MVE] Enable tail predication for loops containing MVE gather/scatters.
Aug 3 2020, 8:39 AM · Restricted Project

Jul 28 2020

anwel committed rG0c64233bb7ae: [ARM][MVE] Teach MVEGatherScatterLowering to merge successive getelementpointers (authored by anwel).
[ARM][MVE] Teach MVEGatherScatterLowering to merge successive getelementpointers
Jul 28 2020, 9:31 AM
anwel closed D84027: [ARM][MVE] Teach MVEGatherScatterLowering to merge successive getelementpointers.
Jul 28 2020, 9:31 AM · Restricted Project

Jul 27 2020

anwel added inline comments to D84027: [ARM][MVE] Teach MVEGatherScatterLowering to merge successive getelementpointers.
Jul 27 2020, 5:17 AM · Restricted Project
anwel updated the diff for D84027: [ARM][MVE] Teach MVEGatherScatterLowering to merge successive getelementpointers.
Jul 27 2020, 5:17 AM · Restricted Project

Jul 21 2020

anwel added inline comments to D84027: [ARM][MVE] Teach MVEGatherScatterLowering to merge successive getelementpointers.
Jul 21 2020, 2:53 AM · Restricted Project
anwel updated the diff for D84027: [ARM][MVE] Teach MVEGatherScatterLowering to merge successive getelementpointers.
Jul 21 2020, 2:52 AM · Restricted Project

Jul 17 2020

anwel created D84027: [ARM][MVE] Teach MVEGatherScatterLowering to merge successive getelementpointers.
Jul 17 2020, 7:57 AM · Restricted Project
anwel committed rG23c9534515ee: [LV] Enable the LoopVectorizer to create pointer inductions (authored by anwel).
[LV] Enable the LoopVectorizer to create pointer inductions
Jul 17 2020, 5:35 AM
anwel closed D81267: [LV] Enable the LoopVectorizer to create pointer inductions.
Jul 17 2020, 5:35 AM · Restricted Project

Jul 10 2020

anwel added inline comments to D81267: [LV] Enable the LoopVectorizer to create pointer inductions.
Jul 10 2020, 3:03 AM · Restricted Project
anwel updated the diff for D81267: [LV] Enable the LoopVectorizer to create pointer inductions.

Revisited the new test to make it cleaner.

Jul 10 2020, 3:03 AM · Restricted Project

Jul 9 2020

anwel accepted D83459: Correctly update return status for MVEGatherScatterLowering.

LGTM - Changed should indeed reflect possible changes by that function, too.

Jul 9 2020, 1:21 AM · Restricted Project

Jul 8 2020

anwel updated the diff for D81267: [LV] Enable the LoopVectorizer to create pointer inductions.

Hi, there was a bug concerning the location at which the new getelementptr instruction would be generated, thanks for catching this.
I have fixed the bug and derived a LoopVectorize test case from your C example.

Jul 8 2020, 5:49 AM · Restricted Project

Jul 2 2020

anwel committed rGa8fe12065ec8: [LV] Enable the LoopVectorizer to create pointer inductions (authored by anwel).
[LV] Enable the LoopVectorizer to create pointer inductions
Jul 2 2020, 3:44 AM
anwel closed D81267: [LV] Enable the LoopVectorizer to create pointer inductions.
Jul 2 2020, 3:43 AM · Restricted Project

Jun 26 2020

anwel updated the diff for D81267: [LV] Enable the LoopVectorizer to create pointer inductions.

All nitpicks have been addressed.

Jun 26 2020, 2:08 AM · Restricted Project
anwel added inline comments to D81267: [LV] Enable the LoopVectorizer to create pointer inductions.
Jun 26 2020, 2:08 AM · Restricted Project

Jun 5 2020

anwel created D81267: [LV] Enable the LoopVectorizer to create pointer inductions.
Jun 5 2020, 8:52 AM · Restricted Project

May 15 2020

anwel committed rG4ec340c3e99c: [ARM][MVE] Add support for incrementing scatters (authored by anwel).
[ARM][MVE] Add support for incrementing scatters
May 15 2020, 9:13 AM
anwel closed D79859: [ARM][MVE] Add support for incrementing scatters.
May 15 2020, 9:13 AM · Restricted Project
anwel added inline comments to D79859: [ARM][MVE] Add support for incrementing scatters.
May 15 2020, 6:27 AM · Restricted Project
anwel updated the diff for D79859: [ARM][MVE] Add support for incrementing scatters.
May 15 2020, 6:27 AM · Restricted Project

May 14 2020

anwel added a comment to D79941: [NFCI][CostModel] Refactor getIntrinsicInstrCost.

Hi Sam, those tests are checking whether the cost model calculates the costs for zext(gather(...)) and scatter(trunc(..)) correctly, because these can be integrated in the MVE intrinsics.
That calculation relies on I being available. I see that you did integrate I in IntrinsicCostAttributes, as an IntrinsicInst; the gather/scatter cost function was taking an Instruction because when it is called we might either be looking at a gather/scatter intrinsic or still at an LLVM load/store, which I think is no intrinsic?
I can't see where it happens, but my guess is that the instruction that ends up being handed over to getGatherScatterOpCost in BasicTTIImpl::getIntrinsicInstrCost doesn't match what was expected anymore.

May 14 2020, 9:10 AM · Restricted Project

May 13 2020

anwel created D79859: [ARM][MVE] Add support for incrementing scatters.
May 13 2020, 7:00 AM · Restricted Project

May 7 2020

anwel committed rG1e413a8c36bf: [ARM][MVE] Add support for incrementing gathers (authored by anwel).
[ARM][MVE] Add support for incrementing gathers
May 7 2020, 5:04 AM
anwel closed D76786: [ARM][MVE] Add support for incrementing gathers.
May 7 2020, 5:03 AM · Restricted Project
anwel updated the diff for D76786: [ARM][MVE] Add support for incrementing gathers.

Last correction: For the incrementing non-writeback gathers, removed the check that the offset only has one use.

May 7 2020, 3:55 AM · Restricted Project

May 6 2020

anwel added inline comments to D76786: [ARM][MVE] Add support for incrementing gathers.
May 6 2020, 6:24 AM · Restricted Project
anwel updated the diff for D76786: [ARM][MVE] Add support for incrementing gathers.

Applied the chances suggested in the comments.

May 6 2020, 6:24 AM · Restricted Project

May 4 2020

anwel added inline comments to D76786: [ARM][MVE] Add support for incrementing gathers.
May 4 2020, 7:59 AM · Restricted Project
anwel updated the diff for D76786: [ARM][MVE] Add support for incrementing gathers.

Made optimisation of offsets independent of the creation of the individual gathers and scatters, such that when looking at transforming those we're not in an environment where some instructions have been optimised but others, which will be optimised too, haven't been yet.

May 4 2020, 7:59 AM · Restricted Project
anwel updated the diff for D76786: [ARM][MVE] Add support for incrementing gathers.

Restructured the code such that the differentiation between writeback and non-writeback gathers is clearer

May 4 2020, 4:46 AM · Restricted Project

Apr 29 2020

anwel updated the diff for D76786: [ARM][MVE] Add support for incrementing gathers.

Fixing a bug in the latest diff: We should always make sure to scale the offsets that the loop is initialised with.

Apr 29 2020, 3:42 AM · Restricted Project

Apr 28 2020

anwel added inline comments to D76786: [ARM][MVE] Add support for incrementing gathers.
Apr 28 2020, 5:19 AM · Restricted Project
anwel updated the diff for D76786: [ARM][MVE] Add support for incrementing gathers.
Apr 28 2020, 5:19 AM · Restricted Project

Apr 20 2020

anwel updated the diff for D76786: [ARM][MVE] Add support for incrementing gathers.
Apr 20 2020, 7:31 AM · Restricted Project
anwel updated the diff for D76786: [ARM][MVE] Add support for incrementing gathers.

Fixed calculation of the constant in getIfConst, moved isGatherScatter to ARMBaseInstrInfo so it is accessible for other passes, too.

Apr 20 2020, 7:31 AM · Restricted Project

Apr 16 2020

anwel committed rGd736571538bd: [ARM][MVE] Fix location of optimized gather addresses (authored by anwel).
[ARM][MVE] Fix location of optimized gather addresses
Apr 16 2020, 10:35 AM
anwel closed D78293: [ARM][MVE] Fix location of optimized gather addresses.
Apr 16 2020, 10:35 AM · Restricted Project
anwel created D78293: [ARM][MVE] Fix location of optimized gather addresses.
Apr 16 2020, 5:36 AM · Restricted Project
anwel added inline comments to D76786: [ARM][MVE] Add support for incrementing gathers.
Apr 16 2020, 3:56 AM · Restricted Project

Apr 15 2020

anwel updated the diff for D76786: [ARM][MVE] Add support for incrementing gathers.

Made some changes suggested in the comments, and also re-ordered the code such that it is easier to follow.

Apr 15 2020, 3:47 AM · Restricted Project

Apr 8 2020

anwel committed rG89e1248d7b76: [ARM][MVE] Optimise offset addresses of gathers/scatters (authored by anwel).
[ARM][MVE] Optimise offset addresses of gathers/scatters
Apr 8 2020, 3:47 AM
anwel closed D76681: [ARM][MVE] Optimise offset addresses of gathers/scatters.
Apr 8 2020, 3:47 AM · Restricted Project

Apr 6 2020

anwel added inline comments to D76681: [ARM][MVE] Optimise offset addresses of gathers/scatters.
Apr 6 2020, 8:05 AM · Restricted Project
anwel updated the diff for D76681: [ARM][MVE] Optimise offset addresses of gathers/scatters.
Apr 6 2020, 8:05 AM · Restricted Project

Mar 31 2020

anwel added inline comments to D76681: [ARM][MVE] Optimise offset addresses of gathers/scatters.
Mar 31 2020, 3:18 AM · Restricted Project
anwel updated the diff for D76681: [ARM][MVE] Optimise offset addresses of gathers/scatters.

Implemented some changes suggested in comments (see below for details)

Mar 31 2020, 3:18 AM · Restricted Project

Mar 30 2020

anwel added inline comments to D76786: [ARM][MVE] Add support for incrementing gathers.
Mar 30 2020, 4:17 AM · Restricted Project
anwel updated the diff for D76786: [ARM][MVE] Add support for incrementing gathers.

Changes addressing most of the comments - see below.

Mar 30 2020, 4:17 AM · Restricted Project

Mar 27 2020

anwel added inline comments to D76681: [ARM][MVE] Optimise offset addresses of gathers/scatters.
Mar 27 2020, 8:12 AM · Restricted Project
anwel updated the diff for D76681: [ARM][MVE] Optimise offset addresses of gathers/scatters.

Added scatter tests, and some code changes (see comments).

Mar 27 2020, 8:12 AM · Restricted Project

Mar 25 2020

anwel created D76786: [ARM][MVE] Add support for incrementing gathers.
Mar 25 2020, 10:48 AM · Restricted Project
anwel added inline comments to D76681: [ARM][MVE] Optimise offset addresses of gathers/scatters.
Mar 25 2020, 9:09 AM · Restricted Project
anwel updated the diff for D76681: [ARM][MVE] Optimise offset addresses of gathers/scatters.
Mar 25 2020, 9:09 AM · Restricted Project

Mar 24 2020

anwel created D76681: [ARM][MVE] Optimise offset addresses of gathers/scatters.
Mar 24 2020, 3:12 AM · Restricted Project

Mar 11 2020

anwel committed rGa6d3bec83fca: [TTI][ARM][MVE] Refine gather/scatter cost model (authored by anwel).
[TTI][ARM][MVE] Refine gather/scatter cost model
Mar 11 2020, 3:47 AM
anwel closed D75525: [TTI][ARM][MVE] Refine gather/scatter cost model.
Mar 11 2020, 3:47 AM · Restricted Project
anwel added inline comments to D75525: [TTI][ARM][MVE] Refine gather/scatter cost model.
Mar 11 2020, 3:03 AM · Restricted Project

Mar 9 2020

anwel added inline comments to D75525: [TTI][ARM][MVE] Refine gather/scatter cost model.
Mar 9 2020, 3:43 AM · Restricted Project
anwel updated the diff for D75525: [TTI][ARM][MVE] Refine gather/scatter cost model.

Moved around some tests and add two more.
Also made sure that extends or truncs to 'incomplete' vector types are not considered valid candidates to be merged into the gather.

Mar 9 2020, 3:43 AM · Restricted Project

Mar 4 2020

anwel updated the diff for D75525: [TTI][ARM][MVE] Refine gather/scatter cost model.

Implemented some of the changes suggested in comments.

Mar 4 2020, 6:11 AM · Restricted Project
anwel added inline comments to D75525: [TTI][ARM][MVE] Refine gather/scatter cost model.
Mar 4 2020, 6:11 AM · Restricted Project

Mar 3 2020

anwel created D75525: [TTI][ARM][MVE] Refine gather/scatter cost model.
Mar 3 2020, 7:32 AM · Restricted Project

Mar 2 2020

anwel committed rG394974111b17: [ARM][MVE] Restrict allowed types of gather/scatter offsets (authored by anwel).
[ARM][MVE] Restrict allowed types of gather/scatter offsets
Mar 2 2020, 2:19 AM
anwel closed D75361: [ARM][MVE] Restrict allowed types of gather/scatter offsets.
Mar 2 2020, 2:18 AM · Restricted Project

Feb 28 2020

anwel created D75361: [ARM][MVE] Restrict allowed types of gather/scatter offsets.
Feb 28 2020, 9:10 AM · Restricted Project

Jan 21 2020

anwel committed rGff9877ce34b8: [ARM][MVE] Enable masked scatter (authored by anwel).
[ARM][MVE] Enable masked scatter
Jan 21 2020, 1:53 AM
anwel closed D72856: [ARM][MVE] Enable masked scatter.
Jan 21 2020, 1:53 AM · Restricted Project

Jan 20 2020

anwel updated the diff for D72856: [ARM][MVE] Enable masked scatter.
Jan 20 2020, 8:53 AM · Restricted Project
anwel added inline comments to D72856: [ARM][MVE] Enable masked scatter.
Jan 20 2020, 8:52 AM · Restricted Project
anwel added inline comments to D73021: [ARM] Basic gather scatter cost model.
Jan 20 2020, 7:54 AM · Restricted Project
anwel updated the diff for D72856: [ARM][MVE] Enable masked scatter.
Jan 20 2020, 3:12 AM · Restricted Project
anwel added inline comments to D72856: [ARM][MVE] Enable masked scatter.
Jan 20 2020, 3:12 AM · Restricted Project

Jan 16 2020

anwel created D72856: [ARM][MVE] Enable masked scatter.
Jan 16 2020, 9:16 AM · Restricted Project
anwel committed rGc24cf9796082: [ARM][MVE] Enable extending gathers (authored by anwel).
[ARM][MVE] Enable extending gathers
Jan 16 2020, 7:31 AM