Page MenuHomePhabricator

[flang][NFC] Change how error symbols are recorded
ClosedPublic

Authored by tskeith on Aug 27 2020, 2:46 PM.

Details

Summary

When an error is associated with a symbol, it was marked with a flag
from Symbol::Flag. The problem with that is that you need a mutable
symbol to do that. Instead, store the set of error symbols in the
SemanticsContext. This allows for some const_casts to be eliminated.

Also, improve the internal error that occurs if SetError is called
but no fatal error has been reported.

Diff Detail

Event Timeline

tskeith created this revision.Aug 27 2020, 2:46 PM
Herald added a project: Restricted Project. · View Herald Transcript
tskeith requested review of this revision.Aug 27 2020, 2:46 PM
PeteSteinfeld accepted this revision.Aug 27 2020, 3:19 PM

All builds, tests, and looks good.

This revision is now accepted and ready to land.Aug 27 2020, 3:19 PM
sscalpone accepted this revision.Aug 27 2020, 4:55 PM
This revision was automatically updated to reflect the committed changes.